Skip to contentSkip to conversation

iio: adc: npcm: use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: npcm: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Reduces local boilerplate code.
Suggested by coccinelle via coccicheck.

CHECK drivers/iio/adc/npcm_adc.c
drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

---
 drivers/iio/adc/npcm_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/npcm_adc.c +1 -3
index 910f3585fa54..a6170a37ebe8 100644
@@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device *pdev)
 	int irq;
 	u32 div;
 	u32 reg_con;
-	struct resource *res;
 	struct npcm_adc *info;
 	struct iio_dev *indio_dev;
 	struct device *dev = &pdev->dev;
@@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device *pdev)
 
 	info->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, res);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sun, 2019-10-13 at 16:44 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduces local boilerplate code.
Suggested by coccinelle via coccicheck.

CHECK drivers/iio/adc/npcm_adc.c
drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use
devm_platform_ioremap_resource for info -> regs

Quoted 30 lines
---
 drivers/iio/adc/npcm_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/npcm_adc.c +0 -1
index 910f3585fa54..a6170a37ebe8 100644
@@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device
 *pdev)
 	int irq;
 	u32 div;
 	u32 reg_con;
-	struct resource *res;
 	struct npcm_adc *info;
 	struct iio_dev *indio_dev;
drivers/iio/adc/npcm_adc.c +1 -2
 	struct device *dev = &pdev->dev;
@@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device
 *pdev)
 
 	info->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, res);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
author maintainer Applied
#2 lore raw
Quoted 6 lines · Alexandru
Quoted 5 lines · On Sun, 2019-10-13 at 16:44 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduces local boilerplate code.
Suggested by coccinelle via coccicheck.

Quoted 6 lines
Quoted 4 lines

CHECK drivers/iio/adc/npcm_adc.c
drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use
devm_platform_ioremap_resource for info -> regs

Applied,

Thanks,

Jonathan

Quoted 31 lines
Quoted 31 lines
---
 drivers/iio/adc/npcm_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/npcm_adc.c +0 -1
index 910f3585fa54..a6170a37ebe8 100644
@@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device
 *pdev)
 	int irq;
 	u32 div;
 	u32 reg_con;
-	struct resource *res;
 	struct npcm_adc *info;
 	struct iio_dev *indio_dev;
drivers/iio/adc/npcm_adc.c +1 -2
 	struct device *dev = &pdev->dev;
@@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device
 *pdev)
 
 	info->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, res);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);