Skip to contentSkip to conversation

iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Avoids some local boilerplate.
Suggested by coccinelle.

CHECK drivers/iio/adc/rcar-gyroadc.c
drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use devm_platform_ioremap_resource for priv -> regs

---
 drivers/iio/adc/rcar-gyroadc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/rcar-gyroadc.c +1 -3
index c37f201294b2..63ce743ee7af 100644
@@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct rcar_gyroadc *priv;
 	struct iio_dev *indio_dev;
-	struct resource *mem;
 	int ret;
 
 	indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
@@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device *pdev)
 	priv = iio_priv(indio_dev);
 	priv->dev = dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	priv->regs = devm_ioremap_resource(dev, mem);
+	priv->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(priv->regs))
 		return PTR_ERR(priv->regs);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sun, 2019-10-13 at 16:48 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Avoids some local boilerplate.
Suggested by coccinelle.

CHECK drivers/iio/adc/rcar-gyroadc.c
drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use devm_platform_ioremap_resource for priv -> regs

Quoted 31 lines
---
 drivers/iio/adc/rcar-gyroadc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/rcar- renamed from drivers/iio/adc/rcar-gyroadc.c +0 -0

gyroadc.c
index c37f201294b2..63ce743ee7af 100644

drivers/iio/adc/rcar-gyroadc.c +0 -1
@@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device
 *pdev)
 	struct device *dev = &pdev->dev;
 	struct rcar_gyroadc *priv;
 	struct iio_dev *indio_dev;
-	struct resource *mem;
 	int ret;
 
drivers/iio/adc/rcar-gyroadc.c +1 -2
 	indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
@@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device
 *pdev)
 	priv = iio_priv(indio_dev);
 	priv->dev = dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	priv->regs = devm_ioremap_resource(dev, mem);
+	priv->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(priv->regs))
 		return PTR_ERR(priv->regs);
author maintainer Applied
#2 lore raw
Quoted 6 lines · Alexandru
Quoted 5 lines · On Sun, 2019-10-13 at 16:48 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Avoids some local boilerplate.
Suggested by coccinelle.

Quoted 6 lines
Quoted 4 lines

CHECK drivers/iio/adc/rcar-gyroadc.c
drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use devm_platform_ioremap_resource for priv -> regs

Applied,

Thanks,

Jonathan

Quoted 32 lines
Quoted 32 lines
---
 drivers/iio/adc/rcar-gyroadc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/rcar- renamed from drivers/iio/adc/rcar-gyroadc.c +0 -0

gyroadc.c
index c37f201294b2..63ce743ee7af 100644

drivers/iio/adc/rcar-gyroadc.c +0 -1
@@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device
 *pdev)
 	struct device *dev = &pdev->dev;
 	struct rcar_gyroadc *priv;
 	struct iio_dev *indio_dev;
-	struct resource *mem;
 	int ret;
 
drivers/iio/adc/rcar-gyroadc.c +1 -2
 	indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
@@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device
 *pdev)
 	priv = iio_priv(indio_dev);
 	priv->dev = dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	priv->regs = devm_ioremap_resource(dev, mem);
+	priv->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(priv->regs))
 		return PTR_ERR(priv->regs);