iio: dac: lpc18xx: Use devm_platform_ioremap_resource
Subsystems (2)
[email protected]
maintainerPATCH 1/1 iio: dac: lpc18xx: Use devm_platform_ioremap_resource
From: Jonathan Cameron <[email protected]>
Reduce boilerplate.
Suggested by coccinelle
CHECK drivers/iio/dac/lpc18xx_dac.c
drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use devm_platform_ioremap_resource for dac -> base
Signed-off-by Jonathan Cameron <[email protected]>
CC Joachim Eastwood <[email protected]>
--- drivers/iio/dac/lpc18xx_dac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/dac/lpc18xx_dac.c +1 -3
@@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) {struct iio_dev *indio_dev;struct lpc18xx_dac *dac; -struct resource *res;int ret; indio_dev =devm_iio_device_alloc (&pdev->dev,sizeof (*dac));
@@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) dac =iio_priv (indio_dev);mutex_init (&dac->lock); - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - dac->base =devm_ioremap_resource (&pdev->dev, res); + dac->base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (dac->base))return PTR_ERR (dac->base);
Signature · 1 line
2.23.0
Quoted 8 lines · On Sun, 2019-10-13 at 18:14 +0100, [email protected] wrote:
From: Jonathan Cameron <[email protected]>
Reduce boilerplate.
Suggested by coccinelle
CHECKdrivers/iio/dac/lpc18xx_dac.c
drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Usedevm_platform_ioremap_resourcefor dac -> base
Reviewed-by Alexandru Ardelean <[email protected]>
Quoted 31 lines
Signed-off-by Jonathan Cameron <[email protected]>CC Joachim Eastwood <[email protected]>--- drivers/iio/dac/lpc18xx_dac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/iio/dac/lpc18xx_dac.c +0
-1@@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) {struct iio_dev *indio_dev;struct lpc18xx_dac *dac; -struct resource *res;int ret;drivers/iio/dac/lpc18xx_dac.c +1
-2indio_dev =devm_iio_device_alloc (&pdev->dev,sizeof (*dac));@@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) dac =iio_priv (indio_dev);mutex_init (&dac->lock); - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - dac->base =devm_ioremap_resource (&pdev->dev, res); + dac->base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (dac->base))return PTR_ERR (dac->base);
Quoted 12 lines · Alexandru
Quoted 8 lines · On Sun, 2019-10-13 at 18:14 +0100, [email protected] wrote:
From: Jonathan Cameron <[email protected]>
Reduce boilerplate.
Suggested by coccinelle
CHECKdrivers/iio/dac/lpc18xx_dac.c
drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Usedevm_platform_ioremap_resourcefor dac -> baseReviewed-by Alexandru Ardelean <[email protected]>
Applied,
Thanks,
J
Quoted 31 lines
Quoted 31 lines
Signed-off-by Jonathan Cameron <[email protected]>CC Joachim Eastwood <[email protected]>--- drivers/iio/dac/lpc18xx_dac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/iio/dac/lpc18xx_dac.c +0
-1@@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) {struct iio_dev *indio_dev;struct lpc18xx_dac *dac; -struct resource *res;int ret;drivers/iio/dac/lpc18xx_dac.c +1
-2indio_dev =devm_iio_device_alloc (&pdev->dev,sizeof (*dac));@@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) dac =iio_priv (indio_dev);mutex_init (&dac->lock); - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - dac->base =devm_ioremap_resource (&pdev->dev, res); + dac->base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (dac->base))return PTR_ERR (dac->base);