Skip to contentSkip to conversation

iio: dac: vf610: Use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019 IIO

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: dac: vf610: Use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Reduce local boilerplate.
Suggested by coccinelle

CHECK drivers/iio/dac/vf610_dac.c
drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

---
 drivers/iio/dac/vf610_dac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/dac/vf610_dac.c +1 -3
index 0ec4d2609ef9..71f8a5c471c4 100644
@@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device *pdev)
 {
 	struct iio_dev *indio_dev;
 	struct vf610_dac *info;
-	struct resource *mem;
 	int ret;
 
 	indio_dev = devm_iio_device_alloc(&pdev->dev,
@@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device *pdev)
 	info = iio_priv(indio_dev);
 	info->dev = &pdev->dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sun, 2019-10-13 at 18:17 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduce local boilerplate.
Suggested by coccinelle

CHECK drivers/iio/dac/vf610_dac.c
drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

Quoted 30 lines
---
 drivers/iio/dac/vf610_dac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/dac/vf610_dac.c +0 -1
index 0ec4d2609ef9..71f8a5c471c4 100644
@@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device
 *pdev)
 {
 	struct iio_dev *indio_dev;
 	struct vf610_dac *info;
-	struct resource *mem;
 	int ret;
 
drivers/iio/dac/vf610_dac.c +1 -2
 	indio_dev = devm_iio_device_alloc(&pdev->dev,
@@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device
 *pdev)
 	info = iio_priv(indio_dev);
 	info->dev = &pdev->dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);
author maintainer Applied
#2 lore raw
Quoted 6 lines · Alexandru
Quoted 5 lines · On Sun, 2019-10-13 at 18:17 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduce local boilerplate.
Suggested by coccinelle

Quoted 6 lines
Quoted 4 lines

CHECK drivers/iio/dac/vf610_dac.c
drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

Applied,

Thanks,

Jonathan

Quoted 31 lines
Quoted 31 lines
---
 drivers/iio/dac/vf610_dac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/dac/vf610_dac.c +0 -1
index 0ec4d2609ef9..71f8a5c471c4 100644
@@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device
 *pdev)
 {
 	struct iio_dev *indio_dev;
 	struct vf610_dac *info;
-	struct resource *mem;
 	int ret;
 
drivers/iio/dac/vf610_dac.c +1 -2
 	indio_dev = devm_iio_device_alloc(&pdev->dev,
@@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device
 *pdev)
 	info = iio_priv(indio_dev);
 	info->dev = &pdev->dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);