mlxsw: core: Enable devlink reload only on probe
Subsystems (3)
PATCH 1/1 mlxsw: core: Enable devlink reload only on probe
From: Jiri Pirko <[email protected]>
Call devlink enable only during probe time and avoid deadlock during reload.
Reported-by Shalom Toledo <[email protected]>
Fixes a0c76345e3d3 ("devlink: disallow reload operation during device cleanup")
Signed-off-by Jiri Pirko <[email protected]>
--- drivers/net/ethernet/mellanox/mlxsw/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/core.c +3 -2
@@ -1198,10 +1198,11 @@ __mlxsw_core_bus_device_register(const struct mlxsw_bus_info *mlxsw_bus_info,if (err) goto err_thermal_init; -if (mlxsw_driver->params_register) { +if (mlxsw_driver->params_register)devlink_params_publish (devlink); + +if (!reload)devlink_reload_enable (devlink); - }return 0 ;
Signature · 1 line
2.21.0
Quoted 8 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
Call devlink enable only during probe time and avoid deadlock during reload.
Reported-by Shalom Toledo <[email protected]>Fixes a0c76345e3d3 ("devlink: disallow reload operation during device cleanup")Signed-off-by Jiri Pirko <[email protected]>
Tested-by Shalom Toledo <[email protected]>
David Miller
AppliedFrom: Jiri Pirko <[email protected]>
Date: Sun, 10 Nov 2019 16:31:44 +0100
Quoted 8 lines
From: Jiri Pirko <[email protected]>
Call devlink enable only during probe time and avoid deadlock during reload.
Reported-by Shalom Toledo <[email protected]>Fixes a0c76345e3d3 ("devlink: disallow reload operation during device cleanup")Signed-off-by Jiri Pirko <[email protected]>
Applied.