Skip to contentSkip to conversation

add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension

PATCH New Sergey Matyukevich 2 participants 3 messages Nov 11, 2019 – Nov 12, 2019 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension

Quoted 5 lines
---
 boot/arm-trusted-firmware/Config.in               | 7 +++++++
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
 2 files changed, 10 insertions(+), 1 deletion(-)

...

Review

Quoted 8 lines

define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS

(quoted diff) +3 -1
-	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
+	$(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
+		cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
+	)
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
 endef

Looks good to me: Reviewed-by: Sergey Matyukevich <[email protected]>

For better understanding of the rationale behind the change, it would be great if you could share some technical details of your use-case.

Regards,
Sergey

A message that is not in the archive (sent off-list or not yet received): DB7PR04MB500309181A711B70FEB5B58181740@DB7PR04MB5003.eurprd04.prod.outlook.com

#3 lore raw

PATCH 1/1 add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension

Quoted 3 lines

Hi,

recently I've starting to make a little playground for using STM32MP1 (https://github.com/schenkmi/buildroot-op-tee-stm32mp1) with OP-TEE build with Buildroot. The proposed change is for platforms like the STM32MP1 which add some special headers to the final binary and add a different file ending. In the STM32MP1 the ATF binaries are called *.stm32. A similar change already exist for U-BOOT and optee-os but was missing for ATF.

Hi Michael,

Thanks for clarification. BTW, for some reason I don't see your patch in buildroot patchwork system. Though I am not sure if this is a problem for maintainers...

Regards,
Sergey

#4 lore raw

PATCH 1/1 add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension

Quoted 9 lines · On Tue, 12 Nov 2019 23:17:12 +0300 Sergey Matyukevich <[email protected]>…
Quoted 3 lines

Hi,

recently I've starting to make a little playground for using STM32MP1 (https://github.com/schenkmi/buildroot-op-tee-stm32mp1) with OP-TEE build with Buildroot. The proposed change is for platforms like the STM32MP1 which add some special headers to the final binary and add a different file ending. In the STM32MP1 the ATF binaries are called *.stm32. A similar change already exist for U-BOOT and optee-os but was missing for ATF.

Hi Michael,

Thanks for clarification. BTW, for some reason I don't see your patch in buildroot patchwork system. Though I am not sure if this is a problem for maintainers...

In fact, it seems like the initial e-mail from Michael didn't made it to the list at all. At least, I don't see it in my local archives of the mailing list.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com