Skip to contentSkip to conversation

dt-bindings: leds: lm3630a: Fix the example compilation

PATCH In review Maxime Ripard 3 participants 3 messages Oct 31, 2019 – Nov 11, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: leds: lm3630a: Fix the example compilation

Commit ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin") introduced in the example a GPIO flag that isn't declared anywhere, resulting in a compilation breakage when running the validation tools. Add the proper define.

Cc Andreas Kemnade <[email protected]>
Cc Lee Jones <[email protected]>
Fixes ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin")
---
 .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml   | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +2 -0
index c8470628fe02..72fc6f7ef90a 100644
@@ -93,6 +93,8 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/gpio/gpio.h>
+
     i2c {
         #address-cells = <1>;
         #size-cells = <0>;
Signature · 1 line
2.23.0
#1 lore raw
Quoted 6 lines · Maxime Ripard

Commit ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin") introduced in the example a GPIO flag that isn't declared anywhere, resulting in a compilation breakage when running the validation tools. Add the proper define.

Quoted 7 lines
Cc Andreas Kemnade <[email protected]>
Cc Lee Jones <[email protected]>
Fixes ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin")
---
 .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml   | 2 ++
 1 file changed, 2 insertions(+)

Lee already applied a fix. Though it's not in linux-next yet.

Rob

#2 lore raw
Quoted 15 lines · Rob Herring
Quoted 6 lines · Maxime Ripard

Commit ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin") introduced in the example a GPIO flag that isn't declared anywhere, resulting in a compilation breakage when running the validation tools. Add the proper define.

Quoted 7 lines
Cc Andreas Kemnade <[email protected]>
Cc Lee Jones <[email protected]>
Fixes ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin")
---
 .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml   | 2 ++
 1 file changed, 2 insertions(+)
Quoted 1 line

Lee already applied a fix. Though it's not in linux-next yet.

It is now.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog