Skip to contentSkip to conversation

Introduce a description of a new optional tag for Backports

PATCH Superseded Stefano Stabellini 7 participants 12 messages Nov 8, 2019 – Jan 29, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Introduce a description of a new optional tag for Backports

---
 docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 docs/process/backport-tag.pandoc
docs/process/backport-tag.pandoc new file +23 -0
new file mode 100644
index 0000000000..e570efdcc8
@@ -0,0 +1,23 @@
+Backport Tag
+------------
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the stable trees:
+
+    Backport: all
+
+It marks a commit for being a candidate for backports to all relevant
+trees.
+
+    Backport: 4.9+
+
+It marks a commit for being a candidate for backports to all stable
+trees from 4.9 onward.
+
+Maintainers request the Backport tag to be added on commit.
+Contributors are also welcome to mark their patches with the Backport
+tag when they deem appropriate. Maintainers will request for it to be
+removed when that is not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the stable tree maintainers.
Signature · 7 lines
2.17.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#3 lore raw
In reply to Stefano Stabellini
Quoted 33 lines · Stefano Stabellini
---
 docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 docs/process/backport-tag.pandoc
docs/process/backport-tag.pandoc new file +13 -0
new file mode 100644
index 0000000000..e570efdcc8
@@ -0,0 +1,23 @@
+Backport Tag
+------------
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the stable trees:
+
+    Backport: all
+
+It marks a commit for being a candidate for backports to all relevant
+trees.
+
+    Backport: 4.9+
+

docs/process/backport-tag.pandoc line 23

Quoted 10 lines
docs/process/backport-tag.pandoc new file +10 -0
+It marks a commit for being a candidate for backports to all stable
+trees from 4.9 onward.
+
+Maintainers request the Backport tag to be added on commit.
+Contributors are also welcome to mark their patches with the Backport
+tag when they deem appropriate. Maintainers will request for it to be
+removed when that is not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the stable tree maintainers.

The text and the idea both look good to me.

But it seems kind of balkanized to put it in its own file. Would it be better to try to make a slightly more general bit of content? Either about the backport process, or about tags in general?

(This would simply be renaming the file; not expecting you to generate extra content.)

-George

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw

On 11/11/2019, 08:12, "George Dunlap" <[email protected]> wrote:

On 11/8/19 7:09 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <[email protected]> > CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> ---
> docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 docs/process/backport-tag.pandoc
>
> diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc > new file mode 100644
> index 0000000000..e570efdcc8
> --- /dev/null
> +++ b/docs/process/backport-tag.pandoc
> @@ -0,0 +1,23 @@
> +Backport Tag
> +------------
> +
> +A backport tag is an optional tag in the commit message to request a > +given commit to be backported to the stable trees:
> +
> + Backport: all
> +
> +It marks a commit for being a candidate for backports to all relevant > +trees.
> +
> + Backport: 4.9+
> +
> +It marks a commit for being a candidate for backports to all stable > +trees from 4.9 onward.
> +
> +Maintainers request the Backport tag to be added on commit.
> +Contributors are also welcome to mark their patches with the Backport > +tag when they deem appropriate. Maintainers will request for it to be > +removed when that is not the case.
> +
> +Please note that the Backport tag is a **request** for backport, which > +will still need to be evaluated by the stable tree maintainers.

The text and the idea both look good to me.

But it seems kind of balkanized to put it in its own file. Would it be better to try to make a slightly more general bit of content? Either about the backport process, or about tags in general?

It should be in https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F
What is currently missing is
- Release-Acked-by
- The new proposed tag

But maybe we should have a master document in tree, which defines the tags in use
And then I can refer to it from https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F

Regards
Lars

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
Quoted 47 lines · Lars Kurth

On 11/11/2019, 08:12, "George Dunlap" <[email protected]> wrote:

On 11/8/19 7:09 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <[email protected]> > CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> ---
> docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 docs/process/backport-tag.pandoc
>
> diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc > new file mode 100644
> index 0000000000..e570efdcc8
> --- /dev/null
> +++ b/docs/process/backport-tag.pandoc
> @@ -0,0 +1,23 @@
> +Backport Tag
> +------------
> +
> +A backport tag is an optional tag in the commit message to request a > +given commit to be backported to the stable trees:
> +
> + Backport: all
> +
> +It marks a commit for being a candidate for backports to all relevant > +trees.
> +
> + Backport: 4.9+
> +
> +It marks a commit for being a candidate for backports to all stable > +trees from 4.9 onward.
> +
> +Maintainers request the Backport tag to be added on commit.
> +Contributors are also welcome to mark their patches with the Backport > +tag when they deem appropriate. Maintainers will request for it to be > +removed when that is not the case.
> +
> +Please note that the Backport tag is a **request** for backport, which > +will still need to be evaluated by the stable tree maintainers.

Quoted 1 line

The text and the idea both look good to me.

Thank you!

Quoted 3 lines

But it seems kind of balkanized to put it in its own file. Would it be better to try to make a slightly more general bit of content? Either about the backport process, or about tags in general?

Yeah, it was never meant to stay in its own separate file. I thought it would get merged into a bigger file about the whole process when it gets submitted.

Quoted 7 lines

It should be in https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F
What is currently missing is
- Release-Acked-by
- The new proposed tag

But maybe we should have a master document in tree, which defines the tags in use
And then I can refer to it from https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F

For now, would you like me to add the text to the wiki at
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F ? Or would you rather do it?

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw

On 11/11/2019, 11:03, "Stefano Stabellini" <[email protected]> wrote:

On Mon, 11 Nov 2019, Lars Kurth wrote:
> On 11/11/2019, 08:12, "George Dunlap" <[email protected]> wrote:
>
> On 11/8/19 7:09 PM, Stefano Stabellini wrote:
> > Signed-off-by: Stefano Stabellini <[email protected]>
> > CC: [email protected]
> > CC: [email protected]
> > CC: [email protected]
> > CC: [email protected]
> > CC: [email protected]
> > CC: [email protected]
> > CC: [email protected]
> > CC: [email protected]
> > ---
> > docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> > create mode 100644 docs/process/backport-tag.pandoc
> >
> > diff --git a/docs/process/backport-tag.pandoc b/docs/process/backport-tag.pandoc
> > new file mode 100644
> > index 0000000000..e570efdcc8
> > --- /dev/null
> > +++ b/docs/process/backport-tag.pandoc
> > @@ -0,0 +1,23 @@
> > +Backport Tag
> > +------------
> > +
> > +A backport tag is an optional tag in the commit message to request a
> > +given commit to be backported to the stable trees:
> > +
> > + Backport: all
> > +
> > +It marks a commit for being a candidate for backports to all relevant
> > +trees.
> > +
> > + Backport: 4.9+
> > +
> > +It marks a commit for being a candidate for backports to all stable
> > +trees from 4.9 onward.
> > +
> > +Maintainers request the Backport tag to be added on commit.
> > +Contributors are also welcome to mark their patches with the Backport
> > +tag when they deem appropriate. Maintainers will request for it to be
> > +removed when that is not the case.
> > +
> > +Please note that the Backport tag is a **request** for backport, which
> > +will still need to be evaluated by the stable tree maintainers.
>
> The text and the idea both look good to me.

Thank you!

> But it seems kind of balkanized to put it in its own file. Would it be
> better to try to make a slightly more general bit of content? Either
> about the backport process, or about tags in general?

Yeah, it was never meant to stay in its own separate file. I thought it would get merged into a bigger file about the whole process when it gets submitted.

> It should be in https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F
> What is currently missing is
> - Release-Acked-by
> - The new proposed tag
>
> But maybe we should have a master document in tree, which defines the tags in use
> And then I can refer to it from https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F

For now, would you like me to add the text to the wiki at
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#What_is_in_a_patch.3F ? Or would you rather do it?

No: I can do it. Just ping me when we are in agreement about the proposal Lars

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#7 lore raw
In reply to Stefano Stabellini

docs/process/backport-tag.pandoc line 7

Quoted 7 lines · Stefano Stabellini
docs/process/backport-tag.pandoc new file +7 -0
+Backport Tag
+------------
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the stable trees:
+
+    Backport: all

[...]

Should we describe the Fixes: tag as well? These would have a similar purpose to the backport tag, I mean it could help figure out which commit to backport to which tree.

Signature · 6 lines
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#8 lore raw

Anthony PERARD writes ("Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports"):

Quoted 3 lines

Should we describe the Fixes: tag as well? These would have a similar purpose to the backport tag, I mean it could help figure out which commit to backport to which tree.

Good point.

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#9 lore raw
Quoted 6 lines · Ian Jackson

Anthony PERARD writes ("Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports"):

Quoted 3 lines

Should we describe the Fixes: tag as well? These would have a similar purpose to the backport tag, I mean it could help figure out which commit to backport to which tree.

Good point.

Yes, good idea.

Lars, I think we are already in agreement.

You can find the description of "Fixes" here in Linux Documentation/process/submitting-patches.rst.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#10 lore raw

On 12/11/2019, 11:10, "Stefano Stabellini" <[email protected]> wrote:

On Tue, 12 Nov 2019, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [Xen-devel] [PATCH] Introduce a description of a new optional tag for Backports"):
> > Should we describe the Fixes: tag as well? These would have a similar
> > purpose to the backport tag, I mean it could help figure out which
> > commit to backport to which tree.
>
> Good point.

Yes, good idea.

Lars, I think we are already in agreement.

You can find the description of "Fixes" here in Linux Documentation/process/submitting-patches.rst.

It would be good to get Jan's ACK at least
Lars

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#11 lore raw
In reply to Stefano Stabellini

Hi,

I have noticed Wei began to use the tag today. It reminded me that I never followed-up on the patch, sorry for that.

Quoted 33 lines · Stefano Stabellini
---
  docs/process/backport-tag.pandoc | 23 +++++++++++++++++++++++
  1 file changed, 23 insertions(+)

create mode 100644 docs/process/backport-tag.pandoc

docs/process/backport-tag.pandoc new file +13 -0
new file mode 100644
index 0000000000..e570efdcc8
@@ -0,0 +1,23 @@
+Backport Tag
+------------
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the stable trees:
+
+    Backport: all
+
+It marks a commit for being a candidate for backports to all relevant
+trees.
+
+    Backport: 4.9+
+

docs/process/backport-tag.pandoc line 23

Quoted 10 lines
docs/process/backport-tag.pandoc new file +10 -0
+It marks a commit for being a candidate for backports to all stable
+trees from 4.9 onward.
+
+Maintainers request the Backport tag to be added on commit.
+Contributors are also welcome to mark their patches with the Backport
+tag when they deem appropriate. Maintainers will request for it to be
+removed when that is not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the stable tree maintainers.

This proposal look good to me. Are you planning to resend the patch with George's suggestion?

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel