Skip to contentSkip to conversation

drm/i915/gen9: Add missing 10bpc formats

PATCH In review Kishore Kadiyala 3 participants 4 messages Nov 11, 2019 – Nov 13, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gen9: Add missing 10bpc formats

Add 10bpc formats for gen9.
This patch has dependency on below patch:
https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/display/intel_sprite.c +2 -0
index d7f71fa90659..fad73ea00992 100644
@@ -2444,6 +2444,8 @@ static const u32 skl_planar_formats[] = {
 	DRM_FORMAT_ABGR8888,
 	DRM_FORMAT_XRGB2101010,
 	DRM_FORMAT_XBGR2101010,
+	DRM_FORMAT_ARGB2101010,
+	DRM_FORMAT_ABGR2101010,
 	DRM_FORMAT_XRGB16161616F,
 	DRM_FORMAT_XBGR16161616F,
 	DRM_FORMAT_YUYV,
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915/gen9: Add missing 10bpc formats

== Series Details ==

== Series Details ==

Series: drm/i915/gen9: Add missing 10bpc formats
URL : https://patchwork.freedesktop.org/series/69272/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7301 -> Patchwork_15209
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15209 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15209, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15209:

### IGT changes ###

#### Possible regressions ####

* igt@gem_ctx_switch@rcs0:
- fi-icl-dsi: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-icl-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-icl-dsi/igt@[email protected]

* igt@kms_force_connector_basic@force-connector-state:
- fi-snb-2520m: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-snb-2520m/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-snb-2520m/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_15209 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111045] / [fdo#111096])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-kbl-7500u/igt@[email protected]

#### Possible fixes ####

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u4: [FAIL][7] ([fdo#111045]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-icl-u4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-icl-u4/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][9] ([fdo#103167]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-icl-u2/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live_gt_pm:
- fi-icl-guc: [INCOMPLETE][11] ([fdo#107713]) -> [DMESG-FAIL][12] ([fdo#112205])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-icl-guc/igt@i915_selftest@live_gt_pm.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-icl-guc/igt@i915_selftest@live_gt_pm.html

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u4: [FAIL][13] ([fdo#111049]) -> [DMESG-WARN][14] ([fdo#102505])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7301/fi-icl-u4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/fi-icl-u4/igt@[email protected]

[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112205]: https://bugs.freedesktop.org/show_bug.cgi?id=112205

Participating hosts (49 -> 44)
------------------------------

Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7301 -> Patchwork_15209

CI-20190529: 20190529
CI_DRM_7301: 4e736df5c07b7f5c3060ed96ac76b7dd1da1b203 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5268: c94958b8f7caefcda72392417ae6f3a98e36a48b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15209: b39022f9b11cf626b279f26c3333406139895203 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

b39022f9b11c drm/i915/gen9: Add missing 10bpc formats

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15209/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Kishore Kadiyala
Quoted 14 lines · Kishore Kadiyala

Add 10bpc formats for gen9.
This patch has dependency on below patch:
https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
index d7f71fa90659..fad73ea00992 100644

drivers/gpu/drm/i915/display/intel_sprite.c static const u32 skl_planar_formats[] = { · line 2448

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2 -0
@@ -2444,6 +2444,8 @@ static const u32 skl_planar_formats[] = {
 	DRM_FORMAT_ABGR8888,
 	DRM_FORMAT_XRGB2101010,
 	DRM_FORMAT_XBGR2101010,
+	DRM_FORMAT_ARGB2101010,
+	DRM_FORMAT_ABGR2101010,

Nope. Alpha blending is not supported with 10bpc formats on pre-icl platforms.

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0 -0
 	DRM_FORMAT_XRGB16161616F,
 	DRM_FORMAT_XBGR16161616F,
 	DRM_FORMAT_YUYV,
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 19 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Monday, November 11, 2019 7:34 PM
To: Kadiyala, Kishore <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gen9: Add missing 10bpc formats

Quoted 9 lines · Kishore Kadiyala

Add 10bpc formats for gen9.
This patch has dependency on below patch:
https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2

---
 drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 13 lines

drivers/gpu/drm/i915/display/intel_sprite.c static const u32 skl_planar_formats[] = { · line 2448

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_sprite.c +2 -0
index d7f71fa90659..fad73ea00992 100644
@@ -2444,6 +2444,8 @@ static const u32 skl_planar_formats[] = {
 	DRM_FORMAT_ABGR8888,
 	DRM_FORMAT_XRGB2101010,
 	DRM_FORMAT_XBGR2101010,
+	DRM_FORMAT_ARGB2101010,
+	DRM_FORMAT_ABGR2101010,

Nope. Alpha blending is not supported with 10bpc formats on pre-icl platforms.

I have checked the capabilities for Gen9 and as you pointed Alpha is not supported for 10bpc formats. This patch can be dropped.

Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_sprite.c +0 -1
 	DRM_FORMAT_XRGB16161616F,
 	DRM_FORMAT_XBGR16161616F,
 	DRM_FORMAT_YUYV,
--

2.17.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx