mesh: fix sending messages to group addresses
PATCH 1/1 mesh: fix sending messages to group addresses
When sending a message to a group address (either virtual or fixed), it has to be sent OTA even if successfully enqueued to an internal model.
--- mesh/net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mesh/net.c +3 -3
@@ -3339,10 +3339,10 @@ bool mesh_net_app_send(struct mesh_net *net, bool frnd_cred, uint16_t src, szmic, seq &SEQ_ZERO_MASK , msg, msg_len); -/* If successfully enqued or delivered -* to Unicast address, we are done +/* If addressed to a unicast address and successfully enqueued, +* or delivered to one of our Unicast addresses we are done */ -if (result || src == dst || +if ((result &&IS_UNICAST (dst)) || src == dst || (dst >= net->src_addr && dst <= net->last_addr)) {/* Adjust our seq_num for "virtual" delivery */ net->seq_num += seg_max;
Signature · 1 line
2.24.0
Gix, Brian
AppliedApplied, Thanks
Quoted 24 lines · Aurelien Jarno
When sending a message to a group address (either virtual or fixed), it has to be sent OTA even if successfully enqueued to an internal model.
--- mesh/net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mesh/net.c +3
-3@@ -3339,10 +3339,10 @@ bool mesh_net_app_send(struct mesh_net *net, bool frnd_cred, uint16_t src, szmic, seq &SEQ_ZERO_MASK , msg, msg_len); -/* If successfully enqued or delivered -* to Unicast address, we are done +/* If addressed to a unicast address and successfully enqueued, +* or delivered to one of our Unicast addresses we are done */ -if (result || src == dst || +if ((result &&IS_UNICAST (dst)) || src == dst || (dst >= net->src_addr && dst <= net->last_addr)) {/* Adjust our seq_num for "virtual" delivery */ net->seq_num += seg_max;