net: add missing semicolon in net_dev_template
Subsystems (3)
PATCH 1/1 net: add missing semicolon in net_dev_template
This patch adds missing semicolon in the end of net_dev_template.
--- include/trace/events/net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/net.h +1 -1
@@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,TP_printk ("dev=%s skbaddr=%p len=%u" ,__get_str (name), __entry->skbaddr, __entry->len) -) +); DEFINE_EVENT(net_dev_template, net_dev_queue,
Signature · 1 line
2.24.0
Steven Rostedt
maintainerQuoted 13 lines · On Mon, 11 Nov 2019 22:17:53 +0800 Tony Lu <[email protected]> wrote:
This patch adds missing semicolon in the end of
net_dev_template.Fixes cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")Signed-off-by Tony Lu <[email protected]>--- include/trace/events/net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/trace/events/net.h +0
-0
include/trace/events/net.h DECLARE_EVENT_CLASS(net_dev_template, · line 141
Quoted 5 lines
include/trace/events/net.h +1
-1@@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,TP_printk ("dev=%s skbaddr=%p len=%u" ,__get_str (name), __entry->skbaddr, __entry->len) -) +);
Actually, we are thinking of making a sweeping patch set to remove all these semicolons, as they are not needed, and would also allow more flexible processing of the trace event macros.
-- Steve
Quoted 3 lines
include/trace/events/net.h +0
-0DEFINE_EVENT(net_dev_template, net_dev_queue,
Quoted 26 lines · Steven Rostedt
Quoted 13 lines · On Mon, 11 Nov 2019 22:17:53 +0800 Tony Lu <[email protected]> wrote:
This patch adds missing semicolon in the end of
net_dev_template.Fixes cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")Signed-off-by Tony Lu <[email protected]>--- include/trace/events/net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/trace/events/net.h +0
-0include/trace/events/net.h DECLARE_EVENT_CLASS(net_dev_template, · line 141
Quoted 5 lines
include/trace/events/net.h +1
-1@@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,TP_printk ("dev=%s skbaddr=%p len=%u" ,__get_str (name), __entry->skbaddr, __entry->len) -) +);Actually, we are thinking of making a sweeping patch set to remove all these semicolons, as they are not needed, and would also allow more flexible processing of the trace event macros.
Quoted 1 line
-- Steve
Thanks for your reply, it's great to take actions to sweep them for a unified code style. I just found a different place in the code :-)
Cheers
Tony Lu
Quoted 4 lines
Quoted 4 lines
include/trace/events/net.h +0
-0DEFINE_EVENT(net_dev_template, net_dev_queue,