Coverity: submit_dmub_reg_wait(): Memory - corruptions
Hello!
This is an experimental automated report about issues detected by Coverity from a scan of next-20191108 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits:
c264644545d2 ("drm/amd/display: Add DMUB support to DC")
Coverity reported the following:
*** CID 1487852: Memory - corruptions (OVERRUN) /drivers/gpu/drm/amd/display/dc/dc_helper.c: 95 in submit_dmub_reg_wait()
89 struct dmub_rb_cmd_reg_wait *cmd_buf = &offload->cmd_data.reg_wait;
90 bool gather = false;
91
92 gather = ctx->dmub_srv->reg_helper_offload.gather_in_progress;
93 ctx->dmub_srv->reg_helper_offload.gather_in_progress = false;
94
vvv CID 1487852: Memory - corruptions (OVERRUN)
vvv Overrunning struct type dmub_cmd_header of 4 bytes by passing it to a function which accesses it at byte offset 63.
95 dc_dmub_srv_cmd_queue(ctx->dmub_srv, &cmd_buf->header);
96
97 memset(cmd_buf, 0, sizeof(*cmd_buf));
98 offload->reg_seq_count = 0;
99
100 ctx->dmub_srv->reg_helper_offload.gather_in_progress = gather;
If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first):
Addresses-Coverity-ID: 1487852 ("Memory - corruptions")
Thanks for your attention!
Signature · 1 line
Coverity-bot