Skip to contentSkip to conversation

OMAP2: remove unused wakeup_cpu

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Nov 6, 2019 – Nov 11, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP2: remove unused wakeup_cpu

The wakeup_cpu variable in omap4_enter_lowpower() is set but then is not used after this. Remove it to fix the compiler warning:

arch/arm/mach-omap2/omap-mpuss-lowpower.c: In function âomap4_enter_lowpowerâ:
arch/arm/mach-omap2/omap-mpuss-lowpower.c:230:15: warning: variable âwakeup_cpuâ set but not used [-Wunused-but-set-variable]

---
Cc: Tony Lindgren <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/mach-omap2/omap-mpuss-lowpower.c +0 -2
index 2d8f90546591..67fa28532a3a 100644
@@ -227,7 +227,6 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 {
 	struct omap4_cpu_pm_info *pm_info = &per_cpu(omap4_pm_info, cpu);
 	unsigned int save_state = 0, cpu_logic_state = PWRDM_POWER_RET;
-	unsigned int wakeup_cpu;
 
 	if (omap_rev() == OMAP4430_REV_ES1_0)
 		return -ENXIO;
@@ -292,7 +291,6 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 	 * secure devices, CPUx does WFI which can result in
 	 * domain transition
 	 */
-	wakeup_cpu = smp_processor_id();
 	pwrdm_set_next_pwrst(pm_info->pwrdm, PWRDM_POWER_ON);
 
 	pwrdm_post_transition(NULL);
Signature · 7 lines
2.24.0.rc1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw

Hi,

Quoted 6 lines · Ben Dooks (Codethink)

The wakeup_cpu variable in omap4_enter_lowpower() is set but then is not used after this. Remove it to fix the compiler warning:

arch/arm/mach-omap2/omap-mpuss-lowpower.c: In function âomap4_enter_lowpowerâ:
arch/arm/mach-omap2/omap-mpuss-lowpower.c:230:15: warning: variable âwakeup_cpuâ set but not used [-Wunused-but-set-variable]

I have already queued up an earlier similar patch:

5395b5557acb ("ARM: OMAP2+: Remove unused wakeup_cpu")

Thanks,

Tony

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel