Skip to contentSkip to conversation

nfsd: v4 support requires CRYPTO_SHA256

PATCH Applied Scott Mayhew 3 participants 3 messages Nov 12, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: v4 support requires CRYPTO_SHA256

The new nfsdcld client tracking operations use sha256 to compute hashes of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.

Fixes 6ee95d1c8991 ("nfsd: add support for upcall version 2")
---
 fs/nfsd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/Kconfig +1 -1
index 10cefb0c07c7..c4b1a89b8845 100644
@@ -73,7 +73,7 @@ config NFSD_V4
 	select NFSD_V3
 	select FS_POSIX_ACL
 	select SUNRPC_GSS
-	select CRYPTO
+	select CRYPTO_SHA256
 	select GRACE_PERIOD
 	help
 	  This option enables support in your system's NFS server for
Signature · 1 line
2.17.2
#1 lore raw
Quoted 10 lines · Scott Mayhew

The new nfsdcld client tracking operations use sha256 to compute hashes of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.

Fixes 6ee95d1c8991 ("nfsd: add support for upcall version 2")

I recently noticed this too in passing. I didn't have a chance to give a thought about exactly how to address it, but this looks OK to me.

Quoted 20 lines

---
fs/nfsd/Kconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/Kconfig +1 -1
index 10cefb0c07c7..c4b1a89b8845 100644
@@ -73,7 +73,7 @@ config NFSD_V4
 	select NFSD_V3
 	select FS_POSIX_ACL
 	select SUNRPC_GSS
-	select CRYPTO
+	select CRYPTO_SHA256
 	select GRACE_PERIOD
 	help
 	  This option enables support in your system's NFS server for
Signature · 1 line
2.17.2

--
Chuck Lever

#2 lore raw
In reply to Scott Mayhew

Thanks, applied.--b.

Quoted 25 lines · Scott Mayhew

The new nfsdcld client tracking operations use sha256 to compute hashes of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.

Fixes 6ee95d1c8991 ("nfsd: add support for upcall version 2")
---
 fs/nfsd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/Kconfig +1 -1
index 10cefb0c07c7..c4b1a89b8845 100644
@@ -73,7 +73,7 @@ config NFSD_V4
 	select NFSD_V3
 	select FS_POSIX_ACL
 	select SUNRPC_GSS
-	select CRYPTO
+	select CRYPTO_SHA256
 	select GRACE_PERIOD
 	help
 	  This option enables support in your system's NFS server for
Signature · 1 line
2.17.2