meta: introduce time/day/hour matching
Florian Westphal
maintainercover meta: introduce time/day/hour matching
Hi.
This series contains the changes that I plan to apply to nftables.git soon to get the 'time' matching feature in.
First patch is unchanged, second patch has the tests removed and replaces 'day' parsing with one that is based on the symbol table infra we already have. This means 'nft describe meta day' will now print all days plus their numeric value.
Third patch contains the test cases, I've moved them to 'any' because time matching isn't ip specific.
Last match adds a patch to catch invalid days during eval step.
Ander Juaristi (3):
evaluate: New internal helper __expr_evaluate_range
meta: Introduce new conditions 'time', 'day' and 'hour'
tests: add meta time test cases
Florian Westphal (1):
src: evaluate: catch invalid 'meta day' values in eval step
doc/nft.txt | 6 doc/primary-expression.txt | 27 +++ include/datatype.h | 6 include/linux/netfilter/nf_tables.h | 6 include/meta.h | 3 include/nftables.h | 5 include/nftables/libnftables.h | 1 src/datatype.c | 3 src/evaluate.c | 91 +++++++++++- src/main.c | 12 + src/meta.c | 261 ++++++++++++++++++++++++++++++++++++ src/parser_bison.y | 9 + src/scanner.l | 1 tests/py/any/meta.t | 19 ++ tests/py/any/meta.t.json | 233 ++++++++++++++++++++++++++++++++ tests/py/any/meta.t.json.output | 234 ++++++++++++++++++++++++++++++++ tests/py/any/meta.t.payload | 77 ++++++++++ 17 files changed, 982 insertions(+), 12 deletions(-)
Florian Westphal
maintainerPATCH 1/4 evaluate: New internal helper __expr_evaluate_range
From: Ander Juaristi <[email protected]>
This is used by the followup patch to evaluate a range without emitting an error when the left value is larger than the right one.
This is done to handle time-matching such as 23:00-01:00 -- expr_evaluate_range() will reject this, but we want to be able to evaluate and then handle this as a request to match from 23:00 to 1am.
--- src/evaluate.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)
src/evaluate.c +16 -4
@@ -941,16 +941,28 @@ static int expr_evaluate_range_expr(struct eval_ctx *ctx,return 0 ; } -static int expr_evaluate_range (struct eval_ctx *ctx,struct expr **expr) +static int __expr_evaluate_range (struct eval_ctx *ctx,struct expr **expr) { -struct expr *range = *expr, *left, *right; +struct expr *range = *expr;if (expr_evaluate_range_expr (ctx, range, &range->left) <0 )return -1 ; - left = range->left; -if (expr_evaluate_range_expr (ctx, range, &range->right) <0 )return -1 ; + +return 0 ; +} + +static int expr_evaluate_range (struct eval_ctx *ctx,struct expr **expr) +{ +struct expr *range = *expr, *left, *right; +int rc; + + rc =__expr_evaluate_range (ctx, expr); +if (rc) +return rc; + + left = range->left; right = range->right;if (mpz_cmp (left->value, right->value) >=0 )
Signature · 1 line
2.21.0
Florian Westphal
maintainerPATCH 2/4 meta: Introduce new conditions 'time', 'day' and 'hour'
In reply to Florian WestphalFrom: Ander Juaristi <[email protected]>
These keywords introduce new checks for a timestamp, an absolute date (which is converted to a timestamp), an hour in the day (which is converted to the number of seconds since midnight) and a day of week.
When converting an ISO date (eg. 2019-06-06 17:00) to a timestamp, we need to substract it the GMT difference in seconds, that is, the value of the 'tm_gmtoff' field in the tm structure. This is because the kernel doesn't know about time zones. And hence the kernel manages different timestamps than those that are advertised in userspace when running, for instance, date +%s.
The same conversion needs to be done when converting hours (e.g 17:00) to seconds since midnight as well.
The result needs to be computed modulo 86400 in case GMT offset (difference in seconds from UTC) is negative.
We also introduce a new command line option (-t, --seconds) to show the actual timestamps when printing the values, rather than the ISO dates, or the hour.
Some usage examples:
time < "2019-06-06 17:00" drop; time < "2019-06-06 17:20:20" drop; time < 12341234 drop; day "Saturday" drop; day 6 drop; hour >= 17:00 drop; hour >= "17:00:01" drop; hour >= 63000 drop;
We need to convert an ISO date to a timestamp
without taking into account the time zone offset, since comparison will be done in kernel space and there is no time zone information there.
Overwriting TZ is portable, but will cause problems when parsing a ruleset that has 'time' and 'hour' rules. Parsing an 'hour' type must not do time zone conversion, but that will be automatically done if TZ has been overwritten to UTC.
Hence, we use timegm() to parse the 'time' type, even though it's not portable. Overwriting TZ seems to be a much worse solution.
Finally, be aware that timestamps are converted to nanoseconds when transferring to the kernel (as comparison is done with nanosecond precision), and back to seconds when retrieving them for printing.
We swap left and right values in a range to properly handle cross-day hour ranges (e.g. 23:15-03:22).
--- doc/nft.txt | 6 +- doc/primary-expression.txt | 27 ++- include/datatype.h | 6 + include/linux/netfilter/nf_tables.h | 6 + include/meta.h | 3 + include/nftables.h | 5 + include/nftables/libnftables.h | 1 + src/datatype.c | 3 + src/evaluate.c | 54 ++++++ src/main.c | 12 +- src/meta.c | 261 ++++++++++++++++++++++++++++ src/parser_bison.y | 9 + src/scanner.l | 1 + 13 files changed, 390 insertions(+), 4 deletions(-) mode change 100755 => 100644 src/evaluate.c
doc/nft.txt +5 -1
@@ -9,7 +9,7 @@ nft - Administration tool of the nftables framework for packet filtering and cla SYNOPSIS -------- [verse] -*nft* [ *-nNscaeSupyj* ] [ *-I* 'directory' ] [ *-f* 'filename' | *-i* | 'cmd' ...] +*nft* [ *-nNscaeSupyjt* ] [ *-I* 'directory' ] [ *-f* 'filename' | *-i* | 'cmd' ...] *nft* *-h* *nft* *-v*
@@ -93,6 +93,10 @@ For a full summary of options, run *nft --help*. Read input from an interactive readline CLI. You can use quit to exit, or use the EOF marker, normally this is CTRL-D. +*-t*:: +*--numeric-time*:: + Show time, day and hour values in numeric format. + INPUT FILE FORMATS ------------------ LEXICAL CONVENTIONS
doc/primary-expression.txt +25 -2
@@ -2,7 +2,7 @@ META EXPRESSIONS ~~~~~~~~~~~~~~~~ [verse] *meta* {*length* | *nfproto* | *l4proto* | *protocol* | *priority*} -[*meta*] {*mark* | *iif* | *iifname* | *iiftype* | *oif* | *oifname* | *oiftype* | *skuid* | *skgid* | *nftrace* | *rtclassid* | *ibrname* | *obrname* | *pkttype* | *cpu* | *iifgroup* | *oifgroup* | *cgroup* | *random* | *ipsec* | *iifkind* | *oifkind*} +[*meta*] {*mark* | *iif* | *iifname* | *iiftype* | *oif* | *oifname* | *oiftype* | *skuid* | *skgid* | *nftrace* | *rtclassid* | *ibrname* | *obrname* | *pkttype* | *cpu* | *iifgroup* | *oifgroup* | *cgroup* | *random* | *ipsec* | *iifkind* | *oifkind* | *time* | *hour* | *day* } A meta expression refers to meta data associated with a packet.
@@ -115,7 +115,16 @@ boolean (1 bit) |iifkind| Input interface kind | |oifkind| -Output interface kind +Output interface kind| +|time| +Absolute time of packet reception| +Integer (32 bit) or string +|day| +Day of week| +Integer (8 bit) or string +|hour| +Hour of day| +String |==================== .Meta expression specific types
@@ -141,6 +150,20 @@ Packet type: *host* (addressed to local host), *broadcast* (to all), *multicast* (to group), *other* (addressed to another host). |ifkind| Interface kind (16 byte string). Does not have to exist. +|time| +Either an integer or a date in ISO format. For example: "2019-06-06 17:00". +Hour and seconds are optional and can be omitted if desired. If omitted, +midnight will be assumed. +The following three would be equivalent: "2019-06-06", "2019-06-06 00:00" +and "2019-06-06 00:00:00". +When an integer is given, it is assumed to be a UNIX timestamp. +|day| +Either a day of week ("Monday", "Tuesday", etc.), or an integer between 0 and 6. +Strings are matched case-insensitively, and a full match is not expected (e.g. "Mon" would match "Monday"). +When an integer is given, 0 is Sunday and 6 is Saturday. +|hour| +A string representing an hour in 24-hour format. Seconds can optionally be specified. +For example, 17:00 and 17:00:00 would be equivalent. |============================= .Using meta expressions
include/datatype.h +6 -0
@@ -45,6 +45,9 @@* @TYPE_DSCP: Differentiated Services Code Point (integer subtype) * @TYPE_IFNAME: interface name (string subtype) * @TYPE_IGMP: IGMP type (integer subtype) +* @TYPE_TIME_DATA Date type (integer subtype) +* @TYPE_TIME_HOUR Hour type (integer subtype) +* @TYPE_TIME_DAY Day type (integer subtype) */ enum datatypes {TYPE_INVALID ,
@@ -90,6 +93,9 @@ enum datatypes {TYPE_CT_EVENTBIT ,TYPE_IFNAME ,TYPE_IGMP_TYPE , +TYPE_TIME_DATE , +TYPE_TIME_HOUR , +TYPE_TIME_DAY , __TYPE_MAX };#define TYPE_MAX (__TYPE_MAX - 1)
include/linux/netfilter/nf_tables.h +6 -0
@@ -800,6 +800,9 @@ enum nft_exthdr_attributes {* @NFT_META_OIFKIND: packet output interface kind name (dev->rtnl_link_ops->kind) * @NFT_META_BRI_IIFPVID: packet input bridge port pvid * @NFT_META_BRI_IIFVPROTO: packet input bridge vlan proto +* @NFT_META_TIME_NS: time since epoch (in nanoseconds) +* @NFT_META_TIME_DAY: day of week (from 0 = Sunday to 6 = Saturday) +* @NFT_META_TIME_HOUR: hour of day (in seconds) */ enum nft_meta_keys {NFT_META_LEN ,
@@ -832,6 +835,9 @@ enum nft_meta_keys {NFT_META_OIFKIND ,NFT_META_BRI_IIFPVID ,NFT_META_BRI_IIFVPROTO , +NFT_META_TIME_NS , +NFT_META_TIME_DAY , + NFT_META_TIME_HOUR, };/**
include/meta.h +3 -0
@@ -41,5 +41,8 @@ extern const struct datatype uid_type;extern const struct datatype devgroup_type;extern const struct datatype pkttype_type;extern const struct datatype ifname_type; +extern const struct datatype date_type; +extern const struct datatype hour_type; +extern const struct datatype day_type;#endif /* NFTABLES_META_H */
include/nftables.h +5 -0
@@ -70,6 +70,11 @@ static inline bool nft_output_guid(const struct output_ctx *octx)return octx->flags &NFT_CTX_OUTPUT_GUID ; } +static inline bool nft_output_seconds (const struct output_ctx *octx) +{ +return octx->flags &NFT_CTX_OUTPUT_NUMERIC_TIME ; +} +static inline bool nft_output_numeric_proto (const struct output_ctx *octx) {return octx->flags &NFT_CTX_OUTPUT_NUMERIC_PROTO ;
include/nftables/libnftables.h +1 -0
@@ -52,6 +52,7 @@ enum {NFT_CTX_OUTPUT_NUMERIC_PROTO = (1 <<7 ),NFT_CTX_OUTPUT_NUMERIC_PRIO = (1 <<8 ),NFT_CTX_OUTPUT_NUMERIC_SYMBOL = (1 <<9 ), +NFT_CTX_OUTPUT_NUMERIC_TIME = (1 <<10 ),NFT_CTX_OUTPUT_NUMERIC_ALL = (NFT_CTX_OUTPUT_NUMERIC_PROTO |NFT_CTX_OUTPUT_NUMERIC_PRIO | NFT_CTX_OUTPUT_NUMERIC_SYMBOL),
src/datatype.c +3 -0
@@ -71,6 +71,9 @@ static const struct datatype *datatypes[TYPE_MAX + 1] = { [TYPE_BOOLEAN] = &boolean_type, [TYPE_IFNAME] = &ifname_type, [TYPE_IGMP_TYPE] = &igmp_type_type, + [TYPE_TIME_DATE] = &date_type, + [TYPE_TIME_HOUR] = &hour_type, + [TYPE_TIME_DAY] = &day_type, };const struct datatype *datatype_lookup (enum datatypes type)
src/evaluate.c +54 -0
68 lines not on this page · raw message
src/main.c +11 -1
@@ -42,9 +42,10 @@ enum opt_vals {OPT_GUID ='u' ,OPT_NUMERIC_PRIO ='y' ,OPT_NUMERIC_PROTO ='p' , +OPT_NUMERIC_TIME ='t' , OPT_INVALID = '?', }; -#define OPTSTRING "hvcf:iI:jvnsNaeSupyp" +#define OPTSTRING "hvcf:iI:jvnsNaeSupypt"static const struct option options[] = { {
@@ -114,6 +115,10 @@ static const struct option options[] = { .name = "numeric-priority", .val = OPT_NUMERIC_PRIO, }, + { + .name = "numeric-time", + .val = OPT_NUMERIC_TIME, + }, { .name = NULL }
@@ -140,6 +145,7 @@ static void show_help(const char *name)" -S, --service Translate ports to service names as described in /etc/services.\n" " -p, --numeric-protocol Print layer 4 protocols numerically.\n" " -y, --numeric-priority Print chain priority numerically.\n" +" -t, --numeric-time Print time values numerically.\n" " -a, --handle Output rule handle.\n" " -e, --echo Echo what has been added, inserted or replaced.\n" " -I, --includepath <directory> Add <directory> to the paths searched for include files. Default is: %s\n"
@@ -229,6 +235,7 @@ int main(int argc, char * const *argv)break ;case OPT_NUMERIC : output_flags |=NFT_CTX_OUTPUT_NUMERIC_ALL ; + output_flags |=NFT_CTX_OUTPUT_NUMERIC_TIME ;break ;case OPT_STATELESS : output_flags |=NFT_CTX_OUTPUT_STATELESS ;
@@ -291,6 +298,9 @@ int main(int argc, char * const *argv)case OPT_NUMERIC_PROTO : output_flags |=NFT_CTX_OUTPUT_NUMERIC_PROTO ;break ; +case OPT_NUMERIC_TIME : + output_flags |=NFT_CTX_OUTPUT_NUMERIC_TIME ; +break ;case OPT_INVALID :exit (EXIT_FAILURE ); }
src/meta.c +261 -0
279 lines not on this page · raw message
src/parser_bison.y +9 -0
@@ -431,6 +431,7 @@ int nft_lex(void *, void *, void *); %token IIFGROUP "iifgroup" %token OIFGROUP "oifgroup" %token CGROUP "cgroup" +%token TIME "time" %token CLASSID "classid" %token NEXTHOP "nexthop"
@@ -1827,6 +1828,11 @@ data_type_atom_expr : type_identifier dtype->size, NULL); xfree($1); } + | TIME + { + $$ = constant_expr_alloc(&@1, &time_type, time_type.byteorder, + time_type.size, NULL); + } ; data_type_expr : data_type_atom_expr
@@ -4050,6 +4056,9 @@ meta_key_unqualified : MARK { $$ = NFT_META_MARK; } | OIFGROUP { $$ = NFT_META_OIFGROUP; } | CGROUP { $$ = NFT_META_CGROUP; } | IPSEC { $$ = NFT_META_SECPATH; } + | TIME { $$ = NFT_META_TIME_NS; } + | DAY { $$ = NFT_META_TIME_DAY; } + | HOUR { $$ = NFT_META_TIME_HOUR; } ; meta_stmt : META meta_key SET stmt_expr
src/scanner.l +1 -0
@@ -426,6 +426,7 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "sack3" { return SACK3; } "sack-permitted" { return SACK_PERMITTED; } "timestamp" { return TIMESTAMP; } +"time" { return TIME; } "kind" { return KIND; } "count" { return COUNT; }
Signature · 1 line
2.21.0
Florian Westphal
maintainerPATCH 3/4 tests: add meta time test cases
In reply to Florian WestphalFrom: Ander Juaristi <[email protected]>
--- tests/py/any/meta.t | 15 ++ tests/py/any/meta.t.json | 233 +++++++++++++++++++++++++++++++ tests/py/any/meta.t.json.output | 234 ++++++++++++++++++++++++++++++++ tests/py/any/meta.t.payload | 77 +++++++++++ 4 files changed, 559 insertions(+)
tests/py/any/meta.t +15 -0
@@ -203,3 +203,18 @@ meta iif . meta oif vmap { "lo" . "lo" : drop };ok;iif . oif vmap { "lo" . "lo" meta random eq 1;ok;meta random 1 meta random gt 1000000;ok;meta random > 1000000 + +meta time "1970-05-23 21:07:14" drop;ok +meta time 12341234 drop;ok;meta time "1970-05-23 21:07:14" drop +meta time "2019-06-21 17:00:00" drop;ok +meta time "2019-07-01 00:00:00" drop;ok +meta time "2019-07-01 00:01:00" drop;ok +meta time "2019-07-01 00:00:01" drop;ok +meta day "Saturday" drop;ok +meta day 6 drop;ok;meta day "Saturday" drop +meta day "Satturday" drop;fail +meta hour "17:00" drop;ok +meta hour "17:00:00" drop;ok;meta hour "17:00" drop +meta hour "17:00:01" drop;ok +meta hour "00:00" drop;ok +meta hour "00:01" drop;ok
tests/py/any/meta.t.json +233 -0
236 lines not on this page · raw message
tests/py/any/meta.t.json.output +234 -0
237 lines not on this page · raw message
tests/py/any/meta.t.payload +77 -0
80 lines not on this page · raw message
Signature · 1 line
2.21.0
Phil Sutter
reviewerRe: [PATCH nft 3/4] tests: add meta time test cases
Hi,
On Thu, Aug 29, 2019 at 04:09:03PM +0200, Florian Westphal wrote:
[...]
Quoted 4 lines
tests/py/any/meta.t.payload +0
-0
[...]
tests/py/any/meta.t.payload ip test-ip4 input · line 1102
Quoted 5 lines
tests/py/any/meta.t.payload +5
-0+# meta hour "17:00" drop +ip test-ip4 input + [ meta load hour => reg 1 ] + [ cmp eq reg 1 0x0000d2f0 ] + [ immediate reg 0 drop ]
Does this pass for you? I'm getting such warnings:
| 7: WARNING: line 3: 'add rule ip test-ip4 input meta hour "17:00" drop':
| '[ cmp eq reg 1 0x0000d2f0 ]' mismatches '[ cmp eq reg 1 0x0000e100 ]'
On my system, "17:00" consistently translates into 0xe100.
Cheers, Phil
Florian Westphal
maintainerRe: [PATCH nft 3/4] tests: add meta time test cases
Quoted 17 lines · Phil Sutter
Hi,
On Thu, Aug 29, 2019 at 04:09:03PM +0200, Florian Westphal wrote:
[...]Quoted 4 lines
tests/py/any/meta.t.payload +0
-0[...]
tests/py/any/meta.t.payload ip test-ip4 input · line 1102
Quoted 5 lines
tests/py/any/meta.t.payload +5
-0+# meta hour "17:00" drop +ip test-ip4 input + [ meta load hour => reg 1 ] + [ cmp eq reg 1 0x0000d2f0 ] + [ immediate reg 0 drop ]Does this pass for you? I'm getting such warnings:
Quoted 4 lines
| 7: WARNING: line 3: 'add rule ip test-ip4 input meta hour "17:00" drop':
| '[ cmp eq reg 10x0000d2f0]' mismatches '[ cmp eq reg 10x0000e100]'On my system, "17:00" consistently translates into
0xe100.
Argh, DST :-(
We will need to add change the test so nft-test.py runs with a fixed time zone.
Phil Sutter
reviewerRe: [PATCH nft 3/4] tests: add meta time test cases
Quoted 21 lines · Florian Westphal
Quoted 20 lines · Phil Sutter
Hi,
On Thu, Aug 29, 2019 at 04:09:03PM +0200, Florian Westphal wrote:
[...]Quoted 4 lines
tests/py/any/meta.t.payload +0
-0[...]
tests/py/any/meta.t.payload ip test-ip4 input · line 1102
Quoted 5 lines
tests/py/any/meta.t.payload +5
-0+# meta hour "17:00" drop +ip test-ip4 input + [ meta load hour => reg 1 ] + [ cmp eq reg 1 0x0000d2f0 ] + [ immediate reg 0 drop ]Does this pass for you? I'm getting such warnings:
| 7: WARNING: line 3: 'add rule ip test-ip4 input meta hour "17:00" drop':
| '[ cmp eq reg 10x0000d2f0]' mismatches '[ cmp eq reg 10x0000e100]'
Quoted 6 lines
Quoted 1 line
On my system, "17:00" consistently translates into
0xe100.Argh, DST :-(
We will need to add change the test so
nft-test.pyruns with a fixed time zone.
Isn't this thing translating to UTC before submitting to kernel? I would assume netlink debug output to be consistent between different timezones.
Cheers, Phil
Phil Sutter
reviewerRe: [PATCH nft 3/4] tests: add meta time test cases
Quoted 24 lines · Phil Sutter
Quoted 23 lines · Florian Westphal
Quoted 21 lines · Phil Sutter
Hi,
On Thu, Aug 29, 2019 at 04:09:03PM +0200, Florian Westphal wrote:
[...]Quoted 4 lines
tests/py/any/meta.t.payload +0
-0[...]
tests/py/any/meta.t.payload ip test-ip4 input · line 1102
Quoted 5 lines
tests/py/any/meta.t.payload +5
-0+# meta hour "17:00" drop +ip test-ip4 input + [ meta load hour => reg 1 ] + [ cmp eq reg 1 0x0000d2f0 ] + [ immediate reg 0 drop ]Does this pass for you? I'm getting such warnings:
| 7: WARNING: line 3: 'add rule ip test-ip4 input meta hour "17:00" drop':
| '[ cmp eq reg 10x0000d2f0]' mismatches '[ cmp eq reg 10x0000e100]'On my system, "17:00" consistently translates into
0xe100.
Quoted 8 lines
Quoted 4 lines
Argh, DST :-(
We will need to add change the test so
nft-test.pyruns with a fixed time zone.Isn't this thing translating to UTC before submitting to kernel? I would assume netlink debug output to be consistent between different timezones.
Timezones and DST obviously exceed my abilities. It just took a while for me to realize that "17:00" in DST means a different point in time than the same value in non-DST. Anyway, this seems to work:
| diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py | index ce42b5ddb1cca..1b1db7aa596f3 100755 | --- a/tests/py/nft-test.py | +++ b/tests/py/nft-test.py | @@ -24,6 +24,7 @@ import tempfile | | TESTS_PATH = os.path.dirname(os.path.abspath(__file__)) | sys.path.insert(0, os.path.join(TESTS_PATH, '../../py/')) | +os.environ['TZ'] = 'UTC-2' | | from nftables import Nftables |
Choosing UTC-2 fixes most of the warnings. Not all of them, who knows why. (Choosing the right offset was already challenging enough.)
Cheers, Phil
Florian Westphal
maintainerPATCH 4/4 src: evaluate: catch invalid 'meta day' values in eval step
In reply to Florian Westphal--- src/evaluate.c | 17 +++++++++++++---- tests/py/any/meta.t | 4 ++++ 2 files changed, 17 insertions(+), 4 deletions(-)
src/evaluate.c +13 -4
@@ -1863,11 +1863,20 @@ static int expr_evaluate_meta(struct eval_ctx *ctx, struct expr **exprp) {struct expr *meta = *exprp; -if (ctx->pctx.family !=NFPROTO_INET && - meta->flags &EXPR_F_PROTOCOL && - meta->meta.key ==NFT_META_NFPROTO ) -return expr_error (ctx->msgs, meta, +switch (meta->meta.key) { +case NFT_META_NFPROTO : +if (ctx->pctx.family !=NFPROTO_INET && + meta->flags &EXPR_F_PROTOCOL ) +return expr_error (ctx->msgs, meta,"meta nfproto is only useful in the inet family" ); +break ; +case NFT_META_TIME_DAY : +__expr_set_context (&ctx->ectx, meta->dtype, meta->byteorder, + meta->len,6 ); +return 0 ; +default : +break ; + }return expr_evaluate_primary (ctx, exprp); }
tests/py/any/meta.t +4 -0
@@ -218,3 +218,7 @@ meta hour "17:00:00" drop;ok;meta hour "17:00" drop meta hour "17:00:01" drop;ok meta hour "00:00" drop;ok meta hour "00:01" drop;ok + +meta time "meh";fail +meta hour "24:00" drop;fail +meta day 7 drop;fail
Signature · 1 line
2.21.0