drm/i915: Fix a bug calling sleep function in atomic context
Subsystems (2)
PATCH 1/1 drm/i915: Fix a bug calling sleep function in atomic context
There are quite a few reports regarding "BUG: sleeping function called from invalid context at mm/page_alloc.c"
Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic context, but compress_page cannot be called in atomic context as it will call pool_alloc with GFP_KERNEL flag which can go to sleep. This is why the bug got reported.
So, changed to non atomic version instead.
--- drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +4 -4
@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915, compress->wc =i915_gem_object_is_lmem (vma->obj) ||drm_mm_node_allocated (&ggtt->error_capture); ret = -EINVAL ;if (drm_mm_node_allocated (&ggtt->error_capture)) {void __iomem *s;dma_addr_t dma;for_each_sgt_daddr (dma, iter, vma->pages) { ggtt->vm.insert_page (&ggtt->vm, dma, slot,I915_CACHE_NONE ,0 ); s =io_mapping_map_wc (&ggtt->iomap, slot,PAGE_SIZE ); ret =compress_page (compress, (void __force *)s, dst);io_mapping_unmap (s);if (ret)break ; } }else if (i915_gem_object_is_lmem (vma->obj)) {struct intel_memory_region *mem = vma->obj->mm.region;dma_addr_t dma;for_each_sgt_daddr (dma, iter, vma->pages) {void __iomem *s; - s =io_mapping_map_atomic_wc (&mem->iomap, dma); + s =io_mapping_map_wc (&mem->iomap, dma,PAGE_SIZE ); ret =compress_page (compress, (void __force *)s, dst); -io_mapping_unmap_atomic (s); +io_mapping_unmap (s);if (ret)break ; } }else {struct page *page;for_each_sgt_page (page, iter, vma->pages) {void *s;drm_clflush_pages (&page,1 ); - s =kmap_atomic (page); + s =kmap (page); ret =compress_page (compress, s, dst); -kunmap_atomic (s); +kunmap (s);drm_clflush_pages (&page,1 );if (ret)break ; } }if (ret ||compress_flush (compress, dst)) {while (dst->page_count--)pool_free (&compress->pool, dst->pages[dst->page_count]);kfree (dst); dst =NULL ; }compress_finish (compress);return dst; }/* * Generate a semi-unique error code. The code is not meant to have meaning, The * code's only purpose is to try to prevent false duplicated bug reports by * grossly estimating a GPU error state. * * TODO Ideally, hashing the batchbuffer would be a very nice way to determine
Signature · 6 lines
2.24.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Fix a bug calling sleep function in atomic context
== Series Details ==
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context
URL : https://patchwork.freedesktop.org/series/69385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7324 -> Patchwork_15246
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
Known issues
------------
Here are the changes found in Patchwork_15246 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-hsw-peppy/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-hsw-peppy/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [DMESG-WARN][3] ([fdo#107139]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-kbl-7500u/igt@[email protected]
* igt@kms_busy@basic-flip-pipe-a:
- fi-icl-u2: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-icl-u2/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-guc: [FAIL][7] ([fdo#103167]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/fi-icl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/fi-icl-guc/igt@[email protected]
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
Participating hosts (51 -> 46)
------------------------------
Additional (1): fi-skl-6770hq
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7324 -> Patchwork_15246
CI-20190529: 20190529
CI_DRM_7324: dd07789205270dd69eca30ef7d123b5d2322d7a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5274: 1345346c97c630563aae08cc2f1276c70b90378d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15246: 87b5c93d694e0a22a5fec76927b71215475c59ec @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
87b5c93d694e drm/i915: Fix a bug calling sleep function in atomic context
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Fix a bug calling sleep function in atomic context
In reply to Bruce Chang== Series Details ==
== Series Details ==
Series: drm/i915: Fix a bug calling sleep function in atomic context
URL : https://patchwork.freedesktop.org/series/69385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7324_full -> Patchwork_15246_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15246_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@[email protected]
* igt@gem_ctx_isolation@vcs1-reset:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@[email protected]
* igt@gem_eio@suspend:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111850])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@[email protected]
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@[email protected]
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111747])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw8/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-snb4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-snb2/igt@[email protected]
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([fdo#105763] / [fdo#106538])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-glk6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-glk8/igt@[email protected]
* igt@i915_pm_rpm@universal-planes:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([fdo#105541])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103232]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@[email protected]
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-hsw: [PASS][23] -> [DMESG-WARN][24] ([fdo#102614])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-kbl4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-kbl3/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [PASS][33] -> [INCOMPLETE][34] ([fdo#104108])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl10/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl10/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#103166])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb8/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_suspend:
- shard-tglb: [PASS][39] -> [DMESG-WARN][40] ([fdo#111600])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb3/igt@kms_psr@psr2_suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb8/igt@kms_psr@psr2_suspend.html
* igt@kms_psr@suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111832] / [fdo#111850]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-kbl2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-kbl2/igt@[email protected]
- shard-tglb: [INCOMPLETE][45] ([fdo#111832]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@[email protected]
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][47] ([fdo#109276] / [fdo#112080]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][49] ([fdo#110841]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb5/igt@[email protected]
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [SKIP][51] ([fdo#112080]) -> [PASS][52] +9 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@[email protected]
* igt@gem_eio@reset-stress:
- shard-tglb: [INCOMPLETE][53] ([fdo#111867]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-blt:
- shard-tglb: [INCOMPLETE][57] ([fdo#111677]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb1/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-chain-bsd1:
- shard-tglb: [INCOMPLETE][59] ([fdo#111606] / [fdo#111677]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb1/igt@[email protected]
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb3/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][63] ([fdo#111736] / [fdo#111850]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb3/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][65] ([fdo#112037]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb3/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb3/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [DMESG-WARN][67] ([fdo#111870]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-hsw6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-hsw5/igt@[email protected]
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl10/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl10/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-size-change:
- shard-skl: [FAIL][71] ([fdo#103232]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl9/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl3/igt@[email protected]
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-skl: [DMESG-WARN][73] ([fdo#105541]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][75] ([fdo#105363]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl3/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl9/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +6 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +4 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][83] ([fdo#108145]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl4/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][85] ([fdo#108145] / [fdo#110403]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl9/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][89] ([fdo#99912]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-apl7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-apl8/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][91] ([fdo#111850]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb2/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][93] ([fdo#104108]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-skl7/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-skl4/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][95] ([fdo#109276]) -> [PASS][96] +16 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb1/igt@[email protected]
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([fdo#111329])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb7/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-iclb4/igt@[email protected]
* igt@gem_ctx_isolation@vcs2-clean:
- shard-tglb: [SKIP][99] ([fdo#111912] / [fdo#112080]) -> [SKIP][100] ([fdo#112080])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb1/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb9/igt@[email protected]
* igt@gem_ctx_isolation@vcs2-reset:
- shard-tglb: [SKIP][101] ([fdo#112080]) -> [SKIP][102] ([fdo#111912] / [fdo#112080])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb9/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@[email protected]
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][103] ([fdo#105411]) -> [DMESG-WARN][104] ([fdo# 112000 ] / [fdo#111781])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-snb7/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-snb5/igt@[email protected]
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [FAIL][105] ([fdo#111646]) -> [INCOMPLETE][106] ([fdo#111671])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-tglb8/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/shard-tglb7/igt@[email protected]
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][107] ([fdo#111330]) -> [SKIP][108] ([fdo#109276])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7324/shard-iclb4/igt@[email protected]
[1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15246/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Bruce Chang
There are quite a few reports regarding "BUG: sleeping function called from invalid context at
mm/page_alloc.c"Basically after the io_mapping_map_atomic_wc/kmap_atomic, it enters atomic context, but
compress_pagecannot be called in atomic context as it will callpool_allocwithGFP_KERNELflag which can go to sleep. This is why the bug got reported.So, changed to non atomic version instead.
The atomic functions were recently added, so seems worth a note that you are fixing that patch by adding:
And your fix here looks correct to me, so:
Quoted 73 lines
Signed-off-by Bruce Chang <[email protected]>--- drivers/gpu/drm/i915/i915_gpu_error.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_gpu_error.c +4
-4@@ -1007,67 +1007,67 @@ i915_error_object_create(struct drm_i915_private *i915, compress->wc =i915_gem_object_is_lmem (vma->obj) ||drm_mm_node_allocated (&ggtt->error_capture); ret = -EINVAL ;if (drm_mm_node_allocated (&ggtt->error_capture)) {void __iomem *s;dma_addr_t dma;for_each_sgt_daddr (dma, iter, vma->pages) { ggtt->vm.insert_page (&ggtt->vm, dma, slot,I915_CACHE_NONE ,0 ); s =io_mapping_map_wc (&ggtt->iomap, slot,PAGE_SIZE ); ret =compress_page (compress, (void __force *)s, dst);io_mapping_unmap (s);if (ret)break ; } }else if (i915_gem_object_is_lmem (vma->obj)) {struct intel_memory_region *mem = vma->obj->mm.region;dma_addr_t dma;for_each_sgt_daddr (dma, iter, vma->pages) {void __iomem *s; - s =io_mapping_map_atomic_wc (&mem->iomap, dma); + s =io_mapping_map_wc (&mem->iomap, dma,PAGE_SIZE ); ret =compress_page (compress, (void __force *)s, dst); -io_mapping_unmap_atomic (s); +io_mapping_unmap (s);if (ret)break ; } }else {struct page *page;for_each_sgt_page (page, iter, vma->pages) {void *s;drm_clflush_pages (&page,1 ); - s =kmap_atomic (page); + s =kmap (page); ret =compress_page (compress, s, dst); -kunmap_atomic (s); +kunmap (s);drm_clflush_pages (&page,1 );if (ret)break ; } }if (ret ||compress_flush (compress, dst)) {while (dst->page_count--)pool_free (&compress->pool, dst->pages[dst->page_count]);kfree (dst); dst =NULL ; }compress_finish (compress);
drivers/gpu/drm/i915/i915_gpu_error.c i915_error_object_create(struct drm_i915_private *i915, · line 1073
Quoted 10 lines
drivers/gpu/drm/i915/i915_gpu_error.c +0
-0return dst; }/* * Generate a semi-unique error code. The code is not meant to have meaning, The * code's only purpose is to try to prevent false duplicated bug reports by * grossly estimating a GPU error state. * * TODO Ideally, hashing the batchbuffer would be a very nice way to determine
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx