Skip to contentSkip to conversation

platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove

PATCH In review Chuhong Yuan 2 participants 2 messages Nov 13, 2019 – Nov 20, 2019 Chrome hardware platform support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove

The driver forgets to destroy workqueue in remove. Add the missed call to fix it.

---
 drivers/platform/chrome/cros_usbpd_logger.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/chrome/cros_usbpd_logger.c +1 -0
index 2430e8b82810..374cdd1e868a 100644
@@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
 	struct logger_data *logger = platform_get_drvdata(pd);
 
 	cancel_delayed_work_sync(&logger->log_work);
+	destroy_workqueue(logger->log_workqueue);
 
 	return 0;
 }
Signature · 1 line
2.23.0
#1 lore raw
Quoted 4 lines · Chuhong Yuan

The driver forgets to destroy workqueue in remove. Add the missed call to fix it.

Applied for 5.5

Thanks,
Enric

Quoted 17 lines
---
 drivers/platform/chrome/cros_usbpd_logger.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/chrome/cros_usbpd_logger.c +1 -0
index 2430e8b82810..374cdd1e868a 100644
@@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
 	struct logger_data *logger = platform_get_drvdata(pd);
 
 	cancel_delayed_work_sync(&logger->log_work);
+	destroy_workqueue(logger->log_workqueue);
 
 	return 0;
 }