Skip to contentSkip to conversation

fstests: common: Keep $seqres.dmesg in $RESULT_DIR

PATCH In review Qu Wenruo 3 participants 3 messages Nov 13, 2019 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 fstests: common: Keep $seqres.dmesg in $RESULT_DIR

Currently fstests will remove $seqres.dmesg if nothing wrong happened. It saves some space, but sometimes it may not provide good enough history for developers to check.
E.g. some unexpected dmesg from fs, but not serious enough to be caught by current filter.

So instead of deleting the ordinary $seqres.dmesg, just keep them, so we can archive them for later review.

---
 common/rc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
common/rc +1 -3
index b988e912..59a339a6 100644
@@ -3625,10 +3625,8 @@ _check_dmesg()
 	if [ $? -eq 0 ]; then
 		_dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
 		return 1
-	else
-		rm -f $seqres.dmesg
-		return 0
 	fi
+	return 0
 }
 
 # capture the kmemleak report
Signature · 1 line
2.23.0
#1 lore raw
Quoted 8 lines · Qu Wenruo

Currently fstests will remove $seqres.dmesg if nothing wrong happened. It saves some space, but sometimes it may not provide good enough history for developers to check.
E.g. some unexpected dmesg from fs, but not serious enough to be caught by current filter.

So instead of deleting the ordinary $seqres.dmesg, just keep them, so we can archive them for later review.

Rather than keeping the seqres dmesg for all tests why not simply extend the filter?

Quoted 23 lines
---
 common/rc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
common/rc +1 -3
index b988e912..59a339a6 100644
@@ -3625,10 +3625,8 @@ _check_dmesg()
 	if [ $? -eq 0 ]; then
 		_dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
 		return 1
-	else
-		rm -f $seqres.dmesg
-		return 0
 	fi
+	return 0
 }
 
 # capture the kmemleak report
#2 lore raw
Quoted 9 lines · Nikolay Borisov
Quoted 6 lines · Qu Wenruo

Currently fstests will remove $seqres.dmesg if nothing wrong happened. It saves some space, but sometimes it may not provide good enough history for developers to check.
E.g. some unexpected dmesg from fs, but not serious enough to be caught by current filter.

Quoted 5 lines
Quoted 2 lines

So instead of deleting the ordinary $seqres.dmesg, just keep them, so we can archive them for later review.

Rather than keeping the seqres dmesg for all tests why not simply extend the filter?

Because you never know when you need to update the filter.

I don't see any reason by not keeping the dmesg other than to save some disk space.

It would be just too annoying if some report hits you with only $seqres.out.bad but some clues like btrfs_info() is completely ignored.

Thanks,
Qu

Quoted 24 lines
Quoted 24 lines
---
 common/rc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
common/rc +1 -3
index b988e912..59a339a6 100644
@@ -3625,10 +3625,8 @@ _check_dmesg()
 	if [ $? -eq 0 ]; then
 		_dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
 		return 1
-	else
-		rm -f $seqres.dmesg
-		return 0
 	fi
+	return 0
 }
 
 # capture the kmemleak report