Skip to contentSkip to conversation

drm/bridge: anx6345: Fix compilation breakage on systems without CONFIG_OF

PATCH In review Maxime Ripard 2 participants 3 messages Nov 12, 2019 – Nov 13, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: anx6345: Fix compilation breakage on systems without CONFIG_OF

The driver assumes that the platform uses the device tree, and thus relies on some fields (of_node) being declared in some structures (drm_bridge).

This isn't true for all platforms, so make sure we can only compile the ANX6345 on platforms where DT support is selected.

Cc Torsten Duwe <[email protected]>
Fixes 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
---
 drivers/gpu/drm/bridge/analogix/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/analogix/Kconfig +1 -0
index 1425a96a28c3..e1fa7d820373 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_ANALOGIX_ANX6345
 	tristate "Analogix ANX6345 bridge"
+	depends on OF
 	select DRM_ANALOGIX_DP
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
Signature · 6 lines
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Maxime Ripard

The driver assumes that the platform uses the device tree, and thus relies on some fields (of_node) being declared in some structures (drm_bridge).

This isn't true for all platforms, so make sure we can only compile the ANX6345 on platforms where DT support is selected.

Cc Torsten Duwe <[email protected]>
Fixes 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
Quoted 23 lines
---
 drivers/gpu/drm/bridge/analogix/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/analogix/Kconfig +1 -1
index 1425a96a28c3..e1fa7d820373 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_ANALOGIX_ANX6345
        tristate "Analogix ANX6345 bridge"
+       depends on OF
        select DRM_ANALOGIX_DP
        select DRM_KMS_HELPER
        select REGMAP_I2C
--

2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
Quoted 5 lines · Daniel Vetter
Quoted 4 lines · Maxime Ripard

The driver assumes that the platform uses the device tree, and thus relies on some fields (of_node) being declared in some structures (drm_bridge).

Quoted 8 lines
Quoted 6 lines

This isn't true for all platforms, so make sure we can only compile the ANX6345 on platforms where DT support is selected.

Cc Torsten Duwe <[email protected]>
Fixes 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")

Pushed, thanks

Maxime

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel