Skip to contentSkip to conversation

s390: vfio-ap: fix some comments

PATCH In review Cornelia Huck 4 participants 5 messages Nov 13, 2019 – Apr 29, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: vfio-ap: fix some comments

The functions are called vfio_ap_irq_{en,dis}able.

---

Just some minor stuff I noted while grepping for something.

---
 drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/s390/crypto/vfio_ap_ops.c +2 -2
index 5c0f53c6dde7..f8f3f3a4e5fd 100644
@@ -182,7 +182,7 @@ struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
 }
 
 /**
- * vfio_ap_setirq: Enable Interruption for a APQN
+ * vfio_ap_irq_enable: Enable Interruption for a APQN
  *
  * @dev: the device associated with the ap_queue
  * @q:	 the vfio_ap_queue holding AQIC parameters
@@ -265,7 +265,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
  * - AP_RESPONSE_Q_NOT_AVAIL: if the queue is not available
  * - AP_RESPONSE_DECONFIGURED: if the queue is not configured
  * - AP_RESPONSE_NORMAL (0) : in case of successs
- *   Check vfio_ap_setirq() and vfio_ap_clrirq() for other possible RC.
+ *   Check vfio_ap_irq_enable() and vfio_ap_irq_disable() for other possible RC.
  * We take the matrix_dev lock to ensure serialization on queues and
  * mediated device access.
  *
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw

:) thanks,

Regards,

Pierre

Quoted 33 lines · Cornelia Huck

The functions are called vfio_ap_irq_{en,dis}able.

---

Just some minor stuff I noted while grepping for something.

---
  drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/s390/crypto/vfio_ap_ops.c +2 -2
index 5c0f53c6dde7..f8f3f3a4e5fd 100644
@@ -182,7 +182,7 @@ struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
  }
 
  /**
- * vfio_ap_setirq: Enable Interruption for a APQN
+ * vfio_ap_irq_enable: Enable Interruption for a APQN
   *
   * @dev: the device associated with the ap_queue
   * @q:	 the vfio_ap_queue holding AQIC parameters
@@ -265,7 +265,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
   * - AP_RESPONSE_Q_NOT_AVAIL: if the queue is not available
   * - AP_RESPONSE_DECONFIGURED: if the queue is not configured
   * - AP_RESPONSE_NORMAL (0) : in case of successs
- *   Check vfio_ap_setirq() and vfio_ap_clrirq() for other possible RC.
+ *   Check vfio_ap_irq_enable() and vfio_ap_irq_disable() for other possible RC.
   * We take the matrix_dev lock to ensure serialization on queues and
   * mediated device access.
   *
Signature · 2 lines
Pierre Morel
IBM Lab Boeblingen
maintainer
#3 lore raw

Ignore this, I've been having problems with synchronization of my Thunderbird email client and the upstream mailing list. I responded without looking at the date this was posted.

Quoted 5 lines · Tony Krowiak
Quoted 1 line · Pierre Morel

Check vfio_ap_setirq