Fix license incompatibility with readline
cover Fix license incompatibility with readline
Hi,
We have a number of packages where we (optionally) link with readline, even though the license of the package isn't compatible with the license of readline (GPL-3.0+), E.G. for packages licensed under GPL-2.0 only.
This series aims to fix that. I've tried to review the entire tree, and this is what I found:
atftp: ok (GPL-2.0+)
augeas: ok (LGPL-2.1+)
bash: ok (GPL-3.0+)
bind: ok (MPL-2.0)
bird: ok (GPL-2.0+)
bluez-alsa: ok (MIT)
bluez-tools: ok (GPL-2.0+)bluez5_utils: ok (GPL-2.0+)bluez_utils: ok (GPL-2.0+)
chrony: fixed (GPL-2.0)
connman: fixed (GPL-2.0/GPL-2.0+)
dropwatch: unclear, reported https://github.com/nhorman/dropwatch/issues/14
gawk: ok (GPL-3.0+)
gdbm: ok (GPL-3.0+)
gnuchess: ok (GPL-3.0+)
ipmitool: ok (BSD-3-Clause)
ipsec-tools: ok (BSD-3-Clause)
iwd: ok (GPL-3.0+)
jack1: ok (GPL-2.0+)
jack2: ok (GPL-2.0+)
kodi: fixed (GPL-2.0)
lftp: ok (GPL-3.0+)
libkrb5: ok (MIT)
libnfc: ok (LGPL-3.0+)
lldpd: ok (ISC)
lua:: ok (MIT)
lvm2: fixed (GPL-2.0)
miraclecast: ok (LGPL-2.1+)
mariadb: fixed (GPL-2.0)
neardal: fixed (GPL-2.0)
network-manager: ok (GPL-2.0+)
nftables: NOK? (GPL-2.0)
open-lldp: NOK (drop?)
openipmi: ok (GPL-2.0+)
oracle-mysql: fixed (GPL-2.0)
parted: ok (GPL-3.0+)
php: ok (PHP)
postgresql: ok (PostgreSQL)
python: ok (Python-2.0)
python3: ok (Python-2.0)
qt5base: ok (GPL-2.0+/GPL-3.0)
quagga: ok (GPL-2.0+)
ruby: ok (Ruby)
samba4: ok (GPL-3.0+)
slang: ok (GPL-2.0+)
socat: fixed (GPL-2.0)
softether: ok (Apache-2.0)
sqlcipher: ok (BSD-3-Clause)
sqlite: ok (Public domain)
udftools: ok (GPL-2.0+)
unixodbc: ok (GPL-2.0+)
util-linux: ok (GPL-2.0+)wpa_supplicant: ok (BSD-3-Clause)
xorriso: ok (GPL-3.0+)
ytree: NOK? (GPL-2.0), mail sent to upstream, no response
Linking with the older bundled copies of readline in mariadb & oracle-mysql, isn't very nice - But there is not much we can do besides packaging the old GPL-2.0+ version of readline, and that then leads to issues withe file conflicts when both readline versions are enabled.
I haven't been able to find a license exception for nftables (it does have one for openssl though), but I do see that E.G. Debian also links it against a modern readline:
https://packages.debian.org/buster/nftables
Similar for open-lldp. The upstream website seems to be down, so perhaps the package should simply be dropped?
I have mailed ytree upstream to clarify licensing, but so far without any reply.
Peter Korsgaard (11):
package/chrony: use libedit for command line editing package/connman: clarify license of client code package/dropwatch: license is GPL-2.0+ package/ipsec-tools: add license information package/kodi: drop readline dependency package/kodi: add hash for license file package/lvm2: drop optional readline dependency package/mariadb: use bundled GPL-2.0+ libreadline package/neardal: unconditionally use libedit package/oracle-mysql: use bundled GPL-2.0+ libreadline package/socat: drop optional readline dependency
package/chrony/chrony.mk | 7 ++++--- package/connman/connman.mk | 1 + package/dropwatch/dropwatch.mk | 2 +- package/ipsec-tools/ipsec-tools.hash | 3 +++ package/ipsec-tools/ipsec-tools.mk | 2 ++ package/kodi/Config.in | 2 -- package/kodi/kodi.hash | 2 ++ package/kodi/kodi.mk | 1 - package/lvm2/lvm2.mk | 7 +------ package/mariadb/mariadb.mk | 6 ++++-- package/mysql/Config.in | 2 -- package/neardal/Config.in | 2 +- package/neardal/neardal.mk | 10 +--------- package/oracle-mysql/oracle-mysql.mk | 4 ++-- package/socat/socat.mk | 8 ++------ 15 files changed, 24 insertions(+), 35 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/11 package/chrony: use libedit for command line editing
chrony is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so remove the optional readline handling and replace with libedit instead.
While we are at it, also explicitly disable the libedit backend when not available.
--- package/chrony/chrony.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
package/chrony/chrony.mk +4 -3
@@ -13,6 +13,7 @@ CHRONY_CONF_OPTS = \ --host-system=Linux \ --host-machine=$(BR2_ARCH) \ --prefix=/usr \ + --without-readline \ --without-tomcrypt \ $(if $(BR2_PACKAGE_CHRONY_DEBUG_LOGGING),--enable-debug,--disable-debug)
@@ -35,10 +36,10 @@ else CHRONY_CONF_OPTS += --without-seccomp endif -ifeq ($(BR2_PACKAGE_READLINE),y) -CHRONY_DEPENDENCIES += readline +ifeq ($(BR2_PACKAGE_LIBEDIT),y) +CHRONY_DEPENDENCIES += libedit else -CHRONY_CONF_OPTS += --disable-readline +CHRONY_CONF_OPTS += --without-editline --disable-readline endif # If pps-tools is available, build it before so the package can use it
Signature · 1 line
2.20.1
PATCH 1/11 package/chrony: use libedit for command line editing
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 17 lines
chrony is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so remove the optional readline handling and replace with libedit instead.
While we are at it, also explicitly disable the libedit backend when not available.
Signed-off-by Peter Korsgaard <[email protected]>--- package/chrony/chrony.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)package/chrony/chrony.mk +0
-0
package/chrony/chrony.mk CHRONY_CONF_OPTS = \ · line 16
Quoted 4 lines
package/chrony/chrony.mk +1
-0@@ -13,6 +13,7 @@ CHRONY_CONF_OPTS = \ --host-system=Linux \ --host-machine=$(BR2_ARCH) \ --prefix=/usr \ + --without-readline \
Why is this --without-readline needed here...
Quoted 4 lines
package/chrony/chrony.mk +0
-0--without-tomcrypt \ $(if $(BR2_PACKAGE_CHRONY_DEBUG_LOGGING),--enable-debug,--disable-debug)
package/chrony/chrony.mk else · line 42
Quoted 10 lines
package/chrony/chrony.mk +3
-3@@ -35,10 +36,10 @@ else CHRONY_CONF_OPTS += --without-seccomp endif -ifeq ($(BR2_PACKAGE_READLINE),y) -CHRONY_DEPENDENCIES += readline +ifeq ($(BR2_PACKAGE_LIBEDIT),y) +CHRONY_DEPENDENCIES += libedit else -CHRONY_CONF_OPTS += --disable-readline +CHRONY_CONF_OPTS += --without-editline --disable-readline
... with this other --disable-readline here?
Regards,
Yann E. MORIN.
Quoted 10 lines
package/chrony/chrony.mk +0
-0endif # If pps-tools is available, build it before so the package can use itSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/11 package/chrony: use libedit for command line editing
Quoted 35 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:Quoted 17 lines
chrony is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so remove the optional readline handling and replace with libedit instead.
While we are at it, also explicitly disable the libedit backend when not available.
Signed-off-by Peter Korsgaard <[email protected]>---
package/chrony/chrony.mk| 7 ++++---1 file changed, 4 insertions(+), 3 deletions(-)package/chrony/chrony.mk +0
-0package/chrony/chrony.mk CHRONY_CONF_OPTS = \ · line 13
Quoted 4 lines
package/chrony/chrony.mk +1
-3@@ -13,6 +13,7 @@ CHRONY_CONF_OPTS = \ --host-system=Linux \ --host-machine=$(BR2_ARCH) \ --prefix=/usr \ + --without-readline \Why is this --without-readline needed here...
Quoted 7 lines
package/chrony/chrony.mk +0
-1--without-tomcrypt \ $(if $(BR2_PACKAGE_CHRONY_DEBUG_LOGGING),--enable-debug,--disable-debug)@@ -35,10 +36,10 @@ else
CHRONY_CONF_OPTS+= --without-seccomp
endif
Quoted 9 lines
package/chrony/chrony.mk else · line 42
Quoted 7 lines
package/chrony/chrony.mk +2
-2-ifeq ($(BR2_PACKAGE_READLINE),y) -CHRONY_DEPENDENCIES += readline +ifeq ($(BR2_PACKAGE_LIBEDIT),y) +CHRONY_DEPENDENCIES += libeditelse
package/chrony/chrony.mk +1
-1-CHRONY_CONF_OPTS += --disable-readline +CHRONY_CONF_OPTS += --without-editline --disable-readline... with this other --disable-readline here?
Because they do two different things (chrony uses a hand written configure script):
--disable-readline Disable line editing support --without-readline Don't use GNU readline even if it is available --without-editline Don't use editline even if it is available
Signature · 1 line
Bye, Peter Korsgaard
Yann E. MORIN
AppliedPATCH 1/11 package/chrony: use libedit for command line editing
In reply to Peter KorsgaardPeter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 8 lines
chrony is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so remove the optional readline handling and replace with libedit instead.
While we are at it, also explicitly disable the libedit backend when not available.
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 37 lines
--- package/chrony/chrony.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)package/chrony/chrony.mk +4
-3@@ -13,6 +13,7 @@ CHRONY_CONF_OPTS = \ --host-system=Linux \ --host-machine=$(BR2_ARCH) \ --prefix=/usr \ + --without-readline \ --without-tomcrypt \ $(if $(BR2_PACKAGE_CHRONY_DEBUG_LOGGING),--enable-debug,--disable-debug)@@ -35,10 +36,10 @@ else CHRONY_CONF_OPTS += --without-seccomp endif -ifeq ($(BR2_PACKAGE_READLINE),y) -CHRONY_DEPENDENCIES += readline +ifeq ($(BR2_PACKAGE_LIBEDIT),y) +CHRONY_DEPENDENCIES += libedit else -CHRONY_CONF_OPTS += --disable-readline +CHRONY_CONF_OPTS += --without-editline --disable-readline endif # If pps-tools is available, build it before so the package can use itSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/11 package/chrony: use libedit for command line editing
In reply to Peter KorsgaardQuoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
chrony is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so remove the optional readline handling and replace with libedit instead.
While we are at it, also explicitly disable the libedit backend when not available.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/11 package/connman: clarify license of client code
In reply to Peter KorsgaardWhile the core connman code is licensed under GPL-2.0, the client code is GPL-2.0+ for compatibility with readline (which is GPL-3.0+).
Extend the _LICENSE with this info to clarify that linking against readline is OK licensing wise.
--- package/connman/connman.mk | 1 + 1 file changed, 1 insertion(+)
package/connman/connman.mk +1 -0
@@ -39,6 +39,7 @@ define CONNMAN_INSTALL_INIT_SYSTEMD endef ifeq ($(BR2_PACKAGE_CONNMAN_CLIENT),y) +CONNMAN_LICENSE += , GPL-2.0+ (client) CONNMAN_CONF_OPTS += --enable-client CONNMAN_DEPENDENCIES += readline
Signature · 1 line
2.20.1
Yann E. MORIN
AppliedPATCH 2/11 package/connman: clarify license of client code
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 7 lines
While the core connman code is licensed under GPL-2.0, the client code is GPL-2.0+ for compatibility with readline (which is GPL-3.0+).
Extend the
_LICENSEwith this info to clarify that linking against readline is OK licensing wise.Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
It's a pity they do not have a license file for it, though...
Regards,
Yann E. MORIN.
Quoted 23 lines
--- package/connman/connman.mk | 1 + 1 file changed, 1 insertion(+)package/connman/connman.mk +1
-0@@ -39,6 +39,7 @@ define CONNMAN_INSTALL_INIT_SYSTEMD endef ifeq ($(BR2_PACKAGE_CONNMAN_CLIENT),y) +CONNMAN_LICENSE += , GPL-2.0+ (client) CONNMAN_CONF_OPTS += --enable-client CONNMAN_DEPENDENCIES += readlineSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 2/11 package/connman: clarify license of client code
Quoted 6 lines · Yann E. MORIN
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 3 lines
While the core connman code is licensed under GPL-2.0, the client code is GPL-2.0+ for compatibility with readline (which is GPL-3.0+).
Quoted 8 lines
Quoted 4 lines
Extend the
_LICENSEwith this info to clarify that linking against readline is OK licensing wise.Signed-off-by Peter Korsgaard <[email protected]>Applied to master, thanks.
It's a pity they do not have a license file for it, though...
The license file would be identical, because the GPL license files don't
include the "or later" clause - that is only in the source files, and possibly in a README or similar.
Regards,
Arnout
Quoted 28 lines
Regards,
Yann E. MORIN.Quoted 23 lines
--- package/connman/connman.mk | 1 + 1 file changed, 1 insertion(+)package/connman/connman.mk +1
-0@@ -39,6 +39,7 @@ define CONNMAN_INSTALL_INIT_SYSTEMD endef ifeq ($(BR2_PACKAGE_CONNMAN_CLIENT),y) +CONNMAN_LICENSE += , GPL-2.0+ (client) CONNMAN_CONF_OPTS += --enable-client CONNMAN_DEPENDENCIES += readlineSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 2/11 package/connman: clarify license of client code
In reply to Peter KorsgaardQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
While the core connman code is licensed under GPL-2.0, the client code is GPL-2.0+ for compatibility with readline (which is GPL-3.0+).
Extend the
_LICENSEwith this info to clarify that linking against readline is OK licensing wise.Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 3/11 package/dropwatch: license is GPL-2.0+
In reply to Peter KorsgaardDropwatch links with readline, which is GPL-3.0+, so not compatible with GPL-2.0. When asked about this, upstream has clarified that the license really is GPL-2.0+:
https://github.com/nhorman/dropwatch/issues/14
--- package/dropwatch/dropwatch.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/dropwatch/dropwatch.mk +1 -1
@@ -7,7 +7,7 @@ DROPWATCH_VERSION = 1.5.1 DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION)) DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES) -DROPWATCH_LICENSE = GPL-2.0 +DROPWATCH_LICENSE = GPL-2.0+ DROPWATCH_LICENSE_FILES = COPYING # From git DROPWATCH_AUTORECONF = YES
Signature · 1 line
2.20.1
PATCH 3/11 package/dropwatch: license is GPL-2.0+
Hi Peter,
Quoted 16 lines · Peter Korsgaard
Dropwatch links with readline, which is GPL-3.0+, so not compatible with GPL-2.0. When asked about this, upstream has clarified that the license really is GPL-2.0+:
https://github.com/nhorman/dropwatch/issues/14
Signed-off-by Peter Korsgaard <[email protected]>--- package/dropwatch/dropwatch.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/dropwatch/dropwatch.mk +0
-0
package/dropwatch/dropwatch.mk line 10
Quoted 5 lines
package/dropwatch/dropwatch.mk +1
-1@@ -7,7 +7,7 @@ DROPWATCH_VERSION = 1.5.1 DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION)) DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES) -DROPWATCH_LICENSE = GPL-2.0 +DROPWATCH_LICENSE = GPL-2.0+
Maybe add a link to upstream license clarification in a comment?
baruch
Quoted 3 lines
package/dropwatch/dropwatch.mk +0
-0DROPWATCH_LICENSE_FILES = COPYING # From git DROPWATCH_AUTORECONF = YES
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 3/11 package/dropwatch: license is GPL-2.0+
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
Hi Peter,
Quoted 11 lines · Peter Korsgaard
Dropwatch links with readline, which is GPL-3.0+, so not compatible with GPL-2.0. When asked about this, upstream has clarified that the license really is GPL-2.0+:
https://github.com/nhorman/dropwatch/issues/14
Signed-off-by Peter Korsgaard <[email protected]>---
package/dropwatch/dropwatch.mk| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
package/dropwatch/dropwatch.mk line 10
Quoted 10 lines
package/dropwatch/dropwatch.mk +0
-0@@ -7,7 +7,7 @@
DROPWATCH_VERSION= 1.5.1DROPWATCH_SITE= $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION))DROPWATCH_DEPENDENCIES= libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES)package/dropwatch/dropwatch.mk +1
-1-DROPWATCH_LICENSE = GPL-2.0 +DROPWATCH_LICENSE = GPL-2.0+Maybe add a link to upstream license clarification in a comment?
True, lets do that when committing. Upstream has not actually made any changes to the repo yet though.
Signature · 1 line
Bye, Peter Korsgaard
Yann E. MORIN
AppliedPATCH 3/11 package/dropwatch: license is GPL-2.0+
In reply to Peter KorsgaardPeter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 7 lines
Dropwatch links with readline, which is GPL-3.0+, so not compatible with GPL-2.0. When asked about this, upstream has clarified that the license really is GPL-2.0+:
https://github.com/nhorman/dropwatch/issues/14
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, after adding a comment as suggested by Baruch, thanks.
Regards,
Yann E. MORIN.
Quoted 24 lines
--- package/dropwatch/dropwatch.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/dropwatch/dropwatch.mk +1
-1@@ -7,7 +7,7 @@ DROPWATCH_VERSION = 1.5.1 DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION)) DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES) -DROPWATCH_LICENSE = GPL-2.0 +DROPWATCH_LICENSE = GPL-2.0+ DROPWATCH_LICENSE_FILES = COPYING # From git DROPWATCH_AUTORECONF = YESSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 3/11 package/dropwatch: license is GPL-2.0+
In reply to Peter KorsgaardQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Dropwatch links with readline, which is GPL-3.0+, so not compatible with GPL-2.0. When asked about this, upstream has clarified that the license really is GPL-2.0+:
https://github.com/nhorman/dropwatch/issues/14
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.08.x, thanks. 2019.02.x uses a different version, I will try to get some feedback from upstream if GPL-2.0+ also applies there.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 4/11 package/ipsec-tools: add license information
In reply to Peter KorsgaardThe tarball unfortunately does not include a dedicated license file, so instead use the main source file for the setkey command.
--- package/ipsec-tools/ipsec-tools.hash | 3 +++ package/ipsec-tools/ipsec-tools.mk | 2 ++ 2 files changed, 5 insertions(+)
package/ipsec-tools/ipsec-tools.hash +3 -0
@@ -1,3 +1,6 @@ # From http://sourceforge.net/projects/ipsec-tools/files/ipsec-tools/0.8.2/ md5 d53ec14a0a3ece64e09e5e34b3350b41 ipsec-tools-0.8.2.tar.bz2 sha1 7d92cae9fde59fb4f125636698c43b0a3df3d0f0 ipsec-tools-0.8.2.tar.bz2 + +# Locally calculated +sha256 3f4af4aef0b2599928bee9875935b8fad8449ddbb98ea7da74c20c3dff5cdef7 src/setkey/setkey.c
package/ipsec-tools/ipsec-tools.mk +2 -0
@@ -7,6 +7,8 @@ IPSEC_TOOLS_VERSION = 0.8.2 IPSEC_TOOLS_SOURCE = ipsec-tools-$(IPSEC_TOOLS_VERSION).tar.bz2 IPSEC_TOOLS_SITE = http://sourceforge.net/projects/ipsec-tools/files/ipsec-tools/$(IPSEC_TOOLS_VERSION) +IPSEC_TOOLS_LICENSE = BSD-3-Clause +IPSEC_TOOLS_LICENSE_FILES = src/setkey/setkey.c IPSEC_TOOLS_INSTALL_STAGING = YES IPSEC_TOOLS_MAKE = $(MAKE1) IPSEC_TOOLS_DEPENDENCIES = openssl flex host-pkgconf host-flex host-bison
Signature · 1 line
2.20.1
Yann E. MORIN
AppliedPATCH 4/11 package/ipsec-tools: add license information
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 4 lines
The tarball unfortunately does not include a dedicated license file, so instead use the main source file for the setkey command.
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 36 lines
--- package/ipsec-tools/ipsec-tools.hash | 3 +++ package/ipsec-tools/ipsec-tools.mk | 2 ++ 2 files changed, 5 insertions(+)package/ipsec-tools/ipsec-tools.hash +3
-0@@ -1,3 +1,6 @@ # From http://sourceforge.net/projects/ipsec-tools/files/ipsec-tools/0.8.2/ md5 d53ec14a0a3ece64e09e5e34b3350b41 ipsec-tools-0.8.2.tar.bz2 sha1 7d92cae9fde59fb4f125636698c43b0a3df3d0f0 ipsec-tools-0.8.2.tar.bz2 + +# Locally calculated +sha256 3f4af4aef0b2599928bee9875935b8fad8449ddbb98ea7da74c20c3dff5cdef7 src/setkey/setkey.cpackage/ipsec-tools/ipsec-tools.mk +2
-0@@ -7,6 +7,8 @@ IPSEC_TOOLS_VERSION = 0.8.2 IPSEC_TOOLS_SOURCE = ipsec-tools-$(IPSEC_TOOLS_VERSION).tar.bz2 IPSEC_TOOLS_SITE = http://sourceforge.net/projects/ipsec-tools/files/ipsec-tools/$(IPSEC_TOOLS_VERSION) +IPSEC_TOOLS_LICENSE = BSD-3-Clause +IPSEC_TOOLS_LICENSE_FILES = src/setkey/setkey.c IPSEC_TOOLS_INSTALL_STAGING = YES IPSEC_TOOLS_MAKE = $(MAKE1) IPSEC_TOOLS_DEPENDENCIES = openssl flex host-pkgconf host-flex host-bisonSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 4/11 package/ipsec-tools: add license information
In reply to Peter KorsgaardQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
The tarball unfortunately does not include a dedicated license file, so instead use the main source file for the setkey command.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 5/11 package/kodi: drop readline dependency
In reply to Peter Korsgaard{python-,}readline is (no longer) a required dependency of kodi, and readline (GPL-3.0+) is not license compatible with kodi (GPL-2.0), so drop the dependency.
--- package/kodi/Config.in | 2 -- package/kodi/kodi.mk | 1 - 2 files changed, 3 deletions(-)
package/kodi/Config.in +0 -2
@@ -72,12 +72,10 @@ menuconfig BR2_PACKAGE_KODI select BR2_PACKAGE_PYTHON_BZIP2 select BR2_PACKAGE_PYTHON_CURSES select BR2_PACKAGE_PYTHON_PYEXPAT - select BR2_PACKAGE_PYTHON_READLINE select BR2_PACKAGE_PYTHON_SQLITE select BR2_PACKAGE_PYTHON_SSL select BR2_PACKAGE_PYTHON_UNICODEDATA select BR2_PACKAGE_PYTHON_ZLIB - select BR2_PACKAGE_READLINE select BR2_PACKAGE_SQLITE select BR2_PACKAGE_TAGLIB select BR2_PACKAGE_TINYXML
package/kodi/kodi.mk +0 -1
@@ -38,7 +38,6 @@ KODI_DEPENDENCIES = \ openssl \ pcre \ python \ - readline \ sqlite \ taglib \ tinyxml \
Signature · 1 line
2.20.1
PATCH 5/11 package/kodi: drop readline dependency
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 6 lines
{python-,}readline is (no longer) a required dependency of kodi, and readline (GPL-3.0+) is not license compatible with kodi (GPL-2.0), so drop the dependency.
Signed-off-by Peter Korsgaard <[email protected]>---
[--SNIP--]
package/kodi/kodi.mk KODI_DEPENDENCIES = \ · line 41
Quoted 9 lines
package/kodi/kodi.mk +0
-1@@ -38,7 +38,6 @@ KODI_DEPENDENCIES = \ openssl \ pcre \ python \ - readline \
What does actually prevent kodi from linking with readline, is that happens to be built before?
I'll kick-start a build here (without your patch) and see what goes linked with readline, if anything.
In the meantime, I've pondered applying this patch anyway, because it removes the explicit dependency, so that if kodi still links to readline, that would be an accident due to another intermediate dependency, and thus not our fault. But I am not too happy either, so I refrained eventually...
Regards,
Yann E. MORIN.
Quoted 10 lines
package/kodi/kodi.mk +0
-0sqlite \ taglib \ tinyxml \Signature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 5/11 package/kodi: drop readline dependency
On 2019-11-13 22:26 +0100, Yann E. MORIN spake thusly:
Quoted 8 lines
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 6 lines
{python-,}readline is (no longer) a required dependency of kodi, and readline (GPL-3.0+) is not license compatible with kodi (GPL-2.0), so drop the dependency.
Signed-off-by Peter Korsgaard <[email protected]>---
[--SNIP--]
Quoted 12 lines
package/kodi/kodi.mk KODI_DEPENDENCIES = \ · line 41
Quoted 9 lines
package/kodi/kodi.mk +0
-1@@ -38,7 +38,6 @@ KODI_DEPENDENCIES = \ openssl \ pcre \ python \ - readline \What does actually prevent kodi from linking with readline, is that happens to be built before?
So, it happens that with the Kodi version we have, 17.6-Krypton, nothing in Kodi actually links with readline:
$ grep -r libreadline.so.8 output/target
Binary file target/usr/lib/python2.7/lib-dynload/readline.so matches
Binary file target/usr/lib/libreadline.so.8.0 matches
Binary file target/usr/bin/sqlite3 matchesKodi itself is linked to libpython2.7.so.1.0, but does not seem to actually import the readline module at runtime (as far as I could see).
So: applied to master, thanks.
When we bump kodi to 18.x-Leia, any remaining problem will resolve by itself as Kodi is now GPL-2.0-or-later.
Regards,
Yann E. MORIN.
Quoted 34 lines
I'll kick-start a build here (without your patch) and see what goes linked with readline, if anything.
In the meantime, I've pondered applying this patch anyway, because it removes the explicit dependency, so that if kodi still links to readline, that would be an accident due to another intermediate dependency, and thus not our fault. But I am not too happy either, so I refrained eventually...
Regards,
Yann E. MORIN.Quoted 10 lines
package/kodi/kodi.mk +0
-0sqlite \ taglib \ tinyxml \Signature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildrootSignature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 5/11 package/kodi: drop readline dependency
In reply to Peter KorsgaardAm Wed, 13 Nov 2019 16:17:18 +0100 schrieb Peter Korsgaard:
Quoted 2 lines
{python-,}readline is (no longer) a required dependency of kodi, and readline (GPL-3.0+) is not license compatible with kodi (GPL-2.0), so
drop
Quoted 1 line
the dependency.
Hi,
readline is an optional dependency of cpluff as of Kodi 18.x:
https://github.com/xbmc/xbmc/blob/Leia/lib/cpluff/configure.ac#L210
Snippet of kodi build log:
configure: C-Pluff configuration
configure: release version: 0.1.3
configure: multi-threading support: yes (Posix)
configure: dlopening mechanism: dlopen
configure: localization support: no
configure: use GNU readline library: no
configure: assertion checks for debugging: no
configure: file name separator character: '/'
In the next kodi release cpluff will not be present anymore:
https://github.com/xbmc/xbmc/commit/b4f4ada89714538b98173dd7304b653d6e1eab31
The upstream PR which removed cpluff describes the usage of cpluff:
"cpluff was designed to run a complete addon management. This includes not only loading the addon data, but also using and running these addons.
Kodi has only used the loading of addon.xml."
So I think kodi does not need readline at all.
Regards, Bernd
PATCH 5/11 package/kodi: drop readline dependency
In reply to Peter KorsgaardQuoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
{python-,}readline is (no longer) a required dependency of kodi, and readline (GPL-3.0+) is not license compatible with kodi (GPL-2.0), so drop the dependency.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 6/11 package/kodi: add hash for license file
In reply to Peter Korsgaard--- package/kodi/kodi.hash | 2 ++ 1 file changed, 2 insertions(+)
package/kodi/kodi.hash +2 -0
@@ -8,3 +8,5 @@ sha256 b6eb2d929ff56cb051152c32010afc5e7cf5fe8c5ae32dca412a2b46b6b57e34 2f12236 sha256 312b3d15bc448d24e92f4b2e7248409525eccc4e75776026d805478e51c5ef3d 981488f.tar.gz # Locally computed - libdvdread sha256 e7179b2054163652596a56301c9f025515cb08c6d6310b42b897c3ad11c0199b 17d99db.tar.gz +# Locally computed +sha256 89931c1fb1f3716694175763cf3221cfcd63d6935031cf6b4512d17ffe5d9860 LICENSE.GPL
Signature · 1 line
2.20.1
Yann E. MORIN
AppliedPATCH 6/11 package/kodi: add hash for license file
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 1 line
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 21 lines
--- package/kodi/kodi.hash | 2 ++ 1 file changed, 2 insertions(+)package/kodi/kodi.hash +2
-0@@ -8,3 +8,5 @@ sha256 b6eb2d929ff56cb051152c32010afc5e7cf5fe8c5ae32dca412a2b46b6b57e34 2f12236 sha256 312b3d15bc448d24e92f4b2e7248409525eccc4e75776026d805478e51c5ef3d 981488f.tar.gz # Locally computed - libdvdread sha256 e7179b2054163652596a56301c9f025515cb08c6d6310b42b897c3ad11c0199b 17d99db.tar.gz +# Locally computed +sha256 89931c1fb1f3716694175763cf3221cfcd63d6935031cf6b4512d17ffe5d9860 LICENSE.GPLSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 6/11 package/kodi: add hash for license file
In reply to Peter KorsgaardQuoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 7/11 package/lvm2: drop optional readline dependency
In reply to Peter Korsgaardlvm2 is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
Notice: The readline support is only used when the raw lvm tool is called without arguments.
--- package/lvm2/lvm2.mk | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
package/lvm2/lvm2.mk +1 -6
@@ -28,13 +28,8 @@ LVM2_DEPENDENCIES += host-pkgconf libaio # take into account the toolchain passed at configure time. LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS) -ifeq ($(BR2_PACKAGE_READLINE),y) -LVM2_DEPENDENCIES += readline -else -# v2.02.44: disable readline usage, or binaries are linked against provider -# of "tgetent" (=> ncurses) even if it's not used.. +# package/readline is GPL-3.0+, so not license compatible LVM2_CONF_OPTS += --disable-readline -endif ifeq ($(BR2_PACKAGE_LIBSELINUX),y) LVM2_CONF_OPTS += --enable-selinux
Signature · 1 line
2.20.1
Yann E. MORIN
AppliedPATCH 7/11 package/lvm2: drop optional readline dependency
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 8 lines
lvm2 is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
Notice: The readline support is only used when the raw lvm tool is called without arguments.
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 30 lines
--- package/lvm2/lvm2.mk | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)package/lvm2/lvm2.mk +1
-6@@ -28,13 +28,8 @@ LVM2_DEPENDENCIES += host-pkgconf libaio # take into account the toolchain passed at configure time. LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS) -ifeq ($(BR2_PACKAGE_READLINE),y) -LVM2_DEPENDENCIES += readline -else -# v2.02.44: disable readline usage, or binaries are linked against provider -# of "tgetent" (=> ncurses) even if it's not used.. +# package/readline is GPL-3.0+, so not license compatible LVM2_CONF_OPTS += --disable-readline -endif ifeq ($(BR2_PACKAGE_LIBSELINUX),y) LVM2_CONF_OPTS += --enable-selinuxSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 7/11 package/lvm2: drop optional readline dependency
In reply to Peter KorsgaardQuoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
lvm2 is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
Notice: The readline support is only used when the raw lvm tool is called without arguments.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 8/11 package/mariadb: use bundled GPL-2.0+ libreadline
In reply to Peter Korsgaardmariadb is licensed under GPL-2.0, which is not license compatible with modern readline (GPL-3.0+), so instead use the bundled older version (GPL-2.0+ licensed) of readline instead.
--- package/mariadb/mariadb.mk | 6 ++++-- package/mysql/Config.in | 1 - 2 files changed, 4 insertions(+), 3 deletions(-)
package/mariadb/mariadb.mk +4 -2
@@ -19,8 +19,10 @@ MARIADB_DEPENDENCIES = \ openssl \ zlib \ libaio \ - libxml2 \ - readline + libxml2 + +# use bundled GPL-2.0+ licensed readline as package/readline is GPL-3.0+ +MARIADB_CONF_OPTS += -DWITH_READLINE=ON # We won't need unit tests MARIADB_CONF_OPTS += -DWITH_UNIT_TESTS=0
package/mysql/Config.in +0 -1
@@ -22,7 +22,6 @@ config BR2_PACKAGE_MARIADB select BR2_PACKAGE_LIBXML2 select BR2_PACKAGE_NCURSES select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_READLINE select BR2_PACKAGE_HAS_MYSQL help MariaDB is one of the most popular database servers in the
Signature · 1 line
2.20.1
Yann E. MORIN
AppliedPATCH 8/11 package/mariadb: use bundled GPL-2.0+ libreadline
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 5 lines
mariadb is licensed under GPL-2.0, which is not license compatible with modern readline (GPL-3.0+), so instead use the bundled older version (GPL-2.0+ licensed) of readline instead.
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 41 lines
--- package/mariadb/mariadb.mk | 6 ++++-- package/mysql/Config.in | 1 - 2 files changed, 4 insertions(+), 3 deletions(-)package/mariadb/mariadb.mk +4
-2@@ -19,8 +19,10 @@ MARIADB_DEPENDENCIES = \ openssl \ zlib \ libaio \ - libxml2 \ - readline + libxml2 + +# use bundled GPL-2.0+ licensed readline as package/readline is GPL-3.0+ +MARIADB_CONF_OPTS += -DWITH_READLINE=ON # We won't need unit tests MARIADB_CONF_OPTS += -DWITH_UNIT_TESTS=0package/mysql/Config.in +0
-1@@ -22,7 +22,6 @@ config BR2_PACKAGE_MARIADB select BR2_PACKAGE_LIBXML2 select BR2_PACKAGE_NCURSES select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_READLINE select BR2_PACKAGE_HAS_MYSQL help MariaDB is one of the most popular database servers in theSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 8/11 package/mariadb: use bundled GPL-2.0+ libreadline
In reply to Peter KorsgaardQuoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
mariadb is licensed under GPL-2.0, which is not license compatible with modern readline (GPL-3.0+), so instead use the bundled older version (GPL-2.0+ licensed) of readline instead.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 9/11 package/neardal: unconditionally use libedit
In reply to Peter Korsgaardneardal is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so always use the libedit backend.
--- package/neardal/Config.in | 2 +- package/neardal/neardal.mk | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-)
package/neardal/Config.in +1 -1
@@ -5,7 +5,7 @@ config BR2_PACKAGE_NEARDAL depends on BR2_USE_MMU # dbus select BR2_PACKAGE_DBUS select BR2_PACKAGE_DBUS_GLIB - select BR2_PACKAGE_READLINE if !BR2_PACKAGE_LIBEDIT + select BR2_PACKAGE_LIBEDIT help Provides a simple C API to exchange data with the neard NFC manager daemon.
package/neardal/neardal.mk +1 -9
@@ -10,17 +10,9 @@ NEARDAL_INSTALL_STAGING = YES NEARDAL_LICENSE = GPL-2.0 NEARDAL_LICENSE_FILES = COPYING -NEARDAL_DEPENDENCIES = host-pkgconf dbus dbus-glib +NEARDAL_DEPENDENCIES = host-pkgconf dbus dbus-glib libedit NEARDAL_AUTORECONF = YES -# Either readline or libedit are needed, and the Config.in file -# guarantees at least one of them is enabled -ifeq ($(BR2_PACKAGE_READLINE),y) -NEARDAL_DEPENDENCIES += readline -else ifeq ($(BR2_PACKAGE_LIBEDIT),y) -NEARDAL_DEPENDENCIES += libedit -endif - define NEARDAL_INSTALL_NCL $(INSTALL) -m 0755 -D $(@D)/ncl/ncl $(TARGET_DIR)/usr/bin/ncl endef
Signature · 1 line
2.20.1
PATCH 9/11 package/neardal: unconditionally use libedit
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 1 line
neardal is licensed under GPL-2.0, which is not license compatible with
neardal is not GPL-2.0; it is LGPL-2.0:
https://github.com/connectivity/neardal/blob/master/COPYING
LGPL-2.1 can be "promoted" to be GPLv3-compatible:
https://en.wikipedia.org/wiki/License_compatibility#Compatibility_of_FOSS_licenses
But I could not find anything about LGPL-2.0...
Regards,
Yann E. MORIN.
Quoted 51 lines
readline (GPL-3.0+), so always use the libedit backend.
Signed-off-by Peter Korsgaard <[email protected]>--- package/neardal/Config.in | 2 +- package/neardal/neardal.mk | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-)package/neardal/Config.in +1
-1@@ -5,7 +5,7 @@ config BR2_PACKAGE_NEARDAL depends on BR2_USE_MMU # dbus select BR2_PACKAGE_DBUS select BR2_PACKAGE_DBUS_GLIB - select BR2_PACKAGE_READLINE if !BR2_PACKAGE_LIBEDIT + select BR2_PACKAGE_LIBEDIT help Provides a simple C API to exchange data with the neard NFC manager daemon.package/neardal/neardal.mk +1
-9@@ -10,17 +10,9 @@ NEARDAL_INSTALL_STAGING = YES NEARDAL_LICENSE = GPL-2.0 NEARDAL_LICENSE_FILES = COPYING -NEARDAL_DEPENDENCIES = host-pkgconf dbus dbus-glib +NEARDAL_DEPENDENCIES = host-pkgconf dbus dbus-glib libedit NEARDAL_AUTORECONF = YES -# Either readline or libedit are needed, and the Config.in file -# guarantees at least one of them is enabled -ifeq ($(BR2_PACKAGE_READLINE),y) -NEARDAL_DEPENDENCIES += readline -else ifeq ($(BR2_PACKAGE_LIBEDIT),y) -NEARDAL_DEPENDENCIES += libedit -endif - define NEARDAL_INSTALL_NCL $(INSTALL) -m 0755 -D $(@D)/ncl/ncl $(TARGET_DIR)/usr/bin/ncl endefSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 9/11 package/neardal: unconditionally use libedit
In reply to Peter KorsgaardQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
neardal is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so always use the libedit backend.
Signed-off-by Peter Korsgaard <[email protected]>
Strangely enough I have not received your reply, neither directly or through the list, even though I see it in the archive - I guess the mail issues aren't over yet.
Anyway, you are right - Our license tag is apparently wrong, and I didn't verify it.
Still, given the unclarity about LGPL-2.0 vs GPL-3.0 - And the fact that readline is only used in the ncl utility and not in the library (and using LGPL for an application), so I would prefer to err on the side of caution and unconditionally use libedit.
I will send an updated series changing _LICENSE and adjusting the commit message of this patch to refer to LGPL instead.
Thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 10/11 package/oracle-mysql: use bundled GPL-2.0+ libreadline
In reply to Peter Korsgaardoracle-mysql is licensed under GPL-2.0, which is not license compatible with modern readline (GPL-3.0+), so instead use the bundled older version (GPL-2.0+ licensed) of readline instead.
--- package/mysql/Config.in | 1 - package/oracle-mysql/oracle-mysql.mk | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)
package/mysql/Config.in +0 -1
@@ -37,7 +37,6 @@ comment "mariadb needs a toolchain w/ dynamic library" config BR2_PACKAGE_ORACLE_MYSQL bool "oracle mysql" select BR2_PACKAGE_NCURSES - select BR2_PACKAGE_READLINE select BR2_PACKAGE_HAS_MYSQL help The MySQL Open Source Database System
package/oracle-mysql/oracle-mysql.mk +2 -2
@@ -9,7 +9,7 @@ ORACLE_MYSQL_VERSION = $(ORACLE_MYSQL_VERSION_MAJOR).73 ORACLE_MYSQL_SOURCE = mysql-$(ORACLE_MYSQL_VERSION).tar.gz ORACLE_MYSQL_SITE = http://dev.mysql.com/get/Downloads/MySQL-$(ORACLE_MYSQL_VERSION_MAJOR) ORACLE_MYSQL_INSTALL_STAGING = YES -ORACLE_MYSQL_DEPENDENCIES = readline ncurses +ORACLE_MYSQL_DEPENDENCIES = ncurses ORACLE_MYSQL_AUTORECONF = YES ORACLE_MYSQL_LICENSE = GPL-2.0 ORACLE_MYSQL_LICENSE_FILES = README COPYING
@@ -33,7 +33,7 @@ ORACLE_MYSQL_CONF_OPTS = \ --without-docs \ --without-man \ --without-libedit \ - --without-readline \ + --with-readline \ --with-low-memory \ --enable-thread-safe-client \ --with-unix-socket-path=$(MYSQL_SOCKET) \
Signature · 1 line
2.20.1
Yann E. MORIN
AppliedPATCH 10/11 package/oracle-mysql: use bundled GPL-2.0+ libreadline
Peter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 5 lines
oracle-mysql is licensed under GPL-2.0, which is not license compatible with modern readline (GPL-3.0+), so instead use the bundled older version (GPL-2.0+ licensed) of readline instead.
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 46 lines
--- package/mysql/Config.in | 1 - package/oracle-mysql/oracle-mysql.mk | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)package/mysql/Config.in +0
-1@@ -37,7 +37,6 @@ comment "mariadb needs a toolchain w/ dynamic library" config BR2_PACKAGE_ORACLE_MYSQL bool "oracle mysql" select BR2_PACKAGE_NCURSES - select BR2_PACKAGE_READLINE select BR2_PACKAGE_HAS_MYSQL help The MySQL Open Source Database Systempackage/oracle-mysql/oracle-mysql.mk +2
-2@@ -9,7 +9,7 @@ ORACLE_MYSQL_VERSION = $(ORACLE_MYSQL_VERSION_MAJOR).73 ORACLE_MYSQL_SOURCE = mysql-$(ORACLE_MYSQL_VERSION).tar.gz ORACLE_MYSQL_SITE = http://dev.mysql.com/get/Downloads/MySQL-$(ORACLE_MYSQL_VERSION_MAJOR) ORACLE_MYSQL_INSTALL_STAGING = YES -ORACLE_MYSQL_DEPENDENCIES = readline ncurses +ORACLE_MYSQL_DEPENDENCIES = ncurses ORACLE_MYSQL_AUTORECONF = YES ORACLE_MYSQL_LICENSE = GPL-2.0 ORACLE_MYSQL_LICENSE_FILES = README COPYING@@ -33,7 +33,7 @@ ORACLE_MYSQL_CONF_OPTS = \ --without-docs \ --without-man \ --without-libedit \ - --without-readline \ + --with-readline \ --with-low-memory \ --enable-thread-safe-client \ --with-unix-socket-path=$(MYSQL_SOCKET) \Signature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 10/11 package/oracle-mysql: use bundled GPL-2.0+ libreadline
In reply to Peter KorsgaardQuoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
oracle-mysql is licensed under GPL-2.0, which is not license compatible with modern readline (GPL-3.0+), so instead use the bundled older version (GPL-2.0+ licensed) of readline instead.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 11/11 package/socat: drop optional readline dependency
In reply to Peter Korsgaardsocat is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
This also matches how socat is packaged in Debian, where the man page has the following snippet added:
READLINE
Uses GNU readline and history on stdio to allow editing and reusing input lines (example). Due to licensing restrictions the readline feature is disabled in Debian. See BUGS. You can use STDIO instead.
--- package/socat/socat.mk | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
package/socat/socat.mk +2 -6
@@ -27,6 +27,8 @@ endif # automake, so we can't use the normal autoreconf logic. SOCAT_DEPENDENCIES = host-autoconf +# incompatibile license (GPL-3.0+) +SOCAT_CONF_OPTS = --disable-readline ifeq ($(BR2_PACKAGE_OPENSSL),y) SOCAT_DEPENDENCIES += openssl
@@ -34,12 +36,6 @@ else SOCAT_CONF_OPTS += --disable-openssl endif -ifeq ($(BR2_PACKAGE_READLINE),y) -SOCAT_DEPENDENCIES += readline -else -SOCAT_CONF_OPTS += --disable-readline -endif - define SOCAT_RUN_AUTOCONF (cd $(@D); $(HOST_DIR)/bin/autoconf) endef
Signature · 1 line
2.20.1
PATCH 11/11 package/socat: drop optional readline dependency
Hi Peter,
Quoted 7 lines · Peter Korsgaard
socat is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
This also matches how socat is packaged in Debian, where the man page has the following snippet added:
Quoted 7 lines
READLINE
Uses GNU readline and history on stdio to allow editing and reusing input lines (example). Due to licensing restrictions the readline feature is disabled in Debian. See BUGS. You can use STDIO instead.
Signed-off-by Peter Korsgaard <[email protected]>
Thanks,
baruch
Quoted 30 lines
--- package/socat/socat.mk | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)package/socat/socat.mk +2
-6@@ -27,6 +27,8 @@ endif # automake, so we can't use the normal autoreconf logic. SOCAT_DEPENDENCIES = host-autoconf +# incompatibile license (GPL-3.0+) +SOCAT_CONF_OPTS = --disable-readline ifeq ($(BR2_PACKAGE_OPENSSL),y) SOCAT_DEPENDENCIES += openssl@@ -34,12 +36,6 @@ else SOCAT_CONF_OPTS += --disable-openssl endif -ifeq ($(BR2_PACKAGE_READLINE),y) -SOCAT_DEPENDENCIES += readline -else -SOCAT_CONF_OPTS += --disable-readline -endif - define SOCAT_RUN_AUTOCONF (cd $(@D); $(HOST_DIR)/bin/autoconf) endef
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -Yann E. MORIN
AppliedPATCH 11/11 package/socat: drop optional readline dependency
In reply to Peter KorsgaardPeter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 7 lines
socat is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
This also matches how socat is packaged in Debian, where the man page has the following snippet added:
Quoted 7 lines
READLINE
Uses GNU readline and history on stdio to allow editing and reusing input lines (example). Due to licensing restrictions the readline feature is disabled in Debian. See BUGS. You can use STDIO instead.
Signed-off-by Peter Korsgaard <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 37 lines
--- package/socat/socat.mk | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)package/socat/socat.mk +2
-6@@ -27,6 +27,8 @@ endif # automake, so we can't use the normal autoreconf logic. SOCAT_DEPENDENCIES = host-autoconf +# incompatibile license (GPL-3.0+) +SOCAT_CONF_OPTS = --disable-readline ifeq ($(BR2_PACKAGE_OPENSSL),y) SOCAT_DEPENDENCIES += openssl@@ -34,12 +36,6 @@ else SOCAT_CONF_OPTS += --disable-openssl endif -ifeq ($(BR2_PACKAGE_READLINE),y) -SOCAT_DEPENDENCIES += readline -else -SOCAT_CONF_OPTS += --disable-readline -endif - define SOCAT_RUN_AUTOCONF (cd $(@D); $(HOST_DIR)/bin/autoconf) endefSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 11/11 package/socat: drop optional readline dependency
In reply to Peter KorsgaardQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
socat is licensed under GPL-2.0, which is not license compatible with readline (GPL-3.0+), so drop the optional dependency and add a comment explaining why.
This also matches how socat is packaged in Debian, where the man page has the following snippet added:
Quoted 7 lines
READLINE
Uses GNU readline and history on stdio to allow editing and reusing input lines (example). Due to licensing restrictions the readline feature is disabled in Debian. See BUGS. You can use STDIO instead.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
cover Fix license incompatibility with readline
In reply to Peter KorsgaardPeter, All,
On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
Quoted 7 lines
We have a number of packages where we (optionally) link with readline, even though the license of the package isn't compatible with the license of readline (GPL-3.0+), E.G. for packages licensed under GPL-2.0 only.
This series aims to fix that. I've tried to review the entire tree, and this is what I found:
Thanks a lot for doing this tedious work. Series mostly applied to master now, except these two patches:
Quoted 2 lines
kodi: fixed (GPL-2.0)
neardal: fixed (GPL-2.0)
I'll reply (or have already replied) with more details to the individual patches.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'