net: print proper warning on dst underflow
Subsystems (2)
PATCH 1/1 net: print proper warning on dst underflow
Proper warnings with stack traces make it much easier to figure out what's doing the double free and create more meaningful bug reports from users.
--- net/core/dst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/core/dst.c +2 -2
@@ -172,7 +172,7 @@ void dst_release(struct dst_entry *dst)int newrefcnt; newrefcnt =atomic_dec_return (&dst->__refcnt); -if (unlikely (newrefcnt <0 )) +if (WARN_ONCE (newrefcnt <0 ,"dst_release underflow" ))net_warn_ratelimited ("%s: dst:%p refcnt:%d\n" , __func__, dst, newrefcnt);if (!newrefcnt)
@@ -187,7 +187,7 @@ void dst_release_immediate(struct dst_entry *dst)int newrefcnt; newrefcnt =atomic_dec_return (&dst->__refcnt); -if (unlikely (newrefcnt <0 )) +if (WARN_ONCE (newrefcnt <0 ,"dst_release_immediate underflow" ))net_warn_ratelimited ("%s: dst:%p refcnt:%d\n" , __func__, dst, newrefcnt);if (!newrefcnt)
Signature · 1 line
2.21.0
From: "Jason A. Donenfeld" <[email protected]>
Date: Tue, 24 Sep 2019 11:09:37 +0200
Quoted 5 lines
Proper warnings with stack traces make it much easier to figure out what's doing the double free and create more meaningful bug reports from users.
Signed-off-by Jason A. Donenfeld <[email protected]>
Applied, thanks.
Quoted 14 lines · Jason A. Donenfeld
Proper warnings with stack traces make it much easier to figure out what's doing the double free and create more meaningful bug reports from users.
Signed-off-by Jason A. Donenfeld <[email protected]>--- net/core/dst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)net/core/dst.c +0
-0
net/core/dst.c void dst_release(struct dst_entry *dst) · line 177
Quoted 7 lines
net/core/dst.c +1
-1@@ -172,7 +172,7 @@ void dst_release(struct dst_entry *dst)int newrefcnt; newrefcnt =atomic_dec_return (&dst->__refcnt); -if (unlikely (newrefcnt <0 )) +if (WARN_ONCE (newrefcnt <0 ,"dst_release underflow" ))net_warn_ratelimited ("%s: dst:%p refcnt:%d\n" , __func__, dst, newrefcnt);
Should __refcnt be a refcount_t to gain saturation protection? It seems like going negative is bad...
-Kees
Quoted 13 lines
net/core/dst.c +1
-1if (!newrefcnt)@@ -187,7 +187,7 @@ void dst_release_immediate(struct dst_entry *dst)int newrefcnt; newrefcnt =atomic_dec_return (&dst->__refcnt); -if (unlikely (newrefcnt <0 )) +if (WARN_ONCE (newrefcnt <0 ,"dst_release_immediate underflow" ))net_warn_ratelimited ("%s: dst:%p refcnt:%d\n" , __func__, dst, newrefcnt);if (!newrefcnt)Signature · 1 line
2.21.0
Signature · 1 line
Kees Cook