staging: exfat: Fix CamelCase in function names
PATCH 1/1 staging: exfat: Fix CamelCase in function names
This patch fixes CamelCase in function names with the ffs prefix. Issue found by checkpatch.
Signed-off-by Javier F. Arias <[email protected]>
--- drivers/staging/exfat/exfat_super.c | 84 ++++++++++++++--------------- 1 file changed, 42 insertions(+), 42 deletions(-)
drivers/staging/exfat/exfat_super.c +42 -42
@@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)EXFAT_I (inode)->fid.attr = attr & (ATTR_RWMASK |ATTR_READONLY ); } -static int ffsMountVol (struct super_block *sb) +static int ffs_mount_vol (struct super_block *sb) {int i, ret;struct pbr_sector_t *p_pbr;
@@ -439,7 +439,7 @@ static int ffsMountVol(struct super_block *sb)return ret; } -static int ffsUmountVol (struct super_block *sb) +static int fss_umount_vol (struct super_block *sb) {struct fs_info_t *p_fs = &(EXFAT_SB (sb)->fs_info);int err =0 ;
@@ -479,7 +479,7 @@ static int ffsUmountVol(struct super_block *sb)return err; } -static int ffsGetVolInfo (struct super_block *sb,struct vol_info_t *info) +static int ffs_get_vol_info (struct super_block *sb,struct vol_info_t *info) {int err =0 ;struct fs_info_t *p_fs = &(EXFAT_SB (sb)->fs_info);
@@ -509,7 +509,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)return err; } -static int ffsSyncVol (struct super_block *sb,bool do_sync) +static int ffs_sync_vol (struct super_block *sb,bool do_sync) {int err =0 ;struct fs_info_t *p_fs = &(EXFAT_SB (sb)->fs_info);
@@ -534,7 +534,7 @@ static int ffsSyncVol(struct super_block *sb, bool do_sync)/* File Operation Functions */ /*----------------------------------------------------------------------*/ -static int ffsLookupFile (struct inode *inode,char *path,struct file_id_t *fid) +static int ffs_lookup_file (struct inode *inode,char *path,struct file_id_t *fid) {int ret, dentry, num_entries;struct chain_t dir;
@@ -621,7 +621,7 @@ static int ffsLookupFile(struct inode *inode, char *path, struct file_id_t *fid)return ret; } -static int ffsCreateFile (struct inode *inode,char *path,u8 mode, +static int ffs_create_file (struct inode *inode,char *path,u8 mode,struct file_id_t *fid) {struct chain_t dir;
@@ -662,7 +662,7 @@ static int ffsCreateFile(struct inode *inode, char *path, u8 mode,return ret; } -static int ffsReadFile (struct inode *inode,struct file_id_t *fid,void *buffer, +static int ffs_read_file (struct inode *inode,struct file_id_t *fid,void *buffer,u64 count,u64 *rcount) {s32 offset, sec_offset, clu_offset;
@@ -788,7 +788,7 @@ static int ffsReadFile(struct inode *inode, struct file_id_t *fid, void *buffer,return ret; } -static int ffsWriteFile (struct inode *inode,struct file_id_t *fid, +static int ffs_write_file (struct inode *inode,struct file_id_t *fid,void *buffer,u64 count,u64 *wcount) {bool modified = false;
@@ -1031,7 +1031,7 @@ static int ffsWriteFile(struct inode *inode, struct file_id_t *fid,return ret; } -static int ffsTruncateFile (struct inode *inode,u64 old_size,u64 new_size) +static int ffs_truncate_file (struct inode *inode,u64 old_size,u64 new_size) {s32 num_clusters;u32 last_clu =CLUSTER_32 (0 );
@@ -1167,7 +1167,7 @@ static void update_parent_info(struct file_id_t *fid, } } -static int ffsMoveFile (struct inode *old_parent_inode,struct file_id_t *fid, +static int ffs_move_file (struct inode *old_parent_inode,struct file_id_t *fid,struct inode *new_parent_inode,struct dentry *new_dentry) {s32 ret;
@@ -1296,7 +1296,7 @@ static int ffsMoveFile(struct inode *old_parent_inode, struct file_id_t *fid,return ret; } -static int ffsRemoveFile (struct inode *inode,struct file_id_t *fid) +static int ffs_remove_file (struct inode *inode,struct file_id_t *fid) {s32 dentry;int ret =0 ;
@@ -1360,7 +1360,7 @@ static int ffsRemoveFile(struct inode *inode, struct file_id_t *fid)#if 0 /* Not currently wired up */ -static int ffsSetAttr (struct inode *inode,u32 attr) +static int ffs_set_attr (struct inode *inode,u32 attr) {u32 type;int ret =0 ;
@@ -1435,7 +1435,7 @@ static int ffsSetAttr(struct inode *inode, u32 attr) }#endif -static int ffsReadStat (struct inode *inode,struct dir_entry_t *info) +static int ffs_read_stat (struct inode *inode,struct dir_entry_t *info) {s32 count;int ret =0 ;
@@ -1565,7 +1565,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)return ret; } -static int ffsWriteStat (struct inode *inode,struct dir_entry_t *info) +static int ffs_write_stat (struct inode *inode,struct dir_entry_t *info) {int ret =0 ;struct timestamp_t tm;
@@ -1638,7 +1638,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)return ret; } -static int ffsMapCluster (struct inode *inode,s32 clu_offset,u32 *clu) +static int ffs_map_cluster (struct inode *inode,s32 clu_offset,u32 *clu) {s32 num_clusters, num_alloced;bool modified = false;
@@ -1778,7 +1778,7 @@ static int ffsMapCluster(struct inode *inode, s32 clu_offset, u32 *clu)/* Directory Operation Functions */ /*----------------------------------------------------------------------*/ -static int ffsCreateDir (struct inode *inode,char *path,struct file_id_t *fid) +static int ffs_create_dir (struct inode *inode,char *path,struct file_id_t *fid) {int ret =0 ;struct chain_t dir;
@@ -1818,7 +1818,7 @@ static int ffsCreateDir(struct inode *inode, char *path, struct file_id_t *fid)return ret; } -static int ffsReadDir (struct inode *inode,struct dir_entry_t *dir_entry) +static int ffs_read_dir (struct inode *inode,struct dir_entry_t *dir_entry) {int i, dentry, clu_offset;int ret =0 ;
@@ -2005,7 +2005,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)return ret; } -static int ffsRemoveDir (struct inode *inode,struct file_id_t *fid) +static int ffs_remove_dir (struct inode *inode,struct file_id_t *fid) {s32 dentry;int ret =0 ;
@@ -2114,7 +2114,7 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx)EXFAT_I (inode)->fid.size =i_size_read (inode);EXFAT_I (inode)->fid.rwoffset = cpos >>DENTRY_SIZE_BITS ; - err =ffsReadDir (inode, &de); + err =ffs_read_dir (inode, &de);if (err) {/* at least we tried to read a sector * move cpos to next sector position (should be aligned)
@@ -2235,7 +2235,7 @@ static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t mode,pr_debug ("%s entered\n" , __func__); - err =ffsCreateFile (dir, (u8 *)dentry->d_name.name,FM_REGULAR , &fid); + err =ffs_create_file (dir, (u8 *)dentry->d_name.name,FM_REGULAR , &fid);if (err) goto out;
@@ -2282,7 +2282,7 @@ static int exfat_find(struct inode *dir, struct qstr *qname,if (qname->len ==0 )return -ENOENT ; - err =ffsLookupFile (dir, (u8 *)qname->name, fid); + err =ffs_lookup_file (dir, (u8 *)qname->name, fid);if (err)return -ENOENT ;
@@ -2332,7 +2332,7 @@ static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry, err = -ENOMEM ; goto error; } -ffsReadFile (dir, &fid,EXFAT_I (inode)->target, +ffs_read_file (dir, &fid,EXFAT_I (inode)->target,i_size_read (inode), &ret); *(EXFAT_I (inode)->target +i_size_read (inode)) ='\0' ; }
@@ -2402,7 +2402,7 @@ static int exfat_unlink(struct inode *dir, struct dentry *dentry)EXFAT_I (inode)->fid.size =i_size_read (inode); - err =ffsRemoveFile (dir, &(EXFAT_I (inode)->fid)); + err =ffs_remove_file (dir, &(EXFAT_I (inode)->fid));if (err) goto out;
@@ -2444,15 +2444,15 @@ static int exfat_symlink(struct inode *dir, struct dentry *dentry,pr_debug ("%s entered\n" , __func__); - err =ffsCreateFile (dir, (u8 *)dentry->d_name.name,FM_SYMLINK , &fid); + err =ffs_create_file (dir, (u8 *)dentry->d_name.name,FM_SYMLINK , &fid);if (err) goto out; - err =ffsWriteFile (dir, &fid, (char *)target, len, &ret); + err =ffs_write_file (dir, &fid, (char *)target, len, &ret);if (err) { -ffsRemoveFile (dir, &fid); +ffs_remove_file (dir, &fid); goto out; }
@@ -2508,7 +2508,7 @@ static int exfat_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)pr_debug ("%s entered\n" , __func__); - err =ffsCreateDir (dir, (u8 *)dentry->d_name.name, &fid); + err =ffs_create_dir (dir, (u8 *)dentry->d_name.name, &fid);if (err) goto out;
@@ -2559,7 +2559,7 @@ static int exfat_rmdir(struct inode *dir, struct dentry *dentry)EXFAT_I (inode)->fid.size =i_size_read (inode); - err =ffsRemoveDir (dir, &(EXFAT_I (inode)->fid)); + err =ffs_remove_dir (dir, &(EXFAT_I (inode)->fid));if (err) goto out;
@@ -2608,7 +2608,7 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,EXFAT_I (old_inode)->fid.size =i_size_read (old_inode); - err =ffsMoveFile (old_dir, &(EXFAT_I (old_inode)->fid), new_dir, + err =ffs_move_file (old_dir, &(EXFAT_I (old_inode)->fid), new_dir, new_dentry);if (err) goto out;
@@ -2766,7 +2766,7 @@ static void exfat_truncate(struct inode *inode, loff_t old_size)if (EXFAT_I (inode)->fid.start_clu ==0 ) goto out; - err =ffsTruncateFile (inode, old_size,i_size_read (inode)); + err =ffs_truncate_file (inode, old_size,i_size_read (inode));if (err) goto out;
@@ -2902,7 +2902,7 @@ static int exfat_file_release(struct inode *inode, struct file *filp)struct super_block *sb = inode->i_sb;EXFAT_I (inode)->fid.size =i_size_read (inode); -ffsSyncVol (sb, false); +ffs_sync_vol (sb, false);return 0 ; }
@@ -2957,7 +2957,7 @@ static int exfat_bmap(struct inode *inode, sector_t sector, sector_t *phys,EXFAT_I (inode)->fid.size =i_size_read (inode); - err =ffsMapCluster (inode, clu_offset, &cluster); + err =ffs_map_cluster (inode, clu_offset, &cluster);if (!err && (cluster !=CLUSTER_32 (~0 ))) { *phys =START_SECTOR (cluster) + sec_offset;
@@ -3150,7 +3150,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)memcpy (&(EXFAT_I (inode)->fid), fid,sizeof (struct file_id_t )); -ffsReadStat (inode, &info); +ffs_read_stat (inode, &info);EXFAT_I (inode)->i_pos =0 ;EXFAT_I (inode)->target =NULL ;
@@ -3266,7 +3266,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc)exfat_time_unix2fat (&inode->i_ctime, &info.CreateTimestamp);exfat_time_unix2fat (&inode->i_atime, &info.AccessTimestamp); -ffsWriteStat (inode, &info); +ffs_write_stat (inode, &info);return 0 ; }
@@ -3304,7 +3304,7 @@ static void exfat_put_super(struct super_block *sb)if (__is_sb_dirty (sb))exfat_write_super (sb); -ffsUmountVol (sb); +fss_umount_vol (sb); sb->s_fs_info =NULL ;exfat_free_super (sbi);
@@ -3317,7 +3317,7 @@ static void exfat_write_super(struct super_block *sb)__set_sb_clean (sb);if (!sb_rdonly (sb)) -ffsSyncVol (sb, true); +ffs_sync_vol (sb, true);__unlock_super (sb); }
@@ -3329,7 +3329,7 @@ static int exfat_sync_fs(struct super_block *sb, int wait)if (__is_sb_dirty (sb)) {__lock_super (sb);__set_sb_clean (sb); - err =ffsSyncVol (sb, true); + err =ffs_sync_vol (sb, true);__unlock_super (sb); }
@@ -3344,7 +3344,7 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)struct vol_info_t info;if (p_fs->used_clusters ==UINT_MAX ) { -if (ffsGetVolInfo (sb, &info) == -EIO ) +if (ffs_get_vol_info (sb, &info) == -EIO )return -EIO ; }else {
@@ -3646,7 +3646,7 @@ static int exfat_read_root(struct inode *inode)EXFAT_I (inode)->target =NULL ; -ffsReadStat (inode, &info); +ffs_read_stat (inode, &info); inode->i_uid = sbi->options.fs_uid; inode->i_gid = sbi->options.fs_gid;
@@ -3713,10 +3713,10 @@ static int exfat_fill_super(struct super_block *sb, void *data, int silent)sb_min_blocksize (sb,512 ); sb->s_maxbytes =0x7fffffffffffffffLL ;/* maximum file size */ - ret =ffsMountVol (sb); + ret =ffs_mount_vol (sb);if (ret) {if (!silent) -pr_err ("[EXFAT] ffsMountVol failed\n" ); +pr_err ("[EXFAT] ffs_mount_vol failed\n" ); goto out_fail; }
@@ -3756,7 +3756,7 @@ static int exfat_fill_super(struct super_block *sb, void *data, int silent)return 0 ; out_fail2: -ffsUmountVol (sb); +fss_umount_vol (sb); out_fail:if (root_inode)iput (root_inode);
Signature · 1 line
2.20.1
Greg KH
maintainerQuoted 13 lines · Javier F. Arias
This patch fixes CamelCase in function names with the ffs prefix. Issue found by checkpatch.
Signed-off-by Javier F. Arias <[email protected]>--- drivers/staging/exfat/exfat_super.c | 84 ++++++++++++++--------------- 1 file changed, 42 insertions(+), 42 deletions(-)drivers/staging/exfat/exfat_super.c +0
-0
drivers/staging/exfat/exfat_super.c static inline void exfat_save_attr(struct inode *inode, u32 attr) · line 346
Quoted 5 lines
drivers/staging/exfat/exfat_super.c +1
-1@@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)EXFAT_I (inode)->fid.attr = attr & (ATTR_RWMASK |ATTR_READONLY ); } -static int ffsMountVol (struct super_block *sb) +static int ffs_mount_vol (struct super_block *sb)
Can't you just get rid of the crazy ffs prefix as well?
That would be best, look at the TODO file, it says to do just that :)
thanks,
greg k-h