target/core: Fix a use-after-free in the TMF handling code
PATCH v3 2/3 target/core: Fix a use-after-free in the TMF handling code
The target_remove_from_state_list() call uses the cmd->dev pointer. Make sure that that pointer is valid as long as TMF processing is in progress. This patch fixes the following KASAN complaint:
BUG: KASAN: use-after-free in target_remove_from_state_list+0x22/0x130 [target_core_mod]
Read of size 8 at addr ffff8880b110cf80 by task kworker/0:1/12
CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.4.0-rc1-dbg+ #6
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Workqueue: events target_tmr_work [target_core_mod]
Call Trace:
dump_stack+0x8a/0xd6
print_address_description.constprop.0+0x40/0x60
__kasan_report.cold+0x1b/0x33
kasan_report+0x16/0x20
__asan_load8+0x58/0x90
target_remove_from_state_list+0x22/0x130 [target_core_mod]
transport_cmd_check_stop_to_fabric+0x17/0xe0 [target_core_mod]
target_tmr_work+0xe2/0x1a0 [target_core_mod]
process_one_work+0x549/0xa40
worker_thread+0x7a/0x5d0
kthread+0x1bc/0x210
ret_from_fork+0x24/0x30
The buggy address belongs to the page:
page:ffffea0002c44300 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0
flags: 0x1fff000000000000()
raw: 1fff000000000000 0000000000000000 ffffea0002c44308 0000000000000000
raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff8880b110ce80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff8880b110cf00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff8880b110cf80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff8880b110d000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff8880b110d080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff--- drivers/target/target_core_transport.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/target/target_core_transport.c +6 -0
@@ -3256,6 +3256,8 @@ static void target_tmr_work(struct work_struct *work)struct se_tmr_req *tmr = cmd->se_tmr_req;int ret; +config_item_get (&dev->dev_group.cg_item); +if (cmd->transport_state &CMD_T_ABORTED ) goto aborted;
@@ -3297,10 +3299,14 @@ static void target_tmr_work(struct work_struct *work) cmd->se_tfo->queue_tm_rsp (cmd);transport_cmd_check_stop_to_fabric (cmd); + +out: +config_item_put (&dev->dev_group.cg_item);return ; aborted:target_handle_abort (cmd); + goto out; } int transport_generic_handle_tmr(
Quoted 64 lines · Bart Van Assche
The
target_remove_from_state_list()call uses thecmd->devpointer. Make sure that that pointer is valid as long as TMF processing is in progress. This patch fixes the following KASAN complaint:BUG: KASAN: use-after-free in target_remove_from_state_list+0x22/0x130 [target_core_mod] Read of size 8 at addr ffff8880b110cf80 by task kworker/0:1/12 CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.4.0-rc1-dbg+ #6 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 Workqueue: events target_tmr_work [target_core_mod] Call Trace: dump_stack+0x8a/0xd6 print_address_description.constprop.0+0x40/0x60 __kasan_report.cold+0x1b/0x33 kasan_report+0x16/0x20 __asan_load8+0x58/0x90 target_remove_from_state_list+0x22/0x130 [target_core_mod] transport_cmd_check_stop_to_fabric+0x17/0xe0 [target_core_mod] target_tmr_work+0xe2/0x1a0 [target_core_mod] process_one_work+0x549/0xa40 worker_thread+0x7a/0x5d0 kthread+0x1bc/0x210 ret_from_fork+0x24/0x30 The buggy address belongs to the page: page:ffffea0002c44300 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 flags: 0x1fff000000000000() raw: 1fff000000000000 0000000000000000 ffffea0002c44308 0000000000000000 raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8880b110ce80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ffff8880b110cf00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff >ffff8880b110cf80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ^ ffff8880b110d000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ffff8880b110d080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ffCc Mike Christie <[email protected]>Cc Roman Bolshakov <[email protected]>Signed-off-by Bart Van Assche <[email protected]>--- drivers/target/target_core_transport.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/target/target_core_transport.c +3
-0@@ -3256,6 +3256,8 @@ static void target_tmr_work(struct work_struct *work)struct se_tmr_req *tmr = cmd->se_tmr_req;int ret; +config_item_get (&dev->dev_group.cg_item); +if (cmd->transport_state &CMD_T_ABORTED ) goto aborted;@@ -3297,10 +3299,14 @@ static void target_tmr_work(struct work_struct *work) cmd->se_tfo->queue_tm_rsp (cmd);transport_cmd_check_stop_to_fabric (cmd); +
drivers/target/target_core_transport.c static void target_tmr_work(struct work_struct *work) · line 3312
Quoted 10 lines
drivers/target/target_core_transport.c +3
-0+out: +config_item_put (&dev->dev_group.cg_item);return ; aborted:target_handle_abort (cmd); + goto out; } int transport_generic_handle_tmr(
Hi Bart,
I might be well wrong but could it happen that refcount of se_device becomes zero before the work starts? Shouldn't we get the refcount increased before the work is scheduled in transport_generic_handle_tmr()?
Thanks,
Roman
Quoted 28 lines · Roman Bolshakov
Quoted 27 lines · Bart Van Assche
drivers/target/target_core_transport.c +6
-0@@ -3256,6 +3256,8 @@ static void target_tmr_work(struct work_struct *work)struct se_tmr_req *tmr = cmd->se_tmr_req;int ret; +config_item_get (&dev->dev_group.cg_item); +if (cmd->transport_state &CMD_T_ABORTED ) goto aborted;@@ -3297,10 +3299,14 @@ static void target_tmr_work(struct work_struct *work) cmd->se_tfo->queue_tm_rsp (cmd);transport_cmd_check_stop_to_fabric (cmd); + +out: +config_item_put (&dev->dev_group.cg_item);return ; aborted:target_handle_abort (cmd); + goto out; }
Quoted 5 lines
drivers/target/target_core_transport.c static void target_tmr_work(struct work_struct *work) · line 3312
Quoted 1 line
drivers/target/target_core_transport.c +0
-0int transport_generic_handle_tmr(I might be well wrong but could it happen that refcount of
se_devicebecomes zero before the work starts? Shouldn't we get the refcount increased before the work is scheduled intransport_generic_handle_tmr()?
Hi Roman,
Looking closer into this, I couldn't find an explanation why lun_ref does not prevent 'dev' to disappear. In the tests I ran without this patch the issue did not reappear. So the call trace mentioned in the patch description probably has the same root cause as patch 3/3. I will drop this patch.
Bart.