Skip to contentSkip to conversation

test-runner: erase valgrind log after each test

PATCH Applied James Prestwood 2 participants 2 messages Nov 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-runner: erase valgrind log after each test

After changing the valgrind log to --log-fd, it appears that the log file just gets appended, where before it was overwritten. This makes test print out all previous tests valgrind results.

Now after printing out the valgrind info we can erase the file for the next test.

---
 tools/test-runner.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/test-runner.c +5 -1
index 043e8cc7..075f56d6 100644
@@ -2226,10 +2226,14 @@ static void create_network_and_run_tests(void *data, void *user_data)
 		terminate_iwd(iwd_pid);
 
 	/* /tmp/valgrind.log will only exist without logging turned on */
-	if (valgrind && !log)
+	if (valgrind && !log) {
 		if (system("cat /tmp/valgrind.log"))
 			l_info("cat /tmp/valgrind.log failed");
 
+		if (system("echo \"\" > /tmp/valgrind.log"))
+			l_info("Failed to reset /tmp/valgrind.log");
+	}
+
 	if (log) {
 		L_AUTO_FREE_VAR(char *, dmesg);
 		L_AUTO_FREE_VAR(char *, kernel_log);
Signature · 1 line
2.17.1
#1 lore raw

Hi James,

Quoted 10 lines · James Prestwood

After changing the valgrind log to --log-fd, it appears that the log file just gets appended, where before it was overwritten. This makes test print out all previous tests valgrind results.

Now after printing out the valgrind info we can erase the file for the next test.

---
  tools/test-runner.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis