Skip to contentSkip to conversation

icecc-create-env: Use OE patchelf in SDK

PATCH In review Joshua Watt 2 participants 4 messages Nov 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 icecc-create-env: Use OE patchelf in SDK

The Icecream environment creation script runs when the SDK is installed and uses patchelf to fix up executables. Rather than rely on the host system to provided patchelf (which often can be older versions that produce buggy executables), mark the OE version of patchelf as a dependency of icecc-create-env when included in the SDK.

---
 meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/icecc-create-env/icecc-create-env_0.1.bb +2 -0
index 053945ebbc..231c1c20ec 100644
@@ -34,3 +34,5 @@ do_install() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
+
+RDEPENDS_${PN}_class-nativesdk = "patchelf"
Signature · 1 line
2.23.0
#1 lore raw
Quoted 1 line · Joshua Watt

+RDEPENDS_${PN}_class-nativesdk = "patchelf"

Should that be nativesdk-patchelf? Should we just have it in RDEPENDS for all classes?

Ross

#2 lore raw
Quoted 4 lines · Ross Burton
Quoted 1 line · Joshua Watt

+RDEPENDS_${PN}_class-nativesdk = "patchelf"

Should that be nativesdk-patchelf?  Should we just have it in RDEPENDS for all classes?

I don't think it can be in -native due because that will create circular dependencies. The script explicitly looks for the patchelf-uninative to break the dependency for that case. I suppose it could also be for class-target... but I not sure how you would expect this script to work in that context :)

Quoted 2 lines

Ross

#3 lore raw
Quoted 1 line · Joshua Watt

I don't think it can be in -native due because that will create circular dependencies. The script explicitly looks for the patchelf-uninative to break the dependency for that case. I suppose it could also be for class-target... but I not sure how you would expect this script to work in that context

Yeah fair point. :)