Skip to contentSkip to conversation

xen/x86: add debug key for printing vulnerability settings

PATCH In review Juergen Gross 2 participants 2 messages Nov 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/x86: add debug key for printing vulnerability settings

The only way to obtain the current vulnerability settings of Xen is to look at the hypervisor boot messages. Often enough the buffer has wrapped making it impossible to retrieve that information.

Add a debug key 'b' (like "bugs") for that purpose.

---
This might want to go into 4.13

---
 xen/arch/x86/pv/domain.c |  2 +-
 xen/arch/x86/spec_ctrl.c | 58 ++++++++++++++++++++++++++----------------------
 2 files changed, 32 insertions(+), 28 deletions(-)
xen/arch/x86/pv/domain.c +1 -1
index 4b6f48dea2..3c930cffaa 100644
@@ -343,7 +343,7 @@ int pv_domain_initialise(struct domain *d)
     return rc;
 }
 
-bool __init xpti_pcid_enabled(void)
+bool xpti_pcid_enabled(void)
 {
     return use_invpcid && cpu_has_pcid &&
            (opt_pcid == PCID_ALL || opt_pcid == PCID_XPTI);
xen/arch/x86/spec_ctrl.c +31 -27

163 lines not on this page · raw message

Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 5 lines · Juergen Gross

The only way to obtain the current vulnerability settings of Xen is to look at the hypervisor boot messages. Often enough the buffer has wrapped making it impossible to retrieve that information.

Add a debug key 'b' (like "bugs") for that purpose.

As said elsewhere, I don't think a debug key is the way to go here. That's because
- using a debug key is generally deemed to render a system unsupported,
- we're not really talking about "debug" kind of information here (but rather generally useful one), and
- we should be rather careful with what we spend the remaining available characters for.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel