Skip to contentSkip to conversation

auto-t: give testEAP-TTLS-MSCHAPv2 a longer timeout

PATCH In review James Prestwood 2 participants 3 messages Nov 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 auto-t: give testEAP-TTLS-MSCHAPv2 a longer timeout

When logging is turned on this test consistently fails due to a timeout. Giving it a bit more time allows it to pass.

---
 autotests/testEAP-TTLS-MSCHAPv2/hw.conf | 1 +
 1 file changed, 1 insertion(+)
autotests/testEAP-TTLS-MSCHAPv2/hw.conf +1 -0
index 406e830d..3535d56a 100644
@@ -2,6 +2,7 @@
 num_radios=2
 tmpfs_extra_stuff=../misc/certs:eap-user-ttls-mschapv2.text
 start_iwd=False
+max_test_exec_interval_sec=45
 
 [HOSTAPD]
 rad0=ssidEAP-TTLS-MSCHAPv2.conf
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 auto-t: let testEAP-TTLS-MSCHAPv2 use HostapdCLI easier

This test made it past the initial refactor to use HostapdCLI with the 'config' parameter. This avoids the need to iterate the hostapd map in the actual test.

---
 autotests/testEAP-TTLS-MSCHAPv2/connection_test.py | 9 +--------
 autotests/testEAP-TTLS-MSCHAPv2/failure_test.py    | 9 +--------
 2 files changed, 2 insertions(+), 16 deletions(-)
autotests/testEAP-TTLS-MSCHAPv2/connection_test.py +1 -8
index fb073dc9..66cc440b 100644
@@ -11,18 +11,11 @@ from iwd import PSKAgent
 from iwd import NetworkType
 
 from hostapd import HostapdCLI
-from hostapd import hostapd_map
 
 class Test(unittest.TestCase):
 
     def validate_connection(self, wd):
-        hostapd = None
-
-        for hostapd_if in list(hostapd_map.values()):
-            hpd = HostapdCLI(hostapd_if)
-            if hpd.get_config_value('ssid') == 'ssidEAP-TTLS-MSCHAPv2':
-                hostapd = hpd
-                break
+        hostapd = HostapdCLI(config='ssidEAP-TTLS-MSCHAPv2.conf')
 
         self.assertIsNotNone(hostapd)
 
autotests/testEAP-TTLS-MSCHAPv2/failure_test.py +1 -8
index c91ce3c9..b4c3c003 100644
@@ -11,18 +11,11 @@ from iwd import PSKAgent
 from iwd import NetworkType
 
 from hostapd import HostapdCLI
-from hostapd import hostapd_map
 
 class Test(unittest.TestCase):
 
     def validate_connection(self, wd):
-        hostapd = None
-
-        for hostapd_if in list(hostapd_map.values()):
-            hpd = HostapdCLI(hostapd_if)
-            if hpd.get_config_value('ssid') == 'ssidEAP-TTLS-MSCHAPv2':
-                hostapd = hpd
-                break
+        hostapd = HostapdCLI(config='ssidEAP-TTLS-MSCHAPv2.conf')
 
         self.assertIsNotNone(hostapd)
 
Signature · 1 line
2.17.1
#2 lore raw
In reply to James Prestwood

Hi James,

Quoted 6 lines · James Prestwood

When logging is turned on this test consistently fails due to a timeout. Giving it a bit more time allows it to pass.

---
  autotests/testEAP-TTLS-MSCHAPv2/hw.conf | 1 +
  1 file changed, 1 insertion(+)

Both applied, thanks.

Regards,
-Denis