Skip to contentSkip to conversation

ASoC: rt5645: Fixed typo for buddy jack support.

PATCH Superseded Jacob Rasmussen 4 participants 4 messages Nov 14, 2019

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt5645: Fixed typo for buddy jack support.

Had a typo in e7cfd867fd98 that resulted in buddy jack support not being fixed.

Fixes e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")
---
 sound/soc/codecs/rt5645.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rt5645.c +1 -1
index 902ac98a3fbe..19662ee330d6 100644
@@ -3271,7 +3271,7 @@ static void rt5645_jack_detect_work(struct work_struct *work)
 				    report, SND_JACK_MICROPHONE);
 		return;
 	case 4:
-		val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x002;
+		val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x0020;
 		break;
 	default: /* read rt5645 jd1_1 status */
 		val = snd_soc_component_read32(rt5645->component, RT5645_INT_IRQ_ST) & 0x1000;
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog
#2 lore raw
Quoted 5 lines · Ross Zwisler
Quoted 3 lines · Jacob Rasmussen

Had a typo in e7cfd867fd98 that resulted in buddy jack support not being fixed.

Quoted 8 lines
Quoted 4 lines
Fixes e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")

Need to add your signed-off-by. With that added you can add:

maintainer
#3 lore raw
Quoted 11 lines · Jacob Rasmussen
Quoted 8 lines · Ross Zwisler
Quoted 7 lines · Jacob Rasmussen

Had a typo in e7cfd867fd98 that resulted in buddy jack support not being fixed.

Fixes e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")
Quoted 4 lines
Quoted 3 lines

Need to add your signed-off-by. With that added you can add:

I'd be more comfortable with this if you could repost with the signoff and the patch in one mail.