Skip to contentSkip to conversation

libxl: fix device model timeout in libxl__dm_resume()

PATCH In review Juergen Gross 2 participants 3 messages Nov 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl: fix device model timeout in libxl__dm_resume()

libxl__dm_resume() is using a wrong timeout for the start of the device model. Instead of 60 seconds the timeout is set to 60 milliseconds.

Fixes 6298f0eb8f4437 ("libxl: Re-introduce libxl__domain_resume")
---
 tools/libxl/libxl_dom_suspend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libxl/libxl_dom_suspend.c +1 -1
index 248dbc33e3..35ae337261 100644
@@ -515,7 +515,7 @@ void libxl__dm_resume(libxl__egc *egc,
     rc = libxl__ev_time_register_rel(dmrs->ao,
                                      &dmrs->time,
                                      dm_resume_timeout,
-                                     LIBXL_DEVICE_MODEL_START_TIMEOUT);
+                                     LIBXL_DEVICE_MODEL_START_TIMEOUT * 1000);
     if (rc) goto out;
 
     switch (libxl__device_model_version_running(gc, domid)) {
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Juergen Gross

libxl__dm_resume() is using a wrong timeout for the start of the device model. Instead of 60 seconds the timeout is set to 60 milliseconds.

Fixes 6298f0eb8f4437 ("libxl: Re-introduce libxl__domain_resume")

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 11 lines · Wei Liu
Quoted 7 lines · Juergen Gross

libxl__dm_resume() is using a wrong timeout for the start of the device model. Instead of 60 seconds the timeout is set to 60 milliseconds.

Fixes 6298f0eb8f4437 ("libxl: Re-introduce libxl__domain_resume")

And of course:

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel