Skip to contentSkip to conversation

trace/synthetic_events: increase SYNTH_FIELDS_MAX

PATCH In review Artem Bityutskiy 3 participants 3 messages Nov 15, 2019 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace/synthetic_events: increase SYNTH_FIELDS_MAX

From: Artem Bityutskiy <[email protected]>

Increase the maximum allowed count of synthetic event fields from 16 to 32 in order to allow for larger-than-usual events.

---
 kernel/trace/trace_events_hist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_events_hist.c +1 -1
index 7482a1466ebf..f49d1a36d3ae 100644
@@ -23,7 +23,7 @@
 #include "trace_dynevent.h"
 
 #define SYNTH_SYSTEM		"synthetic"
-#define SYNTH_FIELDS_MAX	16
+#define SYNTH_FIELDS_MAX	32
 
 #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */
 
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 4 lines · On Fri, 15 Nov 2019 11:17:30 +0200 Artem Bityutskiy <[email protected]> wrote:

From: Artem Bityutskiy <[email protected]>

Increase the maximum allowed count of synthetic event fields from 16 to 32 in order to allow for larger-than-usual events.

I'm fine with this, Tom are you OK with it?

-- Steve

Quoted 19 lines
---
 kernel/trace/trace_events_hist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_events_hist.c +1 -1
index 7482a1466ebf..f49d1a36d3ae 100644
@@ -23,7 +23,7 @@
 #include "trace_dynevent.h"
 
 #define SYNTH_SYSTEM		"synthetic"
-#define SYNTH_FIELDS_MAX	16
+#define SYNTH_FIELDS_MAX	32
 
 #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */
 
Reviewed-by
#2 lore raw

Hi Steve and Artem,

Quoted 9 lines · Steven Rostedt
Quoted 4 lines · On Fri, 15 Nov 2019 11:17:30 +0200 Artem Bityutskiy <[email protected]> wrote:

From: Artem Bityutskiy <[email protected]>

Increase the maximum allowed count of synthetic event fields from 16 to 32 in order to allow for larger-than-usual events.

I'm fine with this, Tom are you OK with it?

Yeah, looks good to me. Thanks for the patch, Artem.

Tom

Quoted 23 lines

-- Steve

Quoted 19 lines
---
  kernel/trace/trace_events_hist.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_events_hist.c +1 -1
index 7482a1466ebf..f49d1a36d3ae 100644
@@ -23,7 +23,7 @@
  #include "trace_dynevent.h"
 
  #define SYNTH_SYSTEM		"synthetic"
-#define SYNTH_FIELDS_MAX	16
+#define SYNTH_FIELDS_MAX	32
 
  #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */