lpfc: use hdwq assigned cpu for allocation
Subsystems (2)
PATCH 1/1 lpfc: use hdwq assigned cpu for allocation
Looking at the recent conversion from smp_processor_id() to raw_smp_processor_id(), realized that the allocation should be based on the cpu the hdwq is bound to, not the executing cpu.
Revise to pull cpu number from the hdwq
Fixes 765ab6cdac3b ("scsi: lpfc: Fix a kernel warning triggered by lpfc_get_sgl_per_hdwq()")
Signed-off-by Dick Kennedy <[email protected]>
Signed-off-by James Smart <[email protected]>
--- drivers/scsi/lpfc/lpfc_sli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_sli.c +2 -2
@@ -20668,7 +20668,7 @@ lpfc_get_sgl_per_hdwq(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_buf)/* allocate more */ spin_unlock_irqrestore (&hdwq->hdwq_lock, iflags); tmp =kmalloc_node (sizeof (*tmp),GFP_ATOMIC , -cpu_to_node (raw_smp_processor_id ())); +cpu_to_node (hdwq->io_wq->chann));if (!tmp) {lpfc_printf_log (phba,KERN_INFO ,LOG_SLI , "8353 error kmalloc memory for HDWQ "
@@ -20811,7 +20811,7 @@ lpfc_get_cmd_rsp_buf_per_hdwq(struct lpfc_hba *phba,/* allocate more */ spin_unlock_irqrestore (&hdwq->hdwq_lock, iflags); tmp =kmalloc_node (sizeof (*tmp),GFP_ATOMIC , -cpu_to_node (raw_smp_processor_id ())); +cpu_to_node (hdwq->io_wq->chann));if (!tmp) {lpfc_printf_log (phba,KERN_INFO ,LOG_SLI , "8355 error kmalloc memory for HDWQ "
Signature · 1 line
2.13.7
Martin K. Petersen
AppliedJames,
Quoted 3 lines
Looking at the recent conversion from
smp_processor_id()toraw_smp_processor_id(), realized that the allocation should be based on the cpu the hdwq is bound to, not the executing cpu.
Applied to 5.5/scsi-queue, thank you!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering