Skip to contentSkip to conversation

drm/v3d: add missed pm_runtime_disable

PATCH New Chuhong Yuan 1 participant 1 message Nov 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/v3d: add missed pm_runtime_disable

The driver forgets to call pm_runtime_disable in probe failure and remove.
Add the missed calls to fix it.

---
 drivers/gpu/drm/v3d/v3d_drv.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/v3d/v3d_drv.c +3 -0
index 3506ae2723ae..e109bb8cd67d 100644
@@ -333,6 +333,7 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
 dev_destroy:
 	drm_dev_put(drm);
 dma_free:
+	pm_runtime_disable(dev);
 	dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
 dev_free:
 	kfree(v3d);
@@ -350,6 +351,8 @@ static int v3d_platform_drm_remove(struct platform_device *pdev)
 
 	drm_dev_put(drm);
 
+	pm_runtime_disable(v3d->dev);
+
 	dma_free_wc(v3d->dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
 
 	return 0;
Signature · 1 line
2.24.0