Skip to contentSkip to conversation

ASoC: wm5100: add missed pm_runtime_disable

PATCH Superseded Chuhong Yuan 3 participants 3 messages Nov 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wm5100: add missed pm_runtime_disable

The driver forgets to call pm_runtime_disable in remove and probe failure.
Add the calls to fix it.

---
 sound/soc/codecs/wm5100.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/wm5100.c +2 -0
index 4af0e519e623..91cc63c5a51f 100644
@@ -2617,6 +2617,7 @@ static int wm5100_i2c_probe(struct i2c_client *i2c,
 	return ret;
 
 err_reset:
+	pm_runtime_disable(&i2c->dev);
 	if (i2c->irq)
 		free_irq(i2c->irq, wm5100);
 	wm5100_free_gpio(i2c);
@@ -2640,6 +2641,7 @@ static int wm5100_i2c_remove(struct i2c_client *i2c)
 {
 	struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c);
 
+	pm_runtime_disable(&i2c->dev);
 	if (i2c->irq)
 		free_irq(i2c->irq, wm5100);
 	wm5100_free_gpio(i2c);
Signature · 1 line
2.24.0
maintainer
#2 lore raw

[alsa-devel] Applied "ASoC: wm5100: add missed pm_runtime_disable" to the asoc tree

In reply to Chuhong Yuan

The patch

ASoC: wm5100: add missed pm_runtime_disable

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

From c194a3615baddc4f32133c163036d9bc284d94cc Mon Sep 17 00:00:00 2001
From: Chuhong Yuan <[email protected]>
Date: Mon, 18 Nov 2019 15:37:07 +0800
Subject: [PATCH] ASoC: wm5100: add missed pm_runtime_disable

The driver forgets to call pm_runtime_disable in remove and probe failure.
Add the calls to fix it.

---
 sound/soc/codecs/wm5100.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/wm5100.c +2 -0
index 4af0e519e623..91cc63c5a51f 100644
@@ -2617,6 +2617,7 @@ static int wm5100_i2c_probe(struct i2c_client *i2c,
 	return ret;
 
 err_reset:
+	pm_runtime_disable(&i2c->dev);
 	if (i2c->irq)
 		free_irq(i2c->irq, wm5100);
 	wm5100_free_gpio(i2c);
@@ -2640,6 +2641,7 @@ static int wm5100_i2c_remove(struct i2c_client *i2c)
 {
 	struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c);
 
+	pm_runtime_disable(&i2c->dev);
 	if (i2c->irq)
 		free_irq(i2c->irq, wm5100);
 	wm5100_free_gpio(i2c);
Signature · 6 lines
2.20.1

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel