Skip to contentSkip to conversation

open_posix/pi_test*: Remove all tests

PATCH New Joerg Vehlow 2 participants 2 messages Nov 18, 2019 – Nov 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 open_posix/pi_test*: Remove all tests

From: Joerg Vehlow <[email protected]>

There are several reasons, why these tests should be removed. Most important: They do not really test anything. The result of these tests has to be inspected manually do check, if the behavior is correct, but the manual inspection using the given tools is not possible, because these tests were written for systems much slower than todays systems. The problems are described in more detail in
https://github.com/linux-test-project/ltp/issues/584

---
 .../functional/threads/README                 |   5 -
 .../functional/threads/include/pitest.h       |  85 ----
 .../functional/threads/include/test.h         |  26 --
 .../functional/threads/pi_test/CFLAGS         |   1 -
 .../functional/threads/pi_test/LDLIBS         |   1 -
 .../functional/threads/pi_test/README         |  98 -----
 .../functional/threads/pi_test/do-plot        |  71 ----
 .../functional/threads/pi_test/pitest-1.c     | 327 ---------------
 .../functional/threads/pi_test/pitest-2.c     | 361 -----------------
 .../functional/threads/pi_test/pitest-3.c     | 373 ------------------
 .../functional/threads/pi_test/pitest-4.c     | 337 ----------------
 .../functional/threads/pi_test/pitest-5.c     | 345 ----------------
 .../functional/threads/pi_test/pitest-6.c     | 328 ---------------
 .../functional/threads/tools/watchdogtimer.sh |  17 -
 14 files changed, 2375 deletions(-)
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/include/pitest.h
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/include/test.h
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/CFLAGS
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/LDLIBS
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/README
 delete mode 100755 testcases/open_posix_testsuite/functional/threads/pi_test/do-plot
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/pitest-1.c
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/pitest-2.c
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/pitest-3.c
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/pitest-4.c
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/pitest-5.c
 delete mode 100644 testcases/open_posix_testsuite/functional/threads/pi_test/pitest-6.c
 delete mode 100755 testcases/open_posix_testsuite/functional/threads/tools/watchdogtimer.sh
testcases/open_posix_testsuite/functional/threads/README +0 -5
index af99bad73..9490caff3 100644
@@ -11,8 +11,3 @@ Currently it contains:
 
 condvar - Test cases by Abhijeet Bisain. Testing pthread_cond_wait()
 scheduling behavior when threads has realtime priority.
-
-pi_test - Test Priority Inheritence.
-
-robust_test - This suite is not proper to exist in PTS, since
-the work of adding Robust Mutex to POSIX is still ongoing.
testcases/open_posix_testsuite/functional/threads/include/pitest.h deleted +0 -85

85 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/include/test.h deleted +0 -26
deleted file mode 100644
index 1ebb64a72..000000000
@@ -1,26 +0,0 @@
-
-/*
- *  Copyright (c) 2003, Intel Corporation. All rights reserved.
- *  Created by:  crystal.xiong REMOVE-THIS AT intel DOT com
- *  This file is licensed under the GPL license.  For the full content
- *  of this license, see the COPYING file at the top level of this
- *  source tree.
- */
-
-#include <errno.h>
-#include <string.h>
-
-#ifndef EOWNERDEAD
-#define EOWNERDEAD	ESRCH
-#endif
-#ifndef ENOTRECOVERABLE
-#define ENOTRECOVERABLE	EBADR
-#endif
-
-#define PASS	0
-#define FAIL	1
-#define UNRESOLVED 2
-
-#define DPRINTF(a, x, args...)     fprintf(a, x , ##args);
-#define EPRINTF(x, args...)	fprintf(stderr, "%s: %d: " x "\n",__FILE__, __LINE__, ##args);
-
testcases/open_posix_testsuite/functional/threads/pi_test/CFLAGS deleted +0 -1
deleted file mode 100644
index a1e2b5ca4..000000000
@@ -1 +0,0 @@
--I"$(srcdir)/../include"
testcases/open_posix_testsuite/functional/threads/pi_test/LDLIBS deleted +0 -1
deleted file mode 100644
index 1d2c98f43..000000000
@@ -1 +0,0 @@
--lpthread
testcases/open_posix_testsuite/functional/threads/pi_test/README deleted +0 -98

98 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/do-plot deleted +0 -71

71 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/pitest-1.c deleted +0 -327

327 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/pitest-2.c deleted +0 -361

361 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/pitest-3.c deleted +0 -373

373 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/pitest-4.c deleted +0 -337

337 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/pitest-5.c deleted +0 -345

345 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/pi_test/pitest-6.c deleted +0 -328

328 lines not on this page · raw message

testcases/open_posix_testsuite/functional/threads/tools/watchdogtimer.sh deleted +0 -17
deleted file mode 100755
index af5790163..000000000
@@ -1,17 +0,0 @@
-#!/bin/bash
-PRIORITY=20
-# PINUM stands for the test cases number of pi test
-PINUM=6
-num=0
-chrt -p -f $PRIORITY $$
-TIMEOUT=600
-echo "Start watchdogtimer script..."
-echo "wait 10 minutes, if pitest hangs, stop the case execution"
-while [ $num -lt $PINUM ]
-do
-sleep $TIMEOUT
-killall -9 -q pitest*
-echo "Timeout, kill pi test case"
-num=`expr $num + 1`
-done
-
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 open_posix/pi_test*: Remove all tests

Hi Joerg,

Quoted 9 lines

From: Joerg Vehlow <[email protected]>

There are several reasons, why these tests should be removed. Most important: They do not really test anything. The result of these tests has to be inspected manually do check, if the behavior is correct, but the manual inspection using the given tools is not possible, because these tests were written for systems much slower than todays systems. The problems are described in more detail in
https://github.com/linux-test-project/ltp/issues/584

Thanks, merged!

Kind regards,
Petr