ath11k: add wmi helper for turning STA PS on/off
PATCH 1/2 ath11k: add wmi helper for turning STA PS on/off
Add a WMI call helper to set the powersave mode of a STA interface.
--- drivers/net/wireless/ath/ath11k/wmi.c | 30 +++++++++++++++++++++++++++ drivers/net/wireless/ath/ath11k/wmi.h | 7 +++++++ 2 files changed, 37 insertions(+)
drivers/net/wireless/ath/ath11k/wmi.c +30 -0
@@ -1178,6 +1178,36 @@ int ath11k_wmi_pdev_set_param(struct ath11k *ar, u32 param_id,return ret; } +int ath11k_wmi_pdev_set_ps_mode (struct ath11k *ar,int vdev_id,u32 enable) +{ +struct ath11k_pdev_wmi *wmi = ar->wmi; +struct wmi_pdev_set_ps_mode_cmd *cmd; +struct sk_buff *skb; +int ret; + + skb =ath11k_wmi_alloc_skb (wmi->wmi_sc,sizeof (*cmd)); +if (!skb) +return -ENOMEM ; + + cmd = (struct wmi_pdev_set_ps_mode_cmd *)skb->data; + cmd->tlv_header =FIELD_PREP (WMI_TLV_TAG ,WMI_TAG_STA_POWERSAVE_MODE_CMD ) | +FIELD_PREP (WMI_TLV_LEN ,sizeof (*cmd) -TLV_HDR_SIZE ); + cmd->vdev_id = vdev_id; + cmd->sta_ps_mode = enable; + + ret =ath11k_wmi_cmd_send (wmi, skb,WMI_STA_POWERSAVE_MODE_CMDID ); +if (ret) { +ath11k_warn (ar->ab,"failed to send WMI_PDEV_SET_PARAM cmd\n" ); +dev_kfree_skb (skb); + } + +ath11k_dbg (ar->ab,ATH11K_DBG_WMI , +"WMI vdev set psmode %d vdev id %d\n" , + enable, vdev_id); + +return ret; +} +int ath11k_wmi_pdev_suspend (struct ath11k *ar,u32 suspend_opt,u32 pdev_id) {
drivers/net/wireless/ath/ath11k/wmi.h +7 -0
@@ -2827,6 +2827,12 @@ struct wmi_pdev_set_param_cmd {u32 param_value; } __packed; +struct wmi_pdev_set_ps_mode_cmd { +u32 tlv_header; +u32 vdev_id; +u32 sta_ps_mode; +} __packed; +struct wmi_pdev_suspend_cmd {u32 tlv_header;u32 pdev_id;
@@ -4682,6 +4688,7 @@ int ath11k_wmi_set_peer_param(struct ath11k *ar, const u8 *peer_addr, u32 vdev_id, u32 param_id, u32 param_val);int ath11k_wmi_pdev_set_param (struct ath11k *ar,u32 param_id,u32 param_value,u8 pdev_id); +int ath11k_wmi_pdev_set_ps_mode (struct ath11k *ar,int vdev_id,u32 enable);int ath11k_wmi_wait_for_unified_ready (struct ath11k_base *ab);int ath11k_wmi_cmd_init (struct ath11k_base *ab);int ath11k_wmi_wait_for_service_ready (struct ath11k_base *ab);
Signature · 7 lines
2.20.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
PATCH 2/2 ath11k: disable PS for STA interfaces by default upon bringup
After applying this setting the TX performance issue of STA interfaces is gone and we can see TX performance go up to ~900mbit on HE80.
--- drivers/net/wireless/ath/ath11k/mac.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/wireless/ath/ath11k/mac.c +6 -0
@@ -4074,6 +4074,12 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw, goto err_peer_del; } + ret =ath11k_wmi_pdev_set_ps_mode (ar, arvif->vdev_id, false); +if (ret) { +ath11k_warn (ar->ab,"failed to disable vdev %d ps mode: %d\n" , + arvif->vdev_id, ret); + goto err_peer_del; + }break ;default :break ;
Signature · 7 lines
2.20.1 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 3 lines · John Crispin
Add a WMI call helper to set the powersave mode of a STA interface.
Signed-off-by John Crispin <[email protected]>
Failed to apply, please resend.
error: patch failed: drivers/net/wireless/ath/ath11k/mac.c:4074
error: drivers/net/wireless/ath/ath11k/mac.c: patch does not apply stg import: Diff does not apply cleanly
2 patches set to Changes Requested.
11249515 [1/2] ath11k: add wmi helper for turning STA PS on/off 11249513 [2/2] ath11k: disable PS for STA interfaces by default upon bringup
Signature · 9 lines
https://patchwork.kernel.org/patch/11249515/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k