Skip to contentSkip to conversation

brcmfmac: remove monitor interface when detaching

PATCH In review Rafał Miłecki 2 participants 2 messages Nov 18, 2019 – Nov 20, 2019 Broadcom BRCM80211 IEEE802.11 wireless drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmfmac: remove monitor interface when detaching

From: Rafał Miłecki <[email protected]>

This fixes a minor WARNING in the cfg80211:

[  130.658034] ------------[ cut here ]------------
[  130.662805] WARNING: CPU: 1 PID: 610 at net/wireless/core.c:954 wiphy_unregister+0xb4/0x198 [cfg80211]

---
Kalle: it doesn't seem critical enough for stable but would be nice to

       have for 5.5.
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +5 -0
index 406b367c284c..85cf96461dde 100644
@@ -1350,6 +1350,11 @@ void brcmf_detach(struct device *dev)
 	brcmf_fweh_detach(drvr);
 	brcmf_proto_detach(drvr);
 
+	if (drvr->mon_if) {
+		brcmf_net_detach(drvr->mon_if->ndev, false);
+		drvr->mon_if = NULL;
+	}
+
 	/* make sure primary interface removed last */
 	for (i = BRCMF_MAX_IFS - 1; i > -1; i--) {
 		if (drvr->iflist[i])
Signature · 1 line
2.21.0
#1 lore raw
Quoted 7 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This fixes a minor WARNING in the cfg80211:

[  130.658034] ------------[ cut here ]------------
[  130.662805] WARNING: CPU: 1 PID: 610 at net/wireless/core.c:954 wiphy_unregister+0xb4/0x198 [cfg80211]

Patch applied to wireless-drivers-next.git, thanks.

4f61563da075 brcmfmac: remove monitor interface when detaching

Signature · 3 lines
https://patchwork.kernel.org/patch/11249727/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches