drm/mcde: dsi: Fix invalid pointer dereference if panel cannot be found
Subsystems (3)
PATCH 1/1 drm/mcde: dsi: Fix invalid pointer dereference if panel cannot be found
The "panel" pointer is not reset to NULL if of_drm_find_panel() returns an error. Therefore we later assume that a panel was found, and try to dereference the error pointer, resulting in:
mcde-dsi a0351000.dsi: failed to find panel try bridge (4294966779)
Unable to handle kernel paging request at virtual address fffffe03
PC is at drm_panel_bridge_add.part.0+0x10/0x5c
LR is at mcde_dsi_bind+0x120/0x464
...Reset "panel" to NULL to avoid this problem.
Also change the format string of the error to %ld to print the negative errors correctly. The crash above then becomes:
mcde-dsi a0351000.dsi: failed to find panel try bridge (-517)
mcde-dsi a0351000.dsi: no panel or bridge
...--- drivers/gpu/drm/mcde/mcde_dsi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/mcde/mcde_dsi.c +4 -2
@@ -924,11 +924,13 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,for_each_available_child_of_node (dev->of_node, child) { panel =of_drm_find_panel (child);if (IS_ERR (panel)) { -dev_err (dev,"failed to find panel try bridge (%lu)\n" , +dev_err (dev,"failed to find panel try bridge (%ld)\n" ,PTR_ERR (panel)); + panel =NULL ; + bridge =of_drm_find_bridge (child);if (IS_ERR (bridge)) { -dev_err (dev,"failed to find bridge (%lu)\n" , +dev_err (dev,"failed to find bridge (%ld)\n" ,PTR_ERR (bridge));return PTR_ERR (bridge); }
Signature · 6 lines
2.23.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 14 lines · Stephan Gerhold
The "panel" pointer is not reset to NULL if
of_drm_find_panel()returns an error. Therefore we later assume that a panel was found, and try to dereference the error pointer, resulting in:mcde-dsi a0351000.dsi: failed to find panel try bridge (4294966779) Unable to handle kernel paging request at virtual address fffffe03 PC is at drm_panel_bridge_add.part.0+0x10/0x5c LR is at mcde_dsi_bind+0x120/0x464 ...Reset "panel" to NULL to avoid this problem.
Also change the format string of the error to %ld to print the negative errors correctly. The crash above then becomes:
Quoted 6 lines
mcde-dsi a0351000.dsi: failed to find panel try bridge (-517) mcde-dsi a0351000.dsi: no panel or bridge ...Fixes 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")Signed-off-by Stephan Gerhold <[email protected]>
Patch applied and pushed to drm-misc-fixes, thanks!
Yours,
Linus Walleij