Skip to contentSkip to conversation

add new DRM_DEV_WARN macro

PATCH In review Wambui Karuga 4 participants 5 messages Nov 14, 2019 – Nov 18, 2019 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

cover add new DRM_DEV_WARN macro

This adds a new DRM_DEV_WARN helper macro for warnings log output that include device pointers. It also includes the use of the DRM_DEV_WARN macro in drm/rockchip to replace dev_warn.

Wambui Karuga (2):
drm/print: add DRM_DEV_WARN macro drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Wambui Karuga

This adds a new DRM_DEV_WARN helper macro for warnings log output that include device pointers. It also includes the use of the DRM_DEV_WARN macro in drm/rockchip to replace dev_warn.

I'm trying to solicit new struct drm_device based logging macros, and starting to convert to those. [1]

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com

Quoted 8 lines

Wambui Karuga (2):
drm/print: add DRM_DEV_WARN macro drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
Quoted 8 lines · Jani Nikula
Quoted 3 lines · Wambui Karuga

This adds a new DRM_DEV_WARN helper macro for warnings log output that include device pointers. It also includes the use of the DRM_DEV_WARN macro in drm/rockchip to replace dev_warn.

I'm trying to solicit new struct drm_device based logging macros, and starting to convert to those. [1]

This sounds good to me, I'd much prefer the non-caps versions of these functions. So let's wait for those to bubble up and then convert rockchip to drm_dev_*

Sean

Quoted 20 lines

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com

Quoted 8 lines

Wambui Karuga (2):
drm/print: add DRM_DEV_WARN macro drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
#3 lore raw
Quoted 6 lines · Sean Paul
Quoted 5 lines · Jani Nikula
Quoted 3 lines · Wambui Karuga

This adds a new DRM_DEV_WARN helper macro for warnings log output that include device pointers. It also includes the use of the DRM_DEV_WARN macro in drm/rockchip to replace dev_warn.

Quoted 7 lines
Quoted 3 lines

I'm trying to solicit new struct drm_device based logging macros, and starting to convert to those. [1]

This sounds good to me, I'd much prefer the non-caps versions of these functions. So let's wait for those to bubble up and then convert rockchip to drm_dev_*

Care to ack Jani's patch directly, so this is all formal?

Jani, can you pls also add a todo.rst patch on top to adjust the relevant item to the new color choice?

Wambui, I guess slight change of plans, it happens ...

Cheers, Daniel

Quoted 26 lines

Sean

Quoted 14 lines

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com

Quoted 5 lines

Wambui Karuga (2):
drm/print: add DRM_DEV_WARN macro drm/rockchip: use DRM_DEV_WARN macro in debug output

Quoted 6 lines
Quoted 3 lines
 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

--
Jani Nikula, Intel Open Source Graphics Center

--
Sean Paul, Software Engineer, Google / Chromium OS

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw
Quoted 11 lines · Daniel Vetter
Quoted 10 lines · Sean Paul
Quoted 8 lines · Jani Nikula
Quoted 3 lines · Wambui Karuga

This adds a new DRM_DEV_WARN helper macro for warnings log output that include device pointers. It also includes the use of the DRM_DEV_WARN macro in drm/rockchip to replace dev_warn.

I'm trying to solicit new struct drm_device based logging macros, and starting to convert to those. [1]

Quoted 5 lines
Quoted 3 lines

This sounds good to me, I'd much prefer the non-caps versions of these functions. So let's wait for those to bubble up and then convert rockchip to drm_dev_*

Care to ack Jani's patch directly, so this is all formal?

I just time traveled to last week and acked the whole series :)

Sean

Quoted 41 lines

Jani, can you pls also add a todo.rst patch on top to adjust the relevant item to the new color choice?

Wambui, I guess slight change of plans, it happens ...

Cheers, Daniel

Quoted 26 lines

Sean

Quoted 14 lines

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com

Quoted 5 lines

Wambui Karuga (2):
drm/print: add DRM_DEV_WARN macro drm/rockchip: use DRM_DEV_WARN macro in debug output

Quoted 6 lines
Quoted 3 lines
 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

--
Jani Nikula, Intel Open Source Graphics Center

--
Sean Paul, Software Engineer, Google / Chromium OS

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel