Skip to contentSkip to conversation

gve: fix dma sync bug where not all pages synced

PATCH Superseded Adi Suresh 2 participants 3 messages Nov 18, 2019 – Nov 19, 2019

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Adi Suresh

author
#0 lore raw

PATCH v2 1/1 gve: fix dma sync bug where not all pages synced

The previous commit had a bug where the last page in the memory range could not be synced. This change fixes the behavior so that all the required pages are synced.

Fixes 9cfeeb5 ("gve: Fixes DMA synchronization")

---
Changes in v2:
- Added Fixes tag and reference commit hash of previous commit
- Moved variable declaration to top of method

 drivers/net/ethernet/google/gve/gve_tx.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/net/ethernet/google/gve/gve_tx.c +5 -4
index 0a9a7ee2a866..f4889431f9b7 100644
@@ -393,12 +393,13 @@ static void gve_tx_fill_seg_desc(union gve_tx_desc *seg_desc,
 static void gve_dma_sync_for_device(struct device *dev, dma_addr_t *page_buses,
 				    u64 iov_offset, u64 iov_len)
 {
+	u64 last_page = (iov_offset + iov_len - 1) / PAGE_SIZE;
+	u64 first_page = iov_offset / PAGE_SIZE;
 	dma_addr_t dma;
-	u64 addr;
+	u64 page;
 
-	for (addr = iov_offset; addr < iov_offset + iov_len;
-	     addr += PAGE_SIZE) {
-		dma = page_buses[addr / PAGE_SIZE];
+	for (page = first_page; page <= last_page; page++) {
+		dma = page_buses[page];
 		dma_sync_single_for_device(dev, dma, PAGE_SIZE, DMA_TO_DEVICE);
 	}
 }
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog
maintainer
#1 lore raw

From: Adi Suresh <[email protected]>
Date: Mon, 18 Nov 2019 15:42:40 -0800

Quoted 5 lines

The previous commit had a bug where the last page in the memory range could not be synced. This change fixes the behavior so that all the required pages are synced.

Fixes 9cfeeb5 ("gve: Fixes DMA synchronization")

12 digits of SHA1 hash signifigance in Fixes: tags please.

Thank you.

author
#2 lore raw

Addressed in v3

Quoted 14 lines · David Miller

From: Adi Suresh <[email protected]>
Date: Mon, 18 Nov 2019 15:42:40 -0800

Quoted 5 lines

The previous commit had a bug where the last page in the memory range could not be synced. This change fixes the behavior so that all the required pages are synced.

Fixes 9cfeeb5 ("gve: Fixes DMA synchronization")

12 digits of SHA1 hash signifigance in Fixes: tags please.

Thank you.