Skip to contentSkip to conversation

mm: kconfig: make Transparent Hugepage Support sysfs defaults to match the documentation

PATCH In review Rafael Aquini 2 participants 3 messages Nov 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: kconfig: make Transparent Hugepage Support sysfs defaults to match the documentation

Documentation/admin-guide/mm/transhuge.rst (originally in Documentation/vm/transhuge.txt) states that TRANSPARENT_HUGEPAGE_MADVISE is the default option for THP config:

"
madvise
will enter direct reclaim like ``always`` but only for regions that are have used madvise(MADV_HUGEPAGE). This is the default behaviour.
"

This patch changes mm/Kconfig to reflect that fact, accordingly. Besides keeping consistency between documentation and the code behavior, other reasons to perform this minor adjustment are noted at:
https://bugzilla.redhat.com/show_bug.cgi?id=1772133

---
 mm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/Kconfig +1 -1
index a5dae9a7eb51..c12a559aa1e5 100644
@@ -385,7 +385,7 @@ config TRANSPARENT_HUGEPAGE
 choice
 	prompt "Transparent Hugepage Support sysfs defaults"
 	depends on TRANSPARENT_HUGEPAGE
-	default TRANSPARENT_HUGEPAGE_ALWAYS
+	default TRANSPARENT_HUGEPAGE_MADVISE
 	help
 	  Selects the sysfs defaults for Transparent Hugepage Support.
 
Signature · 1 line
2.17.2
#1 lore raw
Quoted 11 lines · Rafael Aquini

Documentation/admin-guide/mm/transhuge.rst (originally in Documentation/vm/transhuge.txt) states that TRANSPARENT_HUGEPAGE_MADVISE is the default option for THP config:

"
madvise
will enter direct reclaim like ``always`` but only for regions that are have used madvise(MADV_HUGEPAGE). This is the default behaviour.
"

This patch changes mm/Kconfig to reflect that fact, accordingly.

No. You've read it incorrectly.

The documentation describes default behaviour wrt defragmentaton ("defrag" file), not page fault ("enabled" file). We don't have any Kconfig option to set default behaviour for "defrag".

Quoted 26 lines

Besides keeping consistency between documentation and the code behavior, other reasons to perform this minor adjustment are noted at:
https://bugzilla.redhat.com/show_bug.cgi?id=1772133

---
 mm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/Kconfig +1 -1
index a5dae9a7eb51..c12a559aa1e5 100644
@@ -385,7 +385,7 @@ config TRANSPARENT_HUGEPAGE
 choice
 	prompt "Transparent Hugepage Support sysfs defaults"
 	depends on TRANSPARENT_HUGEPAGE
-	default TRANSPARENT_HUGEPAGE_ALWAYS
+	default TRANSPARENT_HUGEPAGE_MADVISE
 	help
 	  Selects the sysfs defaults for Transparent Hugepage Support.
 
Signature · 1 line
2.17.2
Signature · 1 line
 Kirill A. Shutemov
#2 lore raw
Quoted 11 lines · Kirill A. Shutemov
Quoted 10 lines · Rafael Aquini

Documentation/admin-guide/mm/transhuge.rst (originally in Documentation/vm/transhuge.txt) states that TRANSPARENT_HUGEPAGE_MADVISE is the default option for THP config:

"
madvise
will enter direct reclaim like ``always`` but only for regions that are have used madvise(MADV_HUGEPAGE). This is the default behaviour.
"

Quoted 4 lines
Quoted 1 line

This patch changes mm/Kconfig to reflect that fact, accordingly.

No. You've read it incorrectly.

Fair enough.

I'll reform the log message then, and repost.

Quoted 34 lines

The documentation describes default behaviour wrt defragmentaton ("defrag" file), not page fault ("enabled" file). We don't have any Kconfig option to set default behaviour for "defrag".

Quoted 26 lines

Besides keeping consistency between documentation and the code behavior, other reasons to perform this minor adjustment are noted at:
https://bugzilla.redhat.com/show_bug.cgi?id=1772133

---
 mm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/Kconfig +1 -1
index a5dae9a7eb51..c12a559aa1e5 100644
@@ -385,7 +385,7 @@ config TRANSPARENT_HUGEPAGE
 choice
 	prompt "Transparent Hugepage Support sysfs defaults"
 	depends on TRANSPARENT_HUGEPAGE
-	default TRANSPARENT_HUGEPAGE_ALWAYS
+	default TRANSPARENT_HUGEPAGE_MADVISE
 	help
 	  Selects the sysfs defaults for Transparent Hugepage Support.
 
Signature · 1 line
2.17.2
Signature · 1 line
 Kirill A. Shutemov