Skip to contentSkip to conversation

drm/fb-cma-helpers: Fix include issue

PATCH In review Benjamin Gaignard 3 participants 5 messages Nov 19, 2019 – Jan 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/fb-cma-helpers: Fix include issue

Exported functions prototypes are missing in drm_fb_cma_helper.c Include drm_fb_cma_helper to fix that issue.

---
 drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
 include/drm/drm_fb_cma_helper.h     | 2 ++
 2 files changed, 3 insertions(+)
drivers/gpu/drm/drm_fb_cma_helper.c +1 -0
index c0b0f603af63..9801c0333eca 100644
@@ -9,6 +9,7 @@
  *  Copyright (C) 2012 Red Hat
  */
 
+#include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_cma_helper.h>
include/drm/drm_fb_cma_helper.h +2 -0
index 4becb09975a4..795aea1d0a25 100644
@@ -2,6 +2,8 @@
 #ifndef __DRM_FB_CMA_HELPER_H__
 #define __DRM_FB_CMA_HELPER_H__
 
+#include <linux/types.h>
+
 struct drm_framebuffer;
 struct drm_plane_state;
 
Signature · 1 line
2.15.0
#1 lore raw
Quoted 4 lines · Benjamin Gaignard

Exported functions prototypes are missing in drm_fb_cma_helper.c Include drm_fb_cma_helper to fix that issue.

Gentle ping to reviewers.
Thanks,
Benjamin

Quoted 38 lines
---
 drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
 include/drm/drm_fb_cma_helper.h     | 2 ++
 2 files changed, 3 insertions(+)
drivers/gpu/drm/drm_fb_cma_helper.c +1 -0
index c0b0f603af63..9801c0333eca 100644
@@ -9,6 +9,7 @@
  *  Copyright (C) 2012 Red Hat
  */
 
+#include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_cma_helper.h>
include/drm/drm_fb_cma_helper.h +2 -1
index 4becb09975a4..795aea1d0a25 100644
@@ -2,6 +2,8 @@
 #ifndef __DRM_FB_CMA_HELPER_H__
 #define __DRM_FB_CMA_HELPER_H__
 
+#include <linux/types.h>
+
 struct drm_framebuffer;
 struct drm_plane_state;
 
--

2.15.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 8 lines · Benjamin Gaignard
Quoted 3 lines · Benjamin Gaignard

Exported functions prototypes are missing in drm_fb_cma_helper.c Include drm_fb_cma_helper to fix that issue.

Gentle ping to reviewers.
Thanks,
Benjamin

I know that removing warnings is not a sexy task, but reviewers are welcome.

Thanks,

Benjamin

Quoted 39 lines
Quoted 39 lines
---
  drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
  include/drm/drm_fb_cma_helper.h     | 2 ++
  2 files changed, 3 insertions(+)
drivers/gpu/drm/drm_fb_cma_helper.c +1 -0
index c0b0f603af63..9801c0333eca 100644
@@ -9,6 +9,7 @@
   *  Copyright (C) 2012 Red Hat
   */
 
+#include <drm/drm_fb_cma_helper.h>
  #include <drm/drm_fourcc.h>
  #include <drm/drm_framebuffer.h>
  #include <drm/drm_gem_cma_helper.h>
include/drm/drm_fb_cma_helper.h +2 -1
index 4becb09975a4..795aea1d0a25 100644
@@ -2,6 +2,8 @@
  #ifndef __DRM_FB_CMA_HELPER_H__
  #define __DRM_FB_CMA_HELPER_H__
 
+#include <linux/types.h>
+
  struct drm_framebuffer;
  struct drm_plane_state;
 
--

2.15.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 5 lines · Benjamin GAIGNARD
Quoted 2 lines · Benjamin Gaignard

Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard
<[email protected]> a écrit :

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Exported functions prototypes are missing in drm_fb_cma_helper.c Include drm_fb_cma_helper to fix that issue.

Gentle ping to reviewers.
Thanks,
Benjamin

I know that removing warnings is not a sexy task, but reviewers are welcome.

Applied on drm-misc-next, with Thomas ack even if dri patchwork doesn't show it.

Thanks
Benjamin

Quoted 44 lines

Thanks,

Benjamin

Quoted 39 lines
Quoted 39 lines
---
  drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
  include/drm/drm_fb_cma_helper.h     | 2 ++
  2 files changed, 3 insertions(+)
drivers/gpu/drm/drm_fb_cma_helper.c +1 -0
index c0b0f603af63..9801c0333eca 100644
@@ -9,6 +9,7 @@
   *  Copyright (C) 2012 Red Hat
   */
 
+#include <drm/drm_fb_cma_helper.h>
  #include <drm/drm_fourcc.h>
  #include <drm/drm_framebuffer.h>
  #include <drm/drm_gem_cma_helper.h>
include/drm/drm_fb_cma_helper.h +2 -1
index 4becb09975a4..795aea1d0a25 100644
@@ -2,6 +2,8 @@
  #ifndef __DRM_FB_CMA_HELPER_H__
  #define __DRM_FB_CMA_HELPER_H__
 
+#include <linux/types.h>
+
  struct drm_framebuffer;
  struct drm_plane_state;
 
--

2.15.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Benjamin Gaignard

Am 19.11.19 um 11:57 schrieb Benjamin Gaignard:

Quoted 4 lines

Exported functions prototypes are missing in drm_fb_cma_helper.c Include drm_fb_cma_helper to fix that issue.

Quoted 31 lines
---
 drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
 include/drm/drm_fb_cma_helper.h     | 2 ++
 2 files changed, 3 insertions(+)
drivers/gpu/drm/drm_fb_cma_helper.c +1 -0
index c0b0f603af63..9801c0333eca 100644
@@ -9,6 +9,7 @@
  *  Copyright (C) 2012 Red Hat
  */
 
+#include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_cma_helper.h>
include/drm/drm_fb_cma_helper.h +2 -0
index 4becb09975a4..795aea1d0a25 100644
@@ -2,6 +2,8 @@
 #ifndef __DRM_FB_CMA_HELPER_H__
 #define __DRM_FB_CMA_HELPER_H__
 
+#include <linux/types.h>
+
 struct drm_framebuffer;
 struct drm_plane_state;
 
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer