Skip to contentSkip to conversation

regmap: regmap-w1: Drop unreachable code

PATCH In review Mika Westerberg 2 participants 2 messages Nov 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regmap: regmap-w1: Drop unreachable code

Both init functions have a stray "return NULL" at the end which is never reached so drop them.

Fixes cc5d0db390b0 ("regmap: Add 1-Wire bus support")
---
 drivers/base/regmap/regmap-w1.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/base/regmap/regmap-w1.c +0 -4
index 3a7d30b8c3ac..1fbaaad71ca5 100644
@@ -215,8 +215,6 @@ struct regmap *__regmap_init_w1(struct device *w1_dev,
 
 	return __regmap_init(w1_dev, bus, w1_dev, config,
 			 lock_key, lock_name);
-
-	return NULL;
 }
 EXPORT_SYMBOL_GPL(__regmap_init_w1);
 
@@ -233,8 +231,6 @@ struct regmap *__devm_regmap_init_w1(struct device *w1_dev,
 
 	return __devm_regmap_init(w1_dev, bus, w1_dev, config,
 				 lock_key, lock_name);
-
-	return NULL;
 }
 EXPORT_SYMBOL_GPL(__devm_regmap_init_w1);
 
Signature · 1 line
2.24.0
maintainer
#1 lore raw
Quoted 4 lines · Mika Westerberg

Both init functions have a stray "return NULL" at the end which is never reached so drop them.

Fixes cc5d0db390b0 ("regmap: Add 1-Wire bus support")

You're overusing the Fixes tag here...