Skip to contentSkip to conversation

of: property: Add device link support for interrupt-parent, dmas and -gpio(s)

PATCH In review Saravana Kannan 3 participants 7 messages Nov 20, 2019 – Nov 22, 2019 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of: property: Add device link support for interrupt-parent, dmas and -gpio(s)

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>
---
 drivers/of/property.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/of/property.c +8 -0
index 0fa04692e3cc..dedbf82da838 100644
@@ -1188,7 +1188,11 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
 DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
 DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
 DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
+DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
+DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
+DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
+DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
 
 static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_clocks, },
@@ -1196,7 +1200,11 @@ static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_iommus, },
 	{ .parse_prop = parse_mboxes, },
 	{ .parse_prop = parse_io_channels, },
+	{ .parse_prop = parse_interrupt_parent, },
+	{ .parse_prop = parse_dmas, },
 	{ .parse_prop = parse_regulators, },
+	{ .parse_prop = parse_gpio, },
+	{ .parse_prop = parse_gpios, },
 	{}
 };
 
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog
#1 lore raw
Quoted 30 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>
---
 drivers/of/property.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/of/property.c +4 -0
index 0fa04692e3cc..dedbf82da838 100644
@@ -1188,7 +1188,11 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
 DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
 DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
 DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
+DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
+DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
+DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
+DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
 
 static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_clocks, },
@@ -1196,7 +1200,11 @@ static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_iommus, },

drivers/of/property.c static const struct supplier_bindings of_supplier_bindings[] = { · line 1210

Quoted 10 lines
drivers/of/property.c +4 -0
        { .parse_prop = parse_mboxes, },
        { .parse_prop = parse_io_channels, },
+       { .parse_prop = parse_interrupt_parent, },
+       { .parse_prop = parse_dmas, },
        { .parse_prop = parse_regulators, },
+       { .parse_prop = parse_gpio, },
+       { .parse_prop = parse_gpios, },
        {}
 };
 

Rob,

Any chance I get an Ack/Review please?

-Saravana

Reviewed-by on v1 1/1
#2 lore raw
In reply to Saravana Kannan
Quoted 7 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>

This looks to me like doing the right thing and making sure that the GPIO drivers get probed before their consumers and thus speed up boot.

I guess I should get on with adding device links at runtime as well, both for GPIO and pin control so that things work with runtime-added devices and boardfiles and ACPI, if I understand correctly it's fine to add the same link twice, it will just be ignored?

Yours,
Linus Walleij

#3 lore raw
Quoted 11 lines · Linus Walleij
Quoted 7 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>
Quoted 4 lines

This looks to me like doing the right thing and making sure that the GPIO drivers get probed before their consumers and thus speed up boot.

Thanks!

Quoted 6 lines

I guess I should get on with adding device links at runtime as well, both for GPIO and pin control so that things work with runtime-added devices and boardfiles and ACPI, if I understand correctly it's fine to add the same link twice, it will just be ignored?

It's actually ref counted. So do check that the device_link_add() succeeds before trying to release it later on [1].

-Saravana
[1] - https://lore.kernel.org/lkml/[email protected]/

#4 lore raw
In reply to Saravana Kannan
Quoted 17 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>
---
 drivers/of/property.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/of/property.c +0 -0
index 0fa04692e3cc..dedbf82da838 100644

drivers/of/property.c DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells") · line 1191

Quoted 4 lines
drivers/of/property.c +1 -0
@@ -1188,7 +1188,11 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
 DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
 DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
 DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
+DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)

This one is not going to work most of the time (ignoring the fact that the primary controller doesn't have a struct device) because the interrupt-parent is typically in a parent node. You could make it work by specifying 'interrupt-parent' in every node, but that's not a pattern I want to encourage. There's also all the other ways the parent can be determined. Any parent node with 'interrupt-controller' or 'interrupt-map' property is the parent. And there's 'interrupts-extended' too.

Quoted 22 lines
drivers/of/property.c +7 -1
+DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
+DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
+DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
 
 static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_clocks, },
@@ -1196,7 +1200,11 @@ static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_iommus, },
        { .parse_prop = parse_mboxes, },
        { .parse_prop = parse_io_channels, },
+       { .parse_prop = parse_interrupt_parent, },
+       { .parse_prop = parse_dmas, },
        { .parse_prop = parse_regulators, },
+       { .parse_prop = parse_gpio, },
+       { .parse_prop = parse_gpios, },
        {}
 };
 
--

2.24.0.432.g9d3f5f5b63-goog

#5 lore raw
Quoted 14 lines · Rob Herring
Quoted 12 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>
---
 drivers/of/property.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Quoted 13 lines

drivers/of/property.c DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells") · line 1191

Quoted 9 lines
drivers/of/property.c +1 -0
index 0fa04692e3cc..dedbf82da838 100644
@@ -1188,7 +1188,11 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
 DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
 DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
 DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
+DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)

This one is not going to work most of the time (ignoring the fact that the primary controller doesn't have a struct device) because the interrupt-parent is typically in a parent node.

Just to make sure, I'm not parsing this property incorrectly, right?

Are you saying it's listed at the parent of a bunch of devices and the interrupt-parent is inherited and won't really create device links for those child devices?
I mainly added this to make sure IRQ controllers are probed in the right order. Also, if this delays the parent device probe, by the time the child devices are added, the interrupt parent most likely would already be probed.

Quoted 3 lines

You could make it work
by specifying 'interrupt-parent' in every node, but that's not a pattern I want to encourage.

I'm trying to take care of the basic per-device properties first. Adding support for inherited properties isn't too difficult, I just need to get to those at some point. Also, for inherited properties, we can't really block probing because the child device might not depend on that resource. Inherited properties are mainly relevant only for sync_state() callbacks.

Quoted 4 lines

There's also all the other ways the
parent can be determined. Any parent node with 'interrupt-controller' or 'interrupt-map' property is the parent. And there's 'interrupts-extended' too.

Now I'm confused. Not sure if you are referring to actual device parent now or if you are talking about an "interrupt supplier".

-Saravana

Quoted 23 lines
Quoted 23 lines
drivers/of/property.c +7 -1
+DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
+DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
+DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
 
 static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_clocks, },
@@ -1196,7 +1200,11 @@ static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_iommus, },
        { .parse_prop = parse_mboxes, },
        { .parse_prop = parse_io_channels, },
+       { .parse_prop = parse_interrupt_parent, },
+       { .parse_prop = parse_dmas, },
        { .parse_prop = parse_regulators, },
+       { .parse_prop = parse_gpio, },
+       { .parse_prop = parse_gpios, },
        {}
 };
 
--

2.24.0.432.g9d3f5f5b63-goog

#6 lore raw
Quoted 44 lines · Saravana Kannan
Quoted 14 lines · Rob Herring
Quoted 12 lines · Saravana Kannan

Add support for creating device links out of more DT properties.

Cc Greg Kroah-Hartman <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Linus Walleij <[email protected]>
---
 drivers/of/property.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Quoted 13 lines

drivers/of/property.c DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells") · line 1191

Quoted 9 lines
drivers/of/property.c +1 -0
index 0fa04692e3cc..dedbf82da838 100644
@@ -1188,7 +1188,11 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells")
 DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells")
 DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
 DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
+DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)

This one is not going to work most of the time (ignoring the fact that the primary controller doesn't have a struct device) because the interrupt-parent is typically in a parent node.

Just to make sure, I'm not parsing this property incorrectly, right?

Are you saying it's listed at the parent of a bunch of devices and the interrupt-parent is inherited and won't really create device links for those child devices?
I mainly added this to make sure IRQ controllers are probed in the right order. Also, if this delays the parent device probe, by the time the child devices are added, the interrupt parent most likely would already be probed.

Quoted 3 lines

You could make it work
by specifying 'interrupt-parent' in every node, but that's not a pattern I want to encourage.

Quoted 6 lines

I'm trying to take care of the basic per-device properties first. Adding support for inherited properties isn't too difficult, I just need to get to those at some point. Also, for inherited properties, we can't really block probing because the child device might not depend on that resource. Inherited properties are mainly relevant only for sync_state() callbacks.

You're looking at the wrong property. You need to look for 'interrupts' and 'interrupts-extended'. Pretty good chance if the device has interrupts, then it needs them. The latter is easy. It's just like the others you have (phandle + cells). If you have 'interrupts' then you need to walk the interrupt tree the same way the OF IRQ code already does.

Quoted 7 lines
Quoted 4 lines

There's also all the other ways the
parent can be determined. Any parent node with 'interrupt-controller' or 'interrupt-map' property is the parent. And there's 'interrupts-extended' too.

Now I'm confused. Not sure if you are referring to actual device parent now or if you are talking about an "interrupt supplier".

Yes. both. The interrupt tree may or may not mirror the device node tree. Or you could have a mixture. You've got to handle both cases. But really, you just need to use the code that's already there to do all that and deal with all these conditions. Essentially, you need to copy of_irq_get(), but get the struct device from the irq_domain.

Rob