Skip to contentSkip to conversation

pinctrl: Fix Kconfig indentation

PATCH In review Krzysztof Kozlowski 2 participants 3 messages Nov 20, 2019 – Nov 21, 2019

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like:

	$ sed -e 's/^        /\t/' -i */Kconfig
---
 drivers/pinctrl/Kconfig           | 18 ++++++++--------
 drivers/pinctrl/freescale/Kconfig | 12 +++++------
 drivers/pinctrl/qcom/Kconfig      | 34 +++++++++++++++----------------
 3 files changed, 32 insertions(+), 32 deletions(-)
drivers/pinctrl/Kconfig +9 -9
index b372419d61f2..25b6c830f2f1 100644
@@ -32,15 +32,15 @@ config DEBUG_PINCTRL
 	  Say Y here to add some extra checks and diagnostics to PINCTRL calls.
 
 config PINCTRL_ARTPEC6
-        bool "Axis ARTPEC-6 pin controller driver"
-        depends on MACH_ARTPEC6
-        select PINMUX
-        select GENERIC_PINCONF
-        help
-          This is the driver for the Axis ARTPEC-6 pin controller. This driver
-          supports pin function multiplexing as well as pin bias and drive
-          strength configuration. Device tree integration instructions can be
-          found in Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt
+	bool "Axis ARTPEC-6 pin controller driver"
+	depends on MACH_ARTPEC6
+	select PINMUX
+	select GENERIC_PINCONF
+	help
+	  This is the driver for the Axis ARTPEC-6 pin controller. This driver
+	  supports pin function multiplexing as well as pin bias and drive
+	  strength configuration. Device tree integration instructions can be
+	  found in Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt
 
 config PINCTRL_AS3722
 	tristate "Pinctrl and GPIO driver for ams AS3722 PMIC"
drivers/pinctrl/freescale/Kconfig +6 -6
index 5f4058033ec6..3ea9ce3e0cd9 100644
@@ -39,12 +39,12 @@ config PINCTRL_IMX27
 
 
 config PINCTRL_IMX25
-        bool "IMX25 pinctrl driver"
-        depends on OF
-        depends on SOC_IMX25
-        select PINCTRL_IMX
-        help
-          Say Y here to enable the imx25 pinctrl driver
+	bool "IMX25 pinctrl driver"
+	depends on OF
+	depends on SOC_IMX25
+	select PINCTRL_IMX
+	help
+	  Say Y here to enable the imx25 pinctrl driver
 
 config PINCTRL_IMX35
 	bool "IMX35 pinctrl driver"
drivers/pinctrl/qcom/Kconfig +17 -17
index 4f5645245b06..dbdf615da94f 100644
@@ -151,10 +151,10 @@ config PINCTRL_QCOM_SPMI_PMIC
        select GPIOLIB_IRQCHIP
        select IRQ_DOMAIN_HIERARCHY
        help
-         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-         Qualcomm GPIO and MPP blocks found in the Qualcomm PMIC's chips,
-         which are using SPMI for communication with SoC. Example PMIC's
-         devices are pm8841, pm8941 and pma8084.
+	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+	 Qualcomm GPIO and MPP blocks found in the Qualcomm PMIC's chips,
+	 which are using SPMI for communication with SoC. Example PMIC's
+	 devices are pm8841, pm8941 and pma8084.
 
 config PINCTRL_QCOM_SSBI_PMIC
        tristate "Qualcomm SSBI PMIC pin controller driver"
@@ -165,10 +165,10 @@ config PINCTRL_QCOM_SSBI_PMIC
        select GPIOLIB_IRQCHIP
        select IRQ_DOMAIN_HIERARCHY
        help
-         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-         Qualcomm GPIO and MPP blocks found in the Qualcomm PMIC's chips,
-         which are using SSBI for communication with SoC. Example PMIC's
-         devices are pm8058 and pm8921.
+	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+	 Qualcomm GPIO and MPP blocks found in the Qualcomm PMIC's chips,
+	 which are using SSBI for communication with SoC. Example PMIC's
+	 devices are pm8058 and pm8921.
 
 config PINCTRL_SC7180
 	tristate "Qualcomm Technologies Inc SC7180 pin controller driver"
@@ -184,26 +184,26 @@ config PINCTRL_SDM660
        depends on GPIOLIB && OF
        select PINCTRL_MSM
        help
-         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-         Qualcomm Technologies Inc TLMM block found on the Qualcomm
-         Technologies Inc SDM660 platform.
+	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+	 Qualcomm Technologies Inc TLMM block found on the Qualcomm
+	 Technologies Inc SDM660 platform.
 
 config PINCTRL_SDM845
        tristate "Qualcomm Technologies Inc SDM845 pin controller driver"
        depends on GPIOLIB && (OF || ACPI)
        select PINCTRL_MSM
        help
-         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-         Qualcomm Technologies Inc TLMM block found on the Qualcomm
-         Technologies Inc SDM845 platform.
+	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+	 Qualcomm Technologies Inc TLMM block found on the Qualcomm
+	 Technologies Inc SDM845 platform.
 
 config PINCTRL_SM8150
        tristate "Qualcomm Technologies Inc SM8150 pin controller driver"
        depends on GPIOLIB && OF
        select PINCTRL_MSM
        help
-         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-         Qualcomm Technologies Inc TLMM block found on the Qualcomm
-         Technologies Inc SM8150 platform.
+	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+	 Qualcomm Technologies Inc TLMM block found on the Qualcomm
+	 Technologies Inc SM8150 platform.
 
 endif
Signature · 1 line
2.17.1
#1 lore raw

Hello Krzysztof,

drivers/pinctrl/Kconfig config DEBUG_PINCTRL · line 35

Quoted 7 lines · Krzysztof Kozlowski

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like:

	$ sed -e 's/^        /\t/' -i */Kconfig

config PINCTRL_ARTPEC6

drivers/pinctrl/Kconfig +1 -1
-        bool "Axis ARTPEC-6 pin controller driver"
+	bool "Axis ARTPEC-6 pin controller driver"

Here you replace spaces for tabs before the prompt type.

Quoted 2 lines

config PINCTRL_SM8150
tristate "Qualcomm Technologies Inc SM8150 pin controller driver"

Here you leave the spaces before intact.

Intentional?

Cheers
Ahmad

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw
Quoted 12 lines · Ahmad Fatoum

Hello Krzysztof,

drivers/pinctrl/Kconfig config DEBUG_PINCTRL · line 35

Quoted 7 lines · Krzysztof Kozlowski

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like:

      $ sed -e 's/^        /\t/' -i */Kconfig

config PINCTRL_ARTPEC6

drivers/pinctrl/Kconfig +1 -1
-        bool "Axis ARTPEC-6 pin controller driver"
+     bool "Axis ARTPEC-6 pin controller driver"
Quoted 8 lines

Here you replace spaces for tabs before the prompt type.

Quoted 2 lines

config PINCTRL_SM8150
tristate "Qualcomm Technologies Inc SM8150 pin controller driver"

Here you leave the spaces before intact.

Intentional?

No, not intentional. Thanks for pointing it out. I made the sed patterns precise - 8 spaces -> tab, and there you have 7 spaces (ugh!). I'll send a follow up.

Best regards,
Krzysztof