Skip to contentSkip to conversation

ARM: dts: am5729: beaglebone-ai: adding device tree

PATCH In review Caleb Robey 4 participants 6 messages Nov 20, 2019 – Mar 31, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: am5729: beaglebone-ai: adding device tree

From: Jason Kridner <[email protected]>

BeagleBoard.org BeagleBone AI is an open source hardware single board computer based on the Texas Instruments AM5729 SoC featuring dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital signal processor (DSP), quad-core embedded vision engine (EVE), Arm Cortex-M4 processors, dual programmable realtime unit industrial control subsystems and more. The board features 1GB DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash, 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion headers.

For more information, refer to:
https://beaglebone.ai

This patch introduces the BeagleBone AI device tree.

Note that the device use the "ti,tpd12s016" component which is software compatible with "ti,tpd12s015". Thus we only use the latter driver.

---

V2 Changes:
- dra7.dtsi was reintroduced and components that are only not present in upstream linux dts were removed.

 arch/arm/boot/dts/Makefile                |   1 +
 arch/arm/boot/dts/am5729-beagleboneai.dts | 731 ++++++++++++++++++++++
 arch/arm/boot/dts/dra7.dtsi               |   2 +-
 3 files changed, 733 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/am5729-beagleboneai.dts
arch/arm/boot/dts/Makefile +1 -0
index b21b3a64641a..b1154dbda73c 100644
@@ -791,6 +791,7 @@ dtb-$(CONFIG_SOC_DRA7XX) += \
 	am57xx-beagle-x15.dtb \
 	am57xx-beagle-x15-revb1.dtb \
 	am57xx-beagle-x15-revc.dtb \
+	am5729-beagleboneai.dtb \
 	am57xx-cl-som-am57x.dtb \
 	am57xx-sbc-am57x.dtb \
 	am572x-idk.dtb \
arch/arm/boot/dts/am5729-beagleboneai.dts new file +731 -0

731 lines not on this page · raw message

arch/arm/boot/dts/dra7.dtsi +1 -1
index 953f0ffce2a9..563d64c69fd4 100644
@@ -143,7 +143,7 @@
 	 * the moment, just use a fake OCP bus entry to represent the whole bus
 	 * hierarchy.
 	 */
-	ocp {
+	ocp: ocp {
 		compatible = "ti,dra7-l3-noc", "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 12 lines · Caleb Robey

From: Jason Kridner <[email protected]>

BeagleBoard.org BeagleBone AI is an open source hardware single board computer based on the Texas Instruments AM5729 SoC featuring dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital signal processor (DSP), quad-core embedded vision engine (EVE), Arm Cortex-M4 processors, dual programmable realtime unit industrial control subsystems and more. The board features 1GB DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash, 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion headers.

Quoted 8 lines

For more information, refer to:
https://beaglebone.ai

This patch introduces the BeagleBone AI device tree.

Note that the device use the "ti,tpd12s016" component which is software compatible with "ti,tpd12s015". Thus we only use the latter driver.

Ah. thanks. I see my comments resolved here.
no more comments to net part from my side.

Quoted 18 lines

---

V2 Changes:
- dra7.dtsi was reintroduced and components that are only not present in upstream linux dts were removed.

  arch/arm/boot/dts/Makefile                |   1 +
  arch/arm/boot/dts/am5729-beagleboneai.dts | 731 ++++++++++++++++++++++
  arch/arm/boot/dts/dra7.dtsi               |   2 +-
  3 files changed, 733 insertions(+), 1 deletion(-)

create mode 100644 arch/arm/boot/dts/am5729-beagleboneai.dts

[..]

Signature · 2 lines
Best regards,
grygorii
#2 lore raw
Quoted 18 lines · Grygorii Strashko
Quoted 15 lines · Caleb Robey

From: Jason Kridner <[email protected]>

BeagleBoard.org BeagleBone AI is an open source hardware single board computer based on the Texas Instruments AM5729 SoC featuring dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital signal processor (DSP), quad-core embedded vision engine (EVE), Arm Cortex-M4 processors, dual programmable realtime unit industrial control subsystems and more. The board features 1GB DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash, 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion headers.

For more information, refer to:
https://beaglebone.ai

Quoted 8 lines
Quoted 5 lines

This patch introduces the BeagleBone AI device tree.

Note that the device use the "ti,tpd12s016" component which is software compatible with "ti,tpd12s015". Thus we only use the latter driver.

Ah. thanks. I see my comments resolved here.
no more comments to net part from my side.

Just FYI, Jason had one pending comment on the earlier version about the compatible property to use.

So I'm assuming there will be a new version posted, tagging this one as read.

Regards,

Tony

#3 lore raw
Quoted 22 lines · Tony Lindgren
Quoted 22 lines · Caleb Robey
Quoted 20 lines

From: Jason Kridner <[email protected]>

BeagleBoard.org BeagleBone AI is an open source hardware single board computer based on the Texas Instruments AM5729 SoC featuring dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital signal processor (DSP), quad-core embedded vision engine (EVE), Arm Cortex-M4 processors, dual programmable realtime unit industrial control subsystems and more. The board features 1GB DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash, 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion headers.

For more information, refer to:
https://beaglebone.ai

This patch introduces the BeagleBone AI device tree.

Note that the device use the "ti,tpd12s016" component which is software compatible with "ti,tpd12s015". Thus we only use the latter driver.

Quoted 8 lines
Quoted 2 lines

Ah. thanks. I see my comments resolved here.
no more comments to net part from my side.

Just FYI, Jason had one pending comment on the earlier version about the compatible property to use.

So I'm assuming there will be a new version posted, tagging this one as read.

It came to my attention today when talking with Jason Kridner and Robert Nelson that we did not get the BeagleBone AI device tree upstream yet.

I am having trouble identifying what the pending comment was from the original patch series.

Was it related to this compatible string?

Quoted 1 line

+ compatible = "beagleboard.org,am5729-beagleboneai", "ti,am5728",

thanks,
drew

--
Drew Fustini
BeagleBoard.org Foundation
https://beagleboard.org/about

#4 lore raw
Quoted 32 lines · Drew Fustini
Quoted 22 lines · Tony Lindgren
Quoted 22 lines · Caleb Robey
Quoted 20 lines

From: Jason Kridner <[email protected]>

BeagleBoard.org BeagleBone AI is an open source hardware single board computer based on the Texas Instruments AM5729 SoC featuring dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital signal processor (DSP), quad-core embedded vision engine (EVE), Arm Cortex-M4 processors, dual programmable realtime unit industrial control subsystems and more. The board features 1GB DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash, 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion headers.

For more information, refer to:
https://beaglebone.ai

This patch introduces the BeagleBone AI device tree.

Note that the device use the "ti,tpd12s016" component which is software compatible with "ti,tpd12s015". Thus we only use the latter driver.

Quoted 8 lines
Quoted 2 lines

Ah. thanks. I see my comments resolved here.
no more comments to net part from my side.

Just FYI, Jason had one pending comment on the earlier version about the compatible property to use.

So I'm assuming there will be a new version posted, tagging this one as read.

Quoted 10 lines

It came to my attention today when talking with Jason Kridner and Robert Nelson that we did not get the BeagleBone AI device tree upstream yet.

I am having trouble identifying what the pending comment was from the original patch series.

Was it related to this compatible string?

Quoted 1 line

+ compatible = "beagleboard.org,am5729-beagleboneai", "ti,am5728",

Yes I think Jason had some comment on the compatible string to use.

Regards,

Tony

#5 lore raw
Quoted 41 lines · Tony Lindgren
Quoted 39 lines · Drew Fustini
Quoted 22 lines · Tony Lindgren
Quoted 22 lines · Caleb Robey
Quoted 20 lines

From: Jason Kridner <[email protected]>

BeagleBoard.org BeagleBone AI is an open source hardware single board computer based on the Texas Instruments AM5729 SoC featuring dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital signal processor (DSP), quad-core embedded vision engine (EVE), Arm Cortex-M4 processors, dual programmable realtime unit industrial control subsystems and more. The board features 1GB DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash, 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion headers.

For more information, refer to:
https://beaglebone.ai

This patch introduces the BeagleBone AI device tree.

Note that the device use the "ti,tpd12s016" component which is software compatible with "ti,tpd12s015". Thus we only use the latter driver.

Quoted 8 lines
Quoted 2 lines

Ah. thanks. I see my comments resolved here.
no more comments to net part from my side.

Just FYI, Jason had one pending comment on the earlier version about the compatible property to use.

So I'm assuming there will be a new version posted, tagging this one as read.

It came to my attention today when talking with Jason Kridner and Robert Nelson that we did not get the BeagleBone AI device tree upstream yet.

I am having trouble identifying what the pending comment was from the original patch series.

Quoted 6 lines
Quoted 3 lines

Was it related to this compatible string?

Quoted 1 line

+ compatible = "beagleboard.org,am5729-beagleboneai", "ti,am5728",

Yes I think Jason had some comment on the compatible string to use.

Ah, I see it now [1]:

Quoted 4 lines

Probably need to change "beagleboard.org," to "beagle," as of today. With the new yaml stuff for defining device tree entries, having the period (.) in the vendor identifier can be a bit confusing. I altered my submission to avoid this.

so I think this should work:

compatible = "beagleboard-org,am5729-beagleboneai", "ti,am5728",

We'll get it resubmitted.

Thanks,
Drew

[1] https://lore.kernel.org/linux-devicetree/CA+T6QPm-DNG_QoAMWw_zUDUkZCfhbBTgygnoPAykf3mgK7opaA@mail.gmail.com/