Skip to contentSkip to conversation

x86/vlapic: allow setting APIC_SPIV_FOCUS_DISABLED in x2APIC mode

PATCH In review Roger Pau Monne 3 participants 3 messages Nov 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/vlapic: allow setting APIC_SPIV_FOCUS_DISABLED in x2APIC mode

Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED regardless of the processor model, which is not correct according to the specification.

This issue was discovered while trying to boot a pvshim with x2APIC enabled.

Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC provided to guests is emulated by Xen, and as such doesn't depend on the features found on the hardware processor. Note for example that Xen offers x2APIC support to guests even when the underlying hardware doesn't have such feature.

---
Cc: Juergen Gross <[email protected]>
---
Changes since v1:
- Always allow setting the APIC_SPIV_FOCUS_DISABLED bit.

---
 xen/arch/x86/hvm/vlapic.c | 1 +
 1 file changed, 1 insertion(+)
xen/arch/x86/hvm/vlapic.c +1 -0
index 9466258d6f..b790ba6bbd 100644
@@ -993,6 +993,7 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, uint64_t msr_content)
 
     case APIC_SPIV:
         if ( msr_content & ~(APIC_VECTOR_MASK | APIC_SPIV_APIC_ENABLED |
+                             APIC_SPIV_FOCUS_DISABLED |
                              (VLAPIC_VERSION & APIC_LVR_DIRECTED_EOI
                               ? APIC_SPIV_DIRECTED_EOI : 0)) )
             return X86EMUL_EXCEPTION;
Signature · 7 lines
2.24.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Roger Pau Monne

Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED regardless of the processor model, which is not correct according to the specification.

This issue was discovered while trying to boot a pvshim with x2APIC enabled.

Quoted 7 lines

Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC provided to guests is emulated by Xen, and as such doesn't depend on the features found on the hardware processor. Note for example that Xen offers x2APIC support to guests even when the underlying hardware doesn't have such feature.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
In reply to Roger Pau Monne
Quoted 7 lines · Roger Pau Monne

Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED regardless of the processor model, which is not correct according to the specification.

This issue was discovered while trying to boot a pvshim with x2APIC enabled.

Quoted 7 lines

Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC provided to guests is emulated by Xen, and as such doesn't depend on the features found on the hardware processor. Note for example that Xen offers x2APIC support to guests even when the underlying hardware doesn't have such feature.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel