new board ls1028ardb introduced
v2 cover new board ls1028ardb introduced
changes since v1:
1> According to the feedback from other guys, modify the codes
2> create one new patch to move package/rcw to package/freescale-qoriq/ patches detail in v2:
0001-xxxx: is 0005-xxxx in v1, don't change
0002-xxxx: new patch to move rcw to sub-direcotry "freescale-qoriq" 0003-xxxx: is 0001-xxxx in v1, add-back license hash
0004-xxxx: is 0002-xxxx in v1, add option BR2_PACKAGE_HOST_RCW_ATF 0005-xxxx: is 0003-xxxx in v1, add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE 0006-xxxx: is 0004-xxxx in v1, use BR2_PACKAGE_HOST_RCW_ATF ATF
0007-xxxx: is 0006-xxxx in v1, rename to fsl-qoriq-cadence-dp-fw,
use the "fsl" to replace freescale, fw to replace firmware,
update DEVELOPERS
add license hash
rewrite makefile
0008-xxxx: is 0007-xxxx in v1, change to unconditional for patches 0009-xxxx: is 0008-xxxx in v1, use BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW to DP 0010-xxxx: is 0009-xxxx in v1, add new options
---
The following nine patches is to enable LS1028ARDB board in Buildroot.
NXP LS1028A silicon is based on Arm A72 core and designed for industry, some key features are enabled:
TSN - Time Sensitive Network on Network interface TSN/Swith - naive TSN Swith, support six ports
DP - display port for different resolution up to 4K
The base for these patches is "next" branch, commitID: 5fd8db02ef
1. Upgrade the RCW version to latest version supported via LSDK-19.09
2. Use RCW binary for boot board
3. Intruduce u-boot-dtb.bin for NXP Layerscape serial platform
4. Introduce RCW to Arm-trusted-firmware
5. Create one freescale-qoriq direcotry for all firmware hardware related
6. LS1028ARDB DP firmware is stored in freescale-qoriq
7. New patches to eanble GPIO interrupt for eNETC and Micro-bus
8. One standard directory for all Layerscape platform
9. LS1028ARDB related scripts and default configurations
---
PATCH v2 1/10 package/freescale-qoriq: new package directory
The freescale-qoriq directory is intended to contain all freescale QorIQ (including PowerPC and LayerScape serial) related packages, together with their download site and version info.
---
changes since v1:
no changes
--- package/Config.in | 1 + package/freescale-qoriq/Config.in | 4 ++++ package/freescale-qoriq/freescale-qoriq.mk | 1 + 3 files changed, 6 insertions(+) create mode 100644 package/freescale-qoriq/Config.in create mode 100644 package/freescale-qoriq/freescale-qoriq.mk
package/Config.in +1 -0
@@ -447,6 +447,7 @@ endmenu source "package/flashrom/Config.in" source "package/fmtools/Config.in" source "package/freescale-imx/Config.in" + source "package/freescale-qoriq/Config.in" source "package/fxload/Config.in" source "package/gadgetfs-test/Config.in" source "package/gcnano-binaries/Config.in"
package/freescale-qoriq/Config.in new file +4 -0
@@ -0,0 +1,4 @@ +menu "Freescale QorIQ libraries" + depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc + +endmenu
package/freescale-qoriq/freescale-qoriq.mk new file +1 -0
@@ -0,0 +1 @@ +include $(sort $(wildcard package/freescale-qoriq/*/*.mk))
Signature · 1 line
2.17.1
PATCH v2 1/10 package/freescale-qoriq: new package directory
Quoted 5 lines · On Thu, 21 Nov 2019 18:23:15 +0800 Changming Huang <[email protected]> wrote:
The freescale-qoriq directory is intended to contain all freescale QorIQ (including PowerPC and LayerScape serial) related packages, together with their download site and version info.
Signed-off-by Changming Huang <[email protected]>
So I think I read somewhere that you were suggested to use package/nxp-qoriq/ instead of package/freescale-qoriq/. This change is fine to me, so feel fee to do it in your v3.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 01/10] package/freescale-qoriq: new package directory
Best Regards
Jerry Huang
Quoted 18 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 5:13 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 01/10] package/freescale-qoriq: new package directoryCaution: EXT Email
Quoted 4 lines · On Thu, 21 Nov 2019 18:23:15 +0800 Changming Huang <[email protected]> wrote:
The freescale-qoriq directory is intended to contain all freescale QorIQ (including PowerPC and LayerScape serial) related packages, together with their download site and version info.
Quoted 5 lines
Quoted 1 line
Signed-off-by Changming Huang <[email protected]>So I think I read somewhere that you were suggested to use package/nxp-qoriq/ instead of package/freescale-qoriq/. This change is fine to me, so feel fee to do it in your v3.
[Jerry Huang]
Yes, I will do this change in v3.
Quoted 11 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C74086714ba394cd6b 7cc08d771ec47f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103131944681003&sdata=3eDGrwaYCX99dBtZHMcGpG8ONM5pc8iSafW RGHPO8DE%3D&reserved=0
PATCH v2 2/10 package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it
In reply to Changming HuangFrom: Jerry Huang <[email protected]>
Move package/rcw into package/freescale-qoriq,
and rename it to fsl-qoriq-rcw.
---
changes since v1:
1. new patch
2. move rcw to sub-directory freescale-qoriq
3. rename to fsl-qoriq-rcw
---
DEVELOPERS | 2 +-
package/Config.in.host | 2 +-
.../fsl-qoriq-rcw}/Config.in.host | 0
.../fsl-qoriq-rcw/fsl-qoriq-rcw.hash} | 0
.../fsl-qoriq-rcw/fsl-qoriq-rcw.mk} | 22 +++++++++----------
5 files changed, 13 insertions(+), 13 deletions(-)
rename package/{rcw => freescale-qoriq/fsl-qoriq-rcw}/Config.in.host (100%)
rename package/{rcw/rcw.hash => freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash} (100%)
rename package/{rcw/rcw.mk => freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk} (72%)DEVELOPERS +1 -1
@@ -1603,7 +1603,7 @@ F: package/python-pyrex/ F: package/python-tinyrpc/ F: package/python-txdbus/ F: package/raptor/ -F: package/rcw/ +F: package/freescale-qoriq/fsl-qoriq-rcw/ F: package/rng-tools/ F: package/rsyslog/ F: package/setools/
package/Config.in.host +1 -1
@@ -62,7 +62,7 @@ menu "Host utilities" source "package/qemu/Config.in.host" source "package/raspberrypi-usbboot/Config.in.host" source "package/rauc/Config.in.host" - source "package/rcw/Config.in.host" + source "package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host" source "package/rustc/Config.in.host" source "package/s6-rc/Config.in.host" source "package/sam-ba/Config.in.host"
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host renamed from package/rcw/Config.in.host +0 -0
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash renamed from package/rcw/rcw.hash +0 -0
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk renamed from package/rcw/rcw.mk +11 -11
@@ -1,14 +1,14 @@ ################################################################################ # -# rcw +# fsl-qoriq-rcw # ################################################################################ -RCW_VERSION = LSDK-18.12 -RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw -RCW_SITE_METHOD = git -RCW_LICENSE = BSD-3-Clause -RCW_LICENSE_FILES = LICENSE +FSL_QORIQ_RCW_VERSION = LSDK-18.12 +FSL_QORIQ_RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw +FSL_QORIQ_RCW_SITE_METHOD = git +FSL_QORIQ_RCW_LICENSE = BSD-3-Clause +FSL_QORIQ_RCW_LICENSE_FILES = LICENSE RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
@@ -23,28 +23,28 @@ $(error BR2_PACKAGE_HOST_RCW_CUSTOM_PATH must have exactly one .rcw file) endif endif -define HOST_RCW_ADD_CUSTOM_RCW_FILES +define HOST_FSL_QORIQ_RCW_ADD_CUSTOM_RCW_FILES mkdir -p $(@D)/custom_board/rcw cp -f $(filter-out %.rcw,$(RCW_FILES)) $(@D)/custom_board cp -f $(filter %.rcw,$(RCW_FILES)) $(@D)/custom_board/rcw endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES -define HOST_RCW_BUILD_CMDS +define HOST_FSL_QORIQ_RCW_BUILD_CMDS python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin endef -define HOST_RCW_INSTALL_DELIVERY_FILE +define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin endef endif # Copy source files and script into $(HOST_DIR)/share/rcw/ so a developer # could use a post image or SDK to build/install PBL files. -define HOST_RCW_INSTALL_CMDS +define HOST_FSL_QORIQ_RCW_INSTALL_CMDS mkdir -p $(HOST_DIR)/share/rcw cp -a $(@D)/* $(HOST_DIR)/share/rcw - $(HOST_RCW_INSTALL_DELIVERY_FILE) + $(HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE) endef $(eval $(host-generic-package))
Signature · 1 line
2.17.1
PATCH v2 2/10 package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 11 lines
From: Jerry Huang <[email protected]>
Move package/rcw into package/freescale-qoriq,
and rename it to fsl-qoriq-rcw.Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. new patch
2. move rcw to sub-directory freescale-qoriq
3. rename to fsl-qoriq-rcw
shouldn't be the naming consistent with the sub-directory? I know there is already a freescale-imx and the packages are only named imx-*. On the other hand, the variable names will be longer. Mhh.
[snip]
-michael
[Buildroot] [EXT] Re: [PATCH v2 02/10] package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it
Hi, Michael,
Best Regards
Jerry Huang
Quoted 24 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Thursday, November 21, 2019 6:35 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; geomatsi at gmail.com;
matthew.weber at collins.com; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 02/10] package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename itCaution: EXT Email
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 11 lines
From: Jerry Huang <[email protected]>
Move package/rcw into package/freescale-qoriq, and rename it to fsl-qoriq-rcw.
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. new patch
2. move rcw to sub-directory freescale-qoriq 3. rename to fsl-qoriq-rcw
Quoted 3 lines
shouldn't be the naming consistent with the sub-directory? I know there is already a freescale-imx and the packages are only named imx-*. On the other hand, the variable names will be longer. Mhh.
If keep the same with sub-directory, it is too long, so I use the short name "fsl" to replace "freescale". Actually, the FSL is used widely before freescale is merge into NXP.
Quoted 3 lines
[snip]
-michael
PATCH v2 2/10 package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it
In reply to Changming HuangQuoted 6 lines · On Thu, 21 Nov 2019 18:23:16 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Move package/rcw into package/freescale-qoriq,
and rename it to fsl-qoriq-rcw.Signed-off-by Jerry Huang <[email protected]>
Then, this package should be named nxp-qoriq-rcw, if you decide to name the directory nxp-qoriq/.
Quoted 8 lines
---
changes since v1:
1. new patch
2. move rcw to sub-directory freescale-qoriq
3. rename to fsl-qoriq-rcw--- DEVELOPERS | 2 +- package/Config.in.host | 2 +-
You need Config.in.legacy handling due to the renaming of the option.
DEVELOPERS F: package/python-pyrex/ · line 1606
Quoted 10 lines
DEVELOPERS +1
-1@@ -1603,7 +1603,7 @@ F: package/python-pyrex/ F: package/python-tinyrpc/ F: package/python-txdbus/ F: package/raptor/ -F: package/rcw/ +F: package/freescale-qoriq/fsl-qoriq-rcw/
Please preserve alphabetic ordering.
package/Config.in.host menu "Host utilities" · line 65
Quoted 13 lines
DEVELOPERS +0
-0F: package/rng-tools/ F: package/rsyslog/ F: package/setools/package/Config.in.host +1
-1@@ -62,7 +62,7 @@ menu "Host utilities" source "package/qemu/Config.in.host" source "package/raspberrypi-usbboot/Config.in.host" source "package/rauc/Config.in.host" - source "package/rcw/Config.in.host" + source "package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host"
Ditto: alphabetic ordering.
package/Config.in.host menu "Host utilities"
Quoted 12 lines
package/Config.in.host +5
-5-RCW_VERSION = LSDK-18.12 -RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw -RCW_SITE_METHOD = git -RCW_LICENSE = BSD-3-Clause -RCW_LICENSE_FILES = LICENSE +FSL_QORIQ_RCW_VERSION = LSDK-18.12 +FSL_QORIQ_RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw +FSL_QORIQ_RCW_SITE_METHOD = git +FSL_QORIQ_RCW_LICENSE = BSD-3-Clause +FSL_QORIQ_RCW_LICENSE_FILES = LICENSE RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
How come the BR2_PACKAGE_HOST_RCW_CUSTOM_PATH option is not renamed ?
Also RCW_FILES should become NXP_QORIQ_RCW_FILES. All variables in the .mk file should be renamed.
package/Config.in.host
Quoted 7 lines
package/Config.in.host +1
-1-define HOST_RCW_ADD_CUSTOM_RCW_FILES +define HOST_FSL_QORIQ_RCW_ADD_CUSTOM_RCW_FILES mkdir -p $(@D)/custom_board/rcw cp -f $(filter-out %.rcw,$(RCW_FILES)) $(@D)/custom_board cp -f $(filter %.rcw,$(RCW_FILES)) $(@D)/custom_board/rcw endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES
If you don't change the hook registration, the hook will never be called. Please check globally in this patch.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 02/10] package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it
Thanks a lot for your comment, Thomas.
Best Regards
Jerry Huang
Quoted 17 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 5:16 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 02/10] package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename itCaution: EXT Email
Quoted 2 lines · On Thu, 21 Nov 2019 18:23:16 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Quoted 7 lines
Quoted 4 lines
Move package/rcw into package/freescale-qoriq, and rename it to fsl-qoriq-rcw.
Signed-off-by Jerry Huang <[email protected]>Then, this package should be named nxp-qoriq-rcw, if you decide to name the directory nxp-qoriq/.
I renamed this package to qoriq-rcw, is it ok? Because there are similar naming in freescale-imx.
Quoted 10 lines
Quoted 8 lines
---
changes since v1:
1. new patch
2. move rcw to sub-directory freescale-qoriq 3. rename to fsl-qoriq-rcw--- DEVELOPERS | 2 +- package/Config.in.host | 2 +-You need Config.in.legacy handling due to the renaming of the option.
Sure, I will do it.
Quoted 13 lines
DEVELOPERS F: package/python-pyrex/ · line 1606
Quoted 11 lines
DEVELOPERS +1
-1@@ -1603,7 +1603,7 @@ F: package/python-pyrex/ F: package/python-tinyrpc/ F: package/python-txdbus/ F: package/raptor/ -F: package/rcw/ +F: package/freescale-qoriq/fsl-qoriq-rcw/Please preserve alphabetic ordering.
Sure
Quoted 16 lines
Quoted 9 lines
DEVELOPERS +0
-0F: package/rng-tools/ F: package/rsyslog/ F: package/setools/package/Config.in.host index renamed from package/Config.in.host +0
-0
758c268e00..e4840080ad100644package/Config.in.host menu "Host utilities" · line 65
Quoted 5 lines
package/Config.in.host +1
-1@@ -62,7 +62,7 @@ menu "Host utilities" source "package/qemu/Config.in.host" source "package/raspberrypi-usbboot/Config.in.host" source "package/rauc/Config.in.host" - source "package/rcw/Config.in.host" + source "package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host"Ditto: alphabetic ordering.
sure
Quoted 37 lines
Quoted 5 lines
package/Config.in.host +0
-2-RCW_VERSION = LSDK-18.12 -RCW_SITE =https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
ce.codeaurora.org%2Fexternal%2Fqoriq%2Fqoriq-components%2Frcw&da ta
Quoted 1 line
=02%7C01%7Cjerry.huang%40nxp.com%7C440c1c4d06f845dca04908d771ec9b da%7C
Quoted 1 line
686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637103133347439348&a mp;sdat
Quoted 1 line
a=stm4A4DGFRjWmRHcqo%2FLchoIgp4GjrpRk6JvryEf6zc%3D&reserved=0
package/Config.in.host
Quoted 7 lines
package/Config.in.host +3
-3-RCW_SITE_METHOD = git -RCW_LICENSE = BSD-3-Clause -RCW_LICENSE_FILES = LICENSE +FSL_QORIQ_RCW_VERSION = LSDK-18.12 +FSL_QORIQ_RCW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsou+rce.codeaurora.org%2Fexternal%2Fqoriq%2Fqoriq-components%2Frcw& da
Quoted 1 line
+ta=02%7C01%7Cjerry.huang%40nxp.com%7C440c1c4d06f845dca04908d771e c9bda
Quoted 1 line
+%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371031333474393 48&
Quoted 1 line
+sdata=stm4A4DGFRjWmRHcqo%2FLchoIgp4GjrpRk6JvryEf6zc%3D&reser ved=0
Quoted 4 lines
package/Config.in.host +3
-0+FSL_QORIQ_RCW_SITE_METHOD = git +FSL_QORIQ_RCW_LICENSE = BSD-3-Clause +FSL_QORIQ_RCW_LICENSE_FILES = LICENSE
Quoted 7 lines
Quoted 1 line
RCW_FILES= $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))How come the
BR2_PACKAGE_HOST_RCW_CUSTOM_PATHoption is not renamed ?Also
RCW_FILESshould becomeNXP_QORIQ_RCW_FILES. All variables in the .mk file should be renamed.
I will rename all optioins.
Quoted 9 lines
Quoted 6 lines
package/Config.in.host +1
-1-define HOST_RCW_ADD_CUSTOM_RCW_FILES +define HOST_FSL_QORIQ_RCW_ADD_CUSTOM_RCW_FILES mkdir -p $(@D)/custom_board/rcw cp -f $(filter-out %.rcw,$(RCW_FILES)) $(@D)/custom_board cp -f $(filter %.rcw,$(RCW_FILES)) $(@D)/custom_board/rcw endef
HOST_RCW_POST_PATCH_HOOKS+=HOST_RCW_ADD_CUSTOM_RCW_FILESIf you don't change the hook registration, the hook will never be called. Please check globally in this patch.
Ok, will do it.
Quoted 11 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C440c1c4d06f845dca0 4908d771ec9bda%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103133347439348&sdata=Efi59wYwQ4QCZ7KLiyj6acpsadH5BuGJk%2FFyY dMDnBc%3D&reserved=0
PATCH v2 3/10 package/freescale-qoriq/fsl-qoriq-rcw: upgrade the rcw version to LSDK-19.09
In reply to Changming HuangFrom: Jerry Huang <[email protected]>
Change the RCW version to LSDK-19.09.
---
changes since v1:
1. add-back license hash
--- package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash | 2 +- package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 4dca8adeda48836b86aa459cc526dfbb4e0873492682c3c3a828a28b82b7b100 fsl-qoriq-rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -FSL_QORIQ_RCW_VERSION = LSDK-18.12 +FSL_QORIQ_RCW_VERSION = LSDK-19.09 FSL_QORIQ_RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw FSL_QORIQ_RCW_SITE_METHOD = git FSL_QORIQ_RCW_LICENSE = BSD-3-Clause
Signature · 1 line
2.17.1
PATCH v2 3/10 package/freescale-qoriq/fsl-qoriq-rcw: upgrade the rcw version to LSDK-19.09
Hello,
Quoted 5 lines · On Thu, 21 Nov 2019 18:23:17 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Change the RCW version to LSDK-19.09.
Signed-off-by Jerry Huang <[email protected]>
The commit title should be:
package/<packagename>: bump to version LSDK-19.03
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash line 2
Quoted 8 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash +1
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 4dca8adeda48836b86aa459cc526dfbb4e0873492682c3c3a828a28b82b7b100 fsl-qoriq-rcw-LSDK-19.09.tar.gz
The renaming of the tarball should have happened in patch 02/10, not
here: we should just see the change of the version number here.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 03/10] package/freescale-qoriq/fsl-qoriq-rcw: upgrade the rcw version to LSDK-19.09
Best Regards
Jerry Huang
Quoted 36 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 5:17 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 03/10] package/freescale-qoriq/fsl-qoriq-rcw: upgrade the rcw version to LSDK-19.09Caution: EXT Email
Hello,
Quoted 5 lines · On Thu, 21 Nov 2019 18:23:17 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Change the RCW version to LSDK-19.09.
Signed-off-by Jerry Huang <[email protected]>The commit title should be:
package/<packagename>: bump to version LSDK-19.03
Review
Quoted 1 line
(quoted diff) +0
-0b/package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash line 2
Quoted 6 lines
index
7de1ec659a..413db80e6d100644package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash +0
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256
1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3rcw-LSDK-18.12.tar.gz
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash line 2
Quoted 1 line
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.hash +1
-0+sha256
4dca8adeda48836b86aa459cc526dfbb4e0873492682c3c3a828a28b82b7b100fsl-qoriq-rcw-LSDK-19.09.tar.gzThe renaming of the tarball should have happened in patch 02/10, not
here: we should just see the change of the version number here.
Will do it in patch 02/10
Quoted 11 lines
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C31589b42787e4c216f 0a08d771ecd598%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103134322307809&sdata=DbVJ8Mf3cz97vPhYsoDcxaL169xr3weAoNy99Q 9awzc%3D&reserved=0
PATCH v2 4/10 package/freescale-qoriq/fsl-qoriq-rcw: add target rcw binary support
In reply to Changming HuangFrom: Jerry Huang <[email protected]>
For NXP QorIQ (PowerPC and Layerscape) platform, we need to specify the RCW file and build it to binary.
Introduce BR2_PACKAGE_HOST_RCW_ATF to use ATF for RCW.
Introduce BR2_PACKAGE_HOST_RCW_BIN to specify the RCW binary file.
Introduce BR2_PACKAGE_HOST_RCW_BOOT_MODE to define the boot mode. Because the RCW binary can be stored in different media, for example:
SD card - RCW locate in SD card, boot the board from SD card
eMMC - RCW locate in eMMC chip, boot the board from eMMC chip
flexSPI - RCW locate in flexSPI, boot the board from flexSPI Nor/Nand flash
QSPI - RCW locate in QSPI flash, boot the board from QSPI flash
---
changes since v1:
1. add option BR2_PACKAGE_HOST_RCW_ATF for ATF
--- .../freescale-qoriq/fsl-qoriq-rcw/Config.in.host | 15 +++++++++++++++ .../fsl-qoriq-rcw/fsl-qoriq-rcw.mk | 11 +++++++++++ 2 files changed, 26 insertions(+)
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +15 -0
@@ -25,4 +25,19 @@ config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH included for use in the SDK or with post scripts but no RCW binary will not be generated. +config BR2_PACKAGE_HOST_RCW_ATF + bool "atf for rcw" + help + When ATF is used for RCW, enable this option. + +config BR2_PACKAGE_HOST_RCW_BIN + string "Custom RCW" + help + This option is used to specify the RCW binary file for board. + +config BR2_PACKAGE_HOST_RCW_BOOT_MODE + string "Boot mode" + help + Specify the boot mode, for example, sd, emmc, flexspi_nor. + endif
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +11 -0
@@ -37,6 +37,17 @@ endef define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin endef +else +RCW_BIN = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_PLATFORM = $(firstword $(subst /, ,$(RCW_BIN))) + +define HOST_FSL_QORIQ_RCW_BUILD_CMDS + cd $(@D)/$(RCW_PLATFORM) && $(MAKE) +endef + +define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/$(RCW_BIN) $(BINARIES_DIR)/ +endef endif # Copy source files and script into $(HOST_DIR)/share/rcw/ so a developer
Signature · 1 line
2.17.1
PATCH v2 4/10 package/freescale-qoriq/fsl-qoriq-rcw: add target rcw binary support
Hello,
I'm sorry, but I don't really grasp what this patch is trying to do.
Quoted 6 lines · On Thu, 21 Nov 2019 18:23:18 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
For NXP QorIQ (PowerPC and Layerscape) platform, we need to specify the RCW file and build it to binary.
Introduce
BR2_PACKAGE_HOST_RCW_ATFto use ATF for RCW.
What does this mean ?
Quoted 1 line
Introduce
BR2_PACKAGE_HOST_RCW_BINto specify the RCW binary file.
Hm, ok, but then it seems to be used to calculate from which directory "make" is going to be invoked.
Quoted 21 lines
Introduce
BR2_PACKAGE_HOST_RCW_BOOT_MODEto define the boot mode. Because the RCW binary can be stored in different media, for example:
SD card - RCW locate in SD card, boot the board from SD card
eMMC - RCW locate in eMMC chip, boot the board from eMMC chip
flexSPI - RCW locate in flexSPI, boot the board from flexSPI Nor/Nand flash
QSPI - RCW locate in QSPI flash, boot the board from QSPI flashSigned-off-by Jerry Huang <[email protected]>---
changes since v1:
1. add optionBR2_PACKAGE_HOST_RCW_ATFfor ATF--- .../freescale-qoriq/fsl-qoriq-rcw/Config.in.host | 15 +++++++++++++++ .../fsl-qoriq-rcw/fsl-qoriq-rcw.mk | 11 +++++++++++ 2 files changed, 26 insertions(+)package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +0
-0
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 31
Quoted 7 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +4
-0@@ -25,4 +25,19 @@ config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH included for use in the SDK or with post scripts but no RCW binary will not be generated. +config BR2_PACKAGE_HOST_RCW_ATF + bool "atf for rcw" + help + When ATF is used for RCW, enable this option.
This option is not used in the code below.
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 33
Quoted 2 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +2
-0+ +config BR2_PACKAGE_HOST_RCW_BIN
Should be named with a BR2_PACKAGE_HOST_FSL_QORIQ_RCW_ prefix.
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 36
Quoted 3 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +3
-0+ string "Custom RCW" + help + This option is used to specify the RCW binary file for board.
More details are needed. What happens when this option is empty? Which values are typically needed? Your code assumes there's one slash in the value, this should be explained.
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 38
Quoted 1 line
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +1
-0+config BR2_PACKAGE_HOST_RCW_BOOT_MODE
This option is not used in the .mk file
Quoted 10 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +4
-0+ string "Boot mode" + help + Specify the boot mode, for example, sd, emmc, flexspi_nor. + endifpackage/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +0
-0
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 40
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +1
-0@@ -37,6 +37,17 @@ endef define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin endef +else
Why is this part mutually exclusive with the BR2_PACKAGE_HOST_RCW_CUSTOM_PATH option ? I'd like to understand what they each try to do. If they are mutually exclusive, they should also be mutually exclusive at the Config.in level. Could you please explain the different use cases for rcw so that we can figure out the right way to handle this ?
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 42
Quoted 2 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +2
-0+RCW_BIN = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_PLATFORM = $(firstword $(subst /, ,$(RCW_BIN)))
Variables must be prefixed by the package name, not just RCW_.
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 45
Quoted 3 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +3
-0+ +define HOST_FSL_QORIQ_RCW_BUILD_CMDS + cd $(@D)/$(RCW_PLATFORM) && $(MAKE)
Should be:
$(MAKE) -C ...
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 49
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +4
-0+endef + +define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/$(RCW_BIN) $(BINARIES_DIR)/
Complete destination path is needed, including the destination file name.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 04/10] package/freescale-qoriq/fsl-qoriq-rcw: add target rcw binary support
Best Regards
Jerry Huang
Quoted 9 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 5:24 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 04/10] package/freescale-qoriq/fsl-qoriq-rcw: add target rcw binary support
Quoted 5 lines
Caution: EXT Email
Hello,
I'm sorry, but I don't really grasp what this patch is trying to do.
Hi, Thomas,
This patch is to build the binary *.bin file which is used by QorIQ platforms booting with the QorIQ-RCW source codes.
Quoted 11 lines
Quoted 6 lines · On Thu, 21 Nov 2019 18:23:18 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
For NXP QorIQ (PowerPC and Layerscape) platform, we need to specify the RCW file and build it to binary.
Introduce
BR2_PACKAGE_HOST_RCW_ATFto use ATF for RCW.What does this mean ?
Which is used by ATF for RCW, will move it to patch 07/10
Quoted 5 lines
Quoted 2 lines
Introduce
BR2_PACKAGE_HOST_RCW_BINto specify the RCW binary file.Hm, ok, but then it seems to be used to calculate from which directory "make" is going to be invoked.
This option is for RCW binary, including the path and file name, for example: ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.bin the first word is the platform, last word is the binary file used.
Quoted 26 lines
Quoted 26 lines
Introduce
BR2_PACKAGE_HOST_RCW_BOOT_MODEto define the boot mode. Because the RCW binary can be stored in different media, for example:
SD card - RCW locate in SD card, boot the board from SD card
eMMC - RCW locate in eMMC chip, boot the board from eMMC chip
flexSPI - RCW locate in flexSPI, boot the board from flexSPI Nor/Nand flash
QSPI - RCW locate in QSPI flash, boot the board from QSPI flashSigned-off-by Jerry Huang <[email protected]>---
changes since v1:
1. add optionBR2_PACKAGE_HOST_RCW_ATFfor ATF--- .../freescale-qoriq/fsl-qoriq-rcw/Config.in.host | 15 +++++++++++++++ .../fsl-qoriq-rcw/fsl-qoriq-rcw.mk | 11 +++++++++++ 2 files changed, 26 insertions(+)package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +0
-0@@ -25,4 +25,19 @@ config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH included for use in the SDK or with post scripts but no RCW binary will not be generated.
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 31
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +4
-0+config BR2_PACKAGE_HOST_RCW_ATF + bool "atf for rcw" + help + When ATF is used for RCW, enable this option.This option is not used in the code below.
Will move it to patch 07/10.
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 33
Quoted 3 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +2
-0+ +config BR2_PACKAGE_HOST_RCW_BINShould be named with a
BR2_PACKAGE_HOST_FSL_QORIQ_RCW_prefix.
Sure,
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 36
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +3
-0+ string "Custom RCW" + help + This option is used to specify the RCW binary file for board.
Quoted 7 lines
More details are needed. What happens when this option is empty? Which values are typically needed? Your code assumes there's one slash in the value, this should be explained.
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 38
Quoted 1 line
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +1
-0+config BR2_PACKAGE_HOST_RCW_BOOT_MODEThis option is not used in the .mk file
Which is used by ATF for RCW, will vove it to patch 07/10.
Quoted 14 lines
Quoted 14 lines
package/freescale-qoriq/fsl-qoriq-rcw/Config.in.host +4
-0+ string "Boot mode" + help + Specify the boot mode, for example, sd, emmc, flexspi_nor. + endifpackage/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +0
-0@@ -37,6 +37,17 @@ endef define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin
Quoted 8 lines
Quoted 2 lines
endef
+elseWhy is this part mutually exclusive with the
BR2_PACKAGE_HOST_RCW_CUSTOM_PATHoption ? I'd like to understand what they each try to do. If they are mutually exclusive, they should also be mutually exclusive at the Config.in level. Could you please explain the different use cases for rcw so that we can figure out the right way to handle this ?
According to original scripts, R2_PACKAGE_HOST_RCW_CUSTOM_PATH is used for the RCW specified by customer. Add some special command is needed for this option.
In order to use the source codes from NXP, some other commands are needed, so they are mutually exclusive. Then, I will add the mutually exclusive in config.in file.
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 42
Quoted 3 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +2
-0+RCW_BIN = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_PLATFORM = $(firstword $(subst /, ,$(RCW_BIN)))Variables must be prefixed by the package name, not just
RCW_.
Sure,
Quoted 8 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 45
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +3
-0+ +define HOST_FSL_QORIQ_RCW_BUILD_CMDS + cd $(@D)/$(RCW_PLATFORM) && $(MAKE)Should be:
$(MAKE) -C ...
Will change it
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk endef · line 49
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-rcw/fsl-qoriq-rcw.mk +4
-0+endef + +define HOST_FSL_QORIQ_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/$(RCW_BIN) $(BINARIES_DIR)/Complete destination path is needed, including the destination file name.
Sure, will add the file name.
Quoted 12 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7Ca3c1ca285da948a32 78108d771edc2f5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103138304575881&sdata=o1hb4D4YqQ58G0RH0siotPJsl7kp3HS0u4T5jMA 7YR8%3D&reserved=0
PATCH v2 5/10 boot/arm-trusted-firmware: Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE
In reply to Changming HuangFrom: Jerry Huang <[email protected]>
Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE to define the U-Boot BIN. The default setting is u-boot.bin, customer can change it to anything via defconfig.
---
changes since v1:
1. add BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE for uboot binary file
2. default of new option is u-boot.bin.
3. use the new option for U-Boot BL33
--- boot/arm-trusted-firmware/Config.in | 12 ++++++++++++ boot/arm-trusted-firmware/arm-trusted-firmware.mk | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-)
boot/arm-trusted-firmware/Config.in +12 -0
@@ -124,6 +124,18 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33 gets built before ATF, and that the appropriate BL33 variable pointing to u-boot.bin is passed when building ATF. +if BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33 + +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE + string "U-Boot BL33 Image for ATF" + default "u-boot.bin" + help + The U-Boot BL33 image for ATF, u-boot.bin is the default setting, + this setting can be changed to any U-Boot binary file that used, + for example, u-boot-dtb.bin. + +endif + config BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES string "Additional ATF build variables" help
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2 -1
@@ -70,7 +70,8 @@ endif endif # BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y) -ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot.bin +ARM_TRUSTED_FIRMWARE_UBOOT_BIN = $(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE)) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/$(ARM_TRUSTED_FIRMWARE_UBOOT_BIN) ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endif
Signature · 1 line
2.17.1
PATCH v2 5/10 boot/arm-trusted-firmware: Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE
Quoted 44 lines · Changming Huang
From: Jerry Huang <[email protected]>
Add option
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEto define the U-Boot BIN. The default setting is u-boot.bin, customer can change it to anything via defconfig.Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. addBR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEfor uboot binary file
2. default of new option is u-boot.bin.
3. use the new option for U-Boot BL33--- boot/arm-trusted-firmware/Config.in | 12 ++++++++++++ boot/arm-trusted-firmware/arm-trusted-firmware.mk | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-)boot/arm-trusted-firmware/Config.in +12
-0@@ -124,6 +124,18 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33 gets built before ATF, and that the appropriate BL33 variable pointing to u-boot.bin is passed when building ATF. +if BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33 + +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE + string "U-Boot BL33 Image for ATF" + default "u-boot.bin" + help + The U-Boot BL33 image for ATF, u-boot.bin is the default setting, + this setting can be changed to any U-Boot binary file that used, + for example, u-boot-dtb.bin. + +endif + config BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES string "Additional ATF build variables" helpboot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-0
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 76
Quoted 8 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-1@@ -70,7 +70,8 @@ endif endif # BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y) -ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot.bin +ARM_TRUSTED_FIRMWARE_UBOOT_BIN = $(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE)) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/$(ARM_TRUSTED_FIRMWARE_UBOOT_BIN) ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endif
Hello Jerry,
Thanks for the update. This one looks good to me.
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH v2 05/10] boot/arm-trusted-firmware: Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE
Best Regards
Jerry Huang
Quoted 75 lines
-----Original Message-----
From: Sergey Matyukevich <[email protected]>
Sent: Friday, November 22, 2019 5:11 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; matthew.weber at collins.com; michael at walle.cc; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 05/10] boot/arm-trusted-firmware: Add optionBR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGECaution: EXT Email
Quoted 3 lines · Changming Huang
From: Jerry Huang <[email protected]>
Add option
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEto define the U-Boot BIN.
Quoted 1 line
The default setting is u-boot.bin, customer can change it to anything via
defconfig.
Quoted 5 lines
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. addBR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEforuboot
boot/arm-trusted-firmware/Config.in config
Quoted 13 lines
binary file 2. default of new option is u-boot.bin.
3. use the new option for U-Boot BL33--- boot/arm-trusted-firmware/Config.in | 12 ++++++++++++ boot/arm-trusted-firmware/arm-trusted-firmware.mk | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-)boot/arm-trusted-firmware/Config.in +0
-0@@ -124,6 +124,18 @@ config
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33Quoted 24 lines
boot/arm-trusted-firmware/Config.in +12
-0gets built before ATF, and that the appropriate BL33 variable pointing to u-boot.bin is passed when building ATF. +if BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33 + +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE + string "U-Boot BL33 Image for ATF" + default "u-boot.bin" + help + The U-Boot BL33 image for ATF, u-boot.bin is the default setting, + this setting can be changed to any U-Boot binary file that used, + for example, u-boot-dtb.bin. + +endif + config BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES string "Additional ATF build variables" helpboot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-0boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 73
Quoted 4 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-1@@ -70,7 +70,8 @@ endif endif # BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y) -ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BL33=$(BINARIES_DIR)/u-boot.bin
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 77
Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0+ARM_TRUSTED_FIRMWARE_UBOOT_BIN = $(call +qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE)) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += +BL33=$(BINARIES_DIR)/$(ARM_TRUSTED_FIRMWARE_UBOOT_BIN) ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endifHello Jerry,
Quoted 3 lines
Thanks for the update. This one looks good to me.
Reviewed-by Sergey Matyukevich <[email protected]>
Thanks a lot.
Quoted 2 lines
Regards,
Sergey
PATCH v2 5/10 boot/arm-trusted-firmware: Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE
In reply to Changming HuangQuoted 11 lines · On Thu, 21 Nov 2019 18:23:19 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Add option
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEto define the U-Boot BIN. The default setting is u-boot.bin, customer can change it to anything via defconfig.Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. addBR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEfor uboot binary file
2. default of new option is u-boot.bin.
3. use the new option for U-Boot BL33
Quoted 4 lines
--- boot/arm-trusted-firmware/Config.in | 12 ++++++++++++ boot/arm-trusted-firmware/arm-trusted-firmware.mk | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-)
I have applied to next, after reworking the commit log and Config.in help text.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 6/10 boot/arm-trusted-firmware: Add RCW support
In reply to Changming HuangNXP Layerscape platforms use RCW (Reset Configure Word) to
setup clocking and IO allocations and then launches the next stage of boot. RCW needs ATF as well as uboot.
Option BR2_PACKAGE_HOST_RCW_ATF is used to determine if ATF is used for RCW.
---
changes since v1:
1. Use option BR2_PACKAGE_HOST_RCW_ATF as the condition for RCW used by ATF.
--- boot/arm-trusted-firmware/arm-trusted-firmware.mk | 9 +++++++++ 1 file changed, 9 insertions(+)
boot/arm-trusted-firmware/arm-trusted-firmware.mk +9 -0
@@ -92,6 +92,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y) +RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE)) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE) +ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pbl +ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-fsl-qoriq-rcw +endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-openssl
Signature · 1 line
2.17.1
PATCH v2 6/10 boot/arm-trusted-firmware: Add RCW support
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0@@ -92,6 +92,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y) +RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 106
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +7
-0+RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE) +ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pbl +ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-fsl-qoriq-rcw +endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-openssl
Hi Jerry, Thomas, and all
This approach looks reasonable to me: if we enable RCW_ATF in board config, then arm-trusted-firmware build process is modified in accordance with that choice.
However I am slightly worried about naming. There was a discussion around the first version of the patch set regarding too generic name for RCW package. IIUC here we have the same issue here. Option BR2_PACKAGE_HOST_RCW_ATF looks fairly generic, but it selects fsl-qoriq specific dependencies.
Thoughts ? Comments ?
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW support
Best Regards
Jerry Huang
Quoted 41 lines
-----Original Message-----
From: Sergey Matyukevich <[email protected]>
Sent: Friday, November 22, 2019 5:20 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; matthew.weber at collins.com; michael at walle.cc; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW supportCaution: EXT Email
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 96
Quoted 11 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0@@ -92,6 +92,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y) +RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif
Quoted 3 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +3
-0+RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 100
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS+=Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+pbl ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-fsl-qoriq-rcw endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-opensslHi Jerry, Thomas, and all
This approach looks reasonable to me: if we enable
RCW_ATFin board config, then arm-trusted-firmware build process is modified in accordance with that choice.
Quoted 6 lines
However I am slightly worried about naming. There was a discussion around the first version of the patch set regarding too generic name for RCW package. IIUC here we have the same issue here. Option
BR2_PACKAGE_HOST_RCW_ATFlooks fairly generic, but it selects fsl-qoriq specific dependencies.Thoughts ? Comments ?
Currently, just Freescale/NXP QorIQ platforms use RCW to configure the hardware. Maybe, who can suggest one more reasonable name for that (BR2_PACKAGE_HOST_RCW_ATF) ?
Quoted 2 lines
Regards,
Sergey
PATCH v2 6/10 boot/arm-trusted-firmware: Add RCW support
In reply to Changming HuangHello,
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 95
Quoted 9 lines · On Thu, 21 Nov 2019 18:23:20 +0800 Changming Huang <[email protected]> wrote:
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0@@ -92,6 +92,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y)
This option should be introduced by this patch.
Overall, I'm not super happy with how arm-trusted-firmware works. In some cases, it's a sub-option of arm-trusted-firmware that causes it to use some additional package (for example OPTEE as BL32, U-Boot as BL33), but sometimes it's the implicit fact of having another package enabled (mv-ddr-marvell, vexpress-firmware), that causes arm-trusted-firmware to use it. Not great.
So I'm not sure how to proceed with RCW.
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 3 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +3
-0+RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE)) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH)))
Those variables names should be prefixed with the package name, i.e ARM_TRUSTED_FIRMWARE.
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 99
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE)
These BOOT_MODE and RCW options are not supported in ATF upstream, apparently only in the NXP fork. I'm not sure we want explicit support for vendor-specific things. Should we look at providing an arm-trusted-firmware that can more easily be customized through options?
That's really an open discussion, I don't yet have a clear idea on how to handle that.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW support
Hi, Thomas,
Some comment in lines, please review them, thanks a lot.
Best Regards
Jerry Huang
Quoted 23 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:10 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW supportCaution: EXT Email
Hello,
Quoted 7 lines · On Thu, 21 Nov 2019 18:23:20 +0800 Changming Huang <[email protected]> wrote:
boot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-0@@ -92,6 +92,15 @@ endif
Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 95
Quoted 3 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y)This option should be introduced by this patch.
Sure,
Quoted 8 lines
Overall, I'm not super happy with how arm-trusted-firmware works. In some cases, it's a sub-option of arm-trusted-firmware that causes it to use some additional package (for example OPTEE as BL32, U-Boot as BL33), but sometimes it's the implicit fact of having another package enabled (mv-ddr-marvell, vexpress-firmware), that causes arm-trusted-firmware to use it. Not great.
So I'm not sure how to proceed with RCW.
Yes, it uses some additional package for booting.
But, if it does not use them (U-Boot as BL33, OPTEE as BL32, RCW as BL2), what can arm-trusted-firmware do?
Quoted 7 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 96
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 2 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH)))Those variables names should be prefixed with the package name, i.e
ARM_TRUSTED_FIRMWARE.
Sure,
Quoted 8 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 99
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 100
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)These
BOOT_MODEand RCW options are not supported in ATF upstream, apparently only in the NXP fork. I'm not sure we want explicit support for vendor-specific things. Should we look at providing an arm-trusted-firmware that can more easily be customized through options?
Maybe we can provide three options ARM_TRUSTED_FIRMWARE_EXTRA_OPTS: the custom OPTS ARM_TRUSTED_FIRMWARE_EXTRA_TARGETS: the custom TARGETS ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES: the custom dependency
Which are defined in defconfig file or empty,
For example, NXP QorIQ:ARM_TRUSTED_FIRMWARE_EXTRA_OPTS = " BOOT_MODE=sd RCW=$(BINARIES_DIR)/ rcw_1300_sdboot.bin" ARM_TRUSTED_FIRMWARE_EXTRA_TARGETS = " pbl" ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES = "host-qoriq-rcw"
Or Marvell DDR:ARM_TRUSTED_FIRMWARE_EXTRA_OPTS = " SCP_BL2=$(BINARIES_DIR)/scp-fw.bin" ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES = "mv-ddr-marvell"
we can use them as below without detecting the condition in ATF makefile:ARM_TRUSTED_FIRMWARE_MAKE_OPTS += ARM_TRUSTED_FIRMWARE_EXTRA_OPTS ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += ARM_TRUSTED_FIRMWARE_EXTRA_TARGETS ARM_TRUSTED_FIRMWARE_DEPENDENCIES += ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES
We can put anything we want into these options, and the ATF makefile is very clean.
How do you think about them?
Quoted 12 lines
That's really an open discussion, I don't yet have a clear idea on how to handle that.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C74c02743671b4e18a b5c08d771f42b8f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103165822614341&sdata=rcEnN%2B%2FlfMpj0iwpikulfsCH0v813TaG86K GsE3eGTo%3D&reserved=0
[Buildroot] [EXT] Re: [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW support
I double check the "boot/arm-trusted-firmware/Config.in",
There is one option BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES,
I think it can be used to replace my previous mail mentioned: ARM_TRUSTED_FIRMWARE_EXTRA_OPTS. Add now this option is added to ARM_TRUSTED_FIRMWARE_MAKE_OPTS
So in order to keep consistent with the context, two new options are defined:BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_ DEPENDENCIES
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_TARGETS ARM_TRUSTED_FIRMWARE_DEPENDENCIES += BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_ DEPENDENCIES
Best Regards
Jerry Huang
Quoted 119 lines
-----Original Message-----
From: Jerry Huang
Sent: Tuesday, November 26, 2019 3:07 PM
To: Thomas Petazzoni <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: RE: [EXT] Re: [Buildroot] [PATCH v2 06/10] boot/arm-trusted-firmware:
Add RCW supportHi, Thomas,
Some comment in lines, please review them, thanks a lot.Best Regards
Jerry HuangQuoted 23 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:10 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW supportCaution: EXT Email
Hello,
Quoted 7 lines · On Thu, 21 Nov 2019 18:23:20 +0800 Changming Huang <[email protected]> wrote:
boot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-0@@ -92,6 +92,15 @@ endifQuoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 95
Quoted 3 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y)This option should be introduced by this patch.
Sure,
Quoted 5 lines
Overall, I'm not super happy with how arm-trusted-firmware works. In some cases, it's a sub-option of arm-trusted-firmware that causes it to use some additional package (for example OPTEE as BL32, U-Boot as BL33), but sometimes it's the implicit fact of having another package enabled (mv-ddr-marvell, vexpress-firmware), that causes
arm-trusted-firmware to use it.
Quoted 3 lines
Not great.
So I'm not sure how to proceed with RCW.
Yes, it uses some additional package for booting.
But, if it does not use them (U-Boot as BL33, OPTEE as BL32, RCW as BL2), what can arm-trusted-firmware do?Quoted 7 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 96
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 2 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH)))Those variables names should be prefixed with the package name, i.e
ARM_TRUSTED_FIRMWARE.Sure,
Quoted 8 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 99
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 100
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)These
BOOT_MODEand RCW options are not supported in ATF upstream, apparently only in the NXP fork. I'm not sure we want explicit support for vendor-specific things. Should we look at providing an arm-trusted-firmware that can more easily be customized through options?Maybe we can provide three options
ARM_TRUSTED_FIRMWARE_EXTRA_OPTS: the custom OPTSARM_TRUSTED_FIRMWARE_EXTRA_TARGETS: the custom TARGETSARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES: the custom dependencyWhich are defined in defconfig file or empty, For example, NXP QorIQ:
ARM_TRUSTED_FIRMWARE_EXTRA_OPTS= " BOOT_MODE=sd RCW=$(BINARIES_DIR)/ rcw_1300_sdboot.bin"ARM_TRUSTED_FIRMWARE_EXTRA_TARGETS= " pbl"ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES= "host-qoriq-rcw" Or Marvell DDR:ARM_TRUSTED_FIRMWARE_EXTRA_OPTS= " SCP_BL2=$(BINARIES_DIR)/scp-fw.bin"ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIES= "mv-ddr-marvell"we can use them as below without detecting the condition in ATF makefile:
ARM_TRUSTED_FIRMWARE_MAKE_OPTS+=ARM_TRUSTED_FIRMWARE_EXTRA_OPTSARM_TRUSTED_FIRMWARE_MAKE_TARGETS+=ARM_TRUSTED_FIRMWARE_EXTRA_TARGETSARM_TRUSTED_FIRMWARE_DEPENDENCIES+=ARM_TRUSTED_FIRMWARE_EXTRA_DEPENDENCIESWe can put anything we want into these options, and the ATF makefile is very clean.
How do you think about them?
Quoted 9 lines
That's really an open discussion, I don't yet have a clear idea on how to handle that.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com&data=02%7C01%7Cjerry.huang%40nxp.com%7C74c02743671b4e18a
Quoted 1 line
b5c08d771f42b8f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637
Quoted 1 line
103165822614341&sdata=rcEnN%2B%2FlfMpj0iwpikulfsCH0v813TaG86K
Quoted 1 line
GsE3eGTo%3D&reserved=0
PATCH v2 7/10 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Changming HuangFrom: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fw
2. update DEVELOPERS
3. add the hash of package
4. modify the context fo config file to package name
5. re-write the makefile according to rule of buildroot
6. add the license message in makefile
--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24 +++++++++++++++++++ 5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
DEVELOPERS +3 -0
@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
package/freescale-qoriq/Config.in +2 -0
@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenu
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link: http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha256 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58 firmware-cadence-lsdk1909.bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +24 -0
@@ -0,0 +1,24 @@ +################################################################################ +# +# fsl-qoriq-cadence-dp-fw +# +################################################################################ + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SOURCE = firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept; +endef + +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644 $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin +endef + +$(eval $(generic-package))
Signature · 1 line
2.17.1
PATCH v2 7/10 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 8 lines
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fw
All other firmware's in buildroot have a "-firmware" suffix.
Quoted 101 lines
2. update DEVELOPERS
3. add the hash of package
4. modify the context fo config file to package name
5. re-write the makefile according to rule of buildroot
6. add the license message in makefile--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24 +++++++++++++++++++ 5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash create mode 100644
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mkDEVELOPERS +3
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/package/freescale-qoriq/Config.in +2
-0@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenupackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link:http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash new file mode 100644
index 0000000000..bee912bee1
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hashpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256
5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58firmware-cadence-lsdk1909.bin
diff --gita/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mkb/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mknew file mode 100644
index 0000000000..d0d112e25f
---/dev/null
+++b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mkpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +9
-0@@ -0,0 +1,24 @@ +################################################################################ +# +# fsl-qoriq-cadence-dp-fw +# +################################################################################ + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SOURCE =firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +8
-0+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept;
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+endef + +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644
Quoted 3 lines
$(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
+endef
IMHO this should be also installed into the target filesystem. So the driver can
request the firmware binary. I know that this is not how NXP handles that at the
moment. But in the end, that should be the way to go, esp. since rockchip seems
to have the same/similar DP-PHY with a corresponding driver upstream and they are
already loading the firmware via request_firmware().
Quoted 2 lines
+
+$(eval $(generic-package))
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Best Regards
Jerry Huang
Quoted 14 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Thursday, November 21, 2019 6:43 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; geomatsi at gmail.com; matthew.weber at collins.com; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 2 lines
From: Jerry Huang <[email protected]>
Quoted 8 lines
Quoted 6 lines
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fwAll other firmware's in buildroot have a "-firmware" suffix.
Because the name is too long if I use the full name "freescale-qoriq-cadence-dp-firmware", So I used short name "fsl" prefix to replace freescale and "fw" suffix to release firmware. If necessary, I can use the full name, instead of short name.
Quoted 136 lines
Quoted 11 lines
2. update DEVELOPERS
3. add the hash of package
4. modify the context fo config file to package name 5. re-write the makefile according to rule of buildroot 6. add the license message in makefile--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24+++++++++++++++++++
Quoted 46 lines
5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.hash create mode 100644package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.mk
DEVELOPERS +3
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/package/freescale-qoriq/Config.in +0
-0@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
BR2_powerpcpackage/freescale-qoriq/Config.in +2
-0+source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenupackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link:xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
Quoted 1 line
data=02%7C01%7Cjerry.huang%40nxp.com%7Ca71c7361a8eb40680c9908d76e 6f8d1
Quoted 1 line
e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370992977061416 81&
Quoted 1 line
sdata=cjWdcvyCKsIcw5qV5x%2BJEvVCiFuMeyBNprHm582rkws%3D&reser ved=0
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 29 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash
new file mode 100644
index 0000000000..bee912bee1
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-1-fw.hash@@ -0,0 +1,2 @@ +# Locally calculated +sha256
5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk
new file mode 100644
index 0000000000..d0d112e25f
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +0
-1-fw.mk@@ -0,0 +1,24 @@+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 4
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+########### +# +# fsl-qoriq-cadence-dp-fw +#+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 9
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0+########### + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&data=02%7C01%7Cjerry.huang% 40n
Quoted 1 line
+xp.com%7Ca71c7361a8eb40680c9908d76e6f8d1e%7C686ea1d3bc2b4c6fa92c d99c5
Quoted 1 line
+c301635%7C0%7C0%7C637099297706141681&sdata=N1ZBA4m%2F%2F CF7WjNa5j
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0+XkfrnIastkxjHwoSO8G9%2BZcnk%3D&reserved=0 +FSL_QORIQ_CADENCE_DP_FW_SOURCE =firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +8
-0+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO URCE)
Quoted 14 lines
Quoted 8 lines
--auto-accept;
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+endef + +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644$(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
+endefIMHO this should be also installed into the target filesystem. So the driver can request the firmware binary. I know that this is not how NXP handles that at the moment. But in the end, that should be the way to go, esp. since rockchip seems to have the same/similar DP-PHY with a corresponding driver upstream and they are already loading the firmware via
request_firmware().
Yes, this firmware can be into target filesystem, but the driver should be built as module. If driver is built-in Linux kernel, we need to load this firmware before starting kernel. Now ls1028ardb uses the build-in mode for DP driver, so I can't put it into target filesystem, And load it in uboot prompt before starting kernel.
Quoted 4 lines
Quoted 2 lines
+
+$(eval $(generic-package))-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Michael WalleBest Regards
Jerry Huang
Quoted 14 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Thursday, November 21, 2019 6:43 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; geomatsi at gmail.com; matthew.weber at collins.com; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 2 lines
From: Jerry Huang <[email protected]>
Quoted 8 lines
Quoted 6 lines
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fwAll other firmware's in buildroot have a "-firmware" suffix.
Will use suffix "-firmware" in v3.
Quoted 155 lines
Quoted 11 lines
2. update DEVELOPERS
3. add the hash of package
4. modify the context fo config file to package name 5. re-write the makefile according to rule of buildroot 6. add the license message in makefile--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24+++++++++++++++++++
Quoted 46 lines
5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.hash create mode 100644package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.mk
DEVELOPERS +3
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/package/freescale-qoriq/Config.in +0
-0@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
BR2_powerpcpackage/freescale-qoriq/Config.in +2
-0+source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenupackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link:xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
Quoted 1 line
data=02%7C01%7Cjerry.huang%40nxp.com%7Ca71c7361a8eb40680c9908d76e 6f8d1
Quoted 1 line
e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370992977061416 81&
Quoted 1 line
sdata=cjWdcvyCKsIcw5qV5x%2BJEvVCiFuMeyBNprHm582rkws%3D&reser ved=0
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 29 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash
new file mode 100644
index 0000000000..bee912bee1
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-1-fw.hash@@ -0,0 +1,2 @@ +# Locally calculated +sha256
5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk
new file mode 100644
index 0000000000..d0d112e25f
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +0
-1-fw.mk@@ -0,0 +1,24 @@+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 4
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+########### +# +# fsl-qoriq-cadence-dp-fw +#+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 9
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0+########### + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&data=02%7C01%7Cjerry.huang% 40n
Quoted 1 line
+xp.com%7Ca71c7361a8eb40680c9908d76e6f8d1e%7C686ea1d3bc2b4c6fa92c d99c5
Quoted 1 line
+c301635%7C0%7C0%7C637099297706141681&sdata=N1ZBA4m%2F%2F CF7WjNa5j
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0+XkfrnIastkxjHwoSO8G9%2BZcnk%3D&reserved=0 +FSL_QORIQ_CADENCE_DP_FW_SOURCE =firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +8
-0+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO URCE)
Quoted 8 lines
--auto-accept;
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+endef + +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644$(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
+endefIMHO this should be also installed into the target filesystem. So the driver can request the firmware binary. I know that this is not how NXP handles that at the moment. But in the end, that should be the way to go, esp. since rockchip seems to have the same/similar DP-PHY with a corresponding driver upstream and they are already loading the firmware via
request_firmware().Quoted 2 lines
+
+$(eval $(generic-package))-michael
PATCH v2 7/10 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Changming HuangAm 2019-11-21 11:23, schrieb Changming Huang:
Quoted 103 lines
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fw
2. update DEVELOPERS
3. add the hash of package
4. modify the context fo config file to package name
5. re-write the makefile according to rule of buildroot
6. add the license message in makefile--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24 +++++++++++++++++++ 5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash create mode 100644
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mkDEVELOPERS +3
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/package/freescale-qoriq/Config.in +2
-0@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenupackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link:http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash new file mode 100644
index 0000000000..bee912bee1
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hashpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256
5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58firmware-cadence-lsdk1909.bin
diff --gita/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mkb/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mknew file mode 100644
index 0000000000..d0d112e25f
---/dev/null
+++b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mkpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +9
-0@@ -0,0 +1,24 @@ +################################################################################ +# +# fsl-qoriq-cadence-dp-fw +# +################################################################################ + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SOURCE =firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +8
-0+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh
Quoted 3 lines
$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept;
+endef
There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that should be renamed and used here.
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Best Regards
Jerry Huang
Quoted 154 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Thursday, November 21, 2019 6:52 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; geomatsi at gmail.com; matthew.weber at collins.com; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 11 lines
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fw 2. update DEVELOPERS
3. add the hash of package 4. modify the context fo config file to package name 5. re-write the makefile according to rule of buildroot
6. add the license message in makefileQuoted 6 lines
--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24+++++++++++++++++++
Quoted 46 lines
5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.hash create mode 100644package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.mk
DEVELOPERS +3
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/package/freescale-qoriq/Config.in +0
-0@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
BR2_powerpcpackage/freescale-qoriq/Config.in +2
-0+source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenupackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link:xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
Quoted 1 line
data=02%7C01%7Cjerry.huang%40nxp.com%7C8af29f72a8524b1f700608d76e7 0ce5
Quoted 1 line
c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370993030840248 67&
Quoted 1 line
sdata=uSC8EhBphE5cLuUGjHWvGyRgNCs3kdPKUe3xBgAna3U%3D&reserv ed=0
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 29 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash
new file mode 100644
index 0000000000..bee912bee1
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-1-fw.hash@@ -0,0 +1,2 @@ +# Locally calculated +sha256
5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk
new file mode 100644
index 0000000000..d0d112e25f
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +0
-1-fw.mk@@ -0,0 +1,24 @@+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 4
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+########### +# +# fsl-qoriq-cadence-dp-fw +#+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 9
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0+########### + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&data=02%7C01%7Cjerry.huang% 40n
Quoted 1 line
+xp.com%7C8af29f72a8524b1f700608d76e70ce5c%7C686ea1d3bc2b4c6fa92c d99c5
Quoted 1 line
+c301635%7C0%7C0%7C637099303084024867&sdata=efvW3VQKOjQPq5 5%2BMpeu
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0+uARsbNMl0NV99IwR1ylN9vs%3D&reserved=0 +FSL_QORIQ_CADENCE_DP_FW_SOURCE =firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +8
-0+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO URCE)
Quoted 5 lines
Quoted 2 lines
--auto-accept;
+endefThere is already an
FREESCALE_IMX_EXTRACT_HELPERmacro. I guess that should be renamed and used here.
It is ok for me.
Hi, Thomas,
How do you think about it?
Quoted 1 line
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Michael WalleBest Regards
Jerry Huang
Quoted 154 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Thursday, November 21, 2019 6:52 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; geomatsi at gmail.com; matthew.weber at collins.com; thomas.petazzoni at bootlin.com
Subject: [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Am 2019-11-21 11:23, schrieb Changming Huang:
Quoted 11 lines
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fw 2. update DEVELOPERS
3. add the hash of package 4. modify the context fo config file to package name 5. re-write the makefile according to rule of buildroot
6. add the license message in makefileQuoted 6 lines
--- DEVELOPERS | 3 +++ package/freescale-qoriq/Config.in | 2 ++ .../fsl-qoriq-cadence-dp-fw/Config.in | 5 ++++ .../fsl-qoriq-cadence-dp-fw.hash | 2 ++ .../fsl-qoriq-cadence-dp-fw.mk | 24+++++++++++++++++++
Quoted 46 lines
5 files changed, 36 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.hash create mode 100644package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f w.mk
DEVELOPERS +3
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/package/freescale-qoriq/Config.in +0
-0@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
BR2_powerpcpackage/freescale-qoriq/Config.in +2
-0+source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in" + endmenupackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware" + help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link:xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
Quoted 1 line
data=02%7C01%7Cjerry.huang%40nxp.com%7C8af29f72a8524b1f700608d76e7 0ce5
Quoted 1 line
c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370993030840248 67&
Quoted 1 line
sdata=uSC8EhBphE5cLuUGjHWvGyRgNCs3kdPKUe3xBgAna3U%3D&reserv ed=0
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 29 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash
new file mode 100644
index 0000000000..bee912bee1
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-1-fw.hash@@ -0,0 +1,2 @@ +# Locally calculated +sha256
5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk
new file mode 100644
index 0000000000..d0d112e25f
---/dev/null
+++
b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dppackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +0
-1-fw.mk@@ -0,0 +1,24 @@+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 4
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+########### +# +# fsl-qoriq-cadence-dp-fw +#+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 9
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +5
-0+########### + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&data=02%7C01%7Cjerry.huang% 40n
Quoted 1 line
+xp.com%7C8af29f72a8524b1f700608d76e70ce5c%7C686ea1d3bc2b4c6fa92c d99c5
Quoted 1 line
+c301635%7C0%7C0%7C637099303084024867&sdata=efvW3VQKOjQPq5 5%2BMpeu
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0+uARsbNMl0NV99IwR1ylN9vs%3D&reserved=0 +FSL_QORIQ_CADENCE_DP_FW_SOURCE =firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +8
-0+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no + +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO URCE)
Quoted 5 lines
Quoted 2 lines
--auto-accept;
+endefThere is already an
FREESCALE_IMX_EXTRACT_HELPERmacro. I guess that should be renamed and used here.
I changed this codes accordance with freescale-imx, create new option FREESCALE_QORIQ_EXTRACT_HELPER Will post it to maillist marked "v3"
Quoted 1 line
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Hi,
Quoted 6 lines
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +3
-0+define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO URCE)
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
--auto-accept;
+endefThere is already an
FREESCALE_IMX_EXTRACT_HELPERmacro. I guess that should be renamed and used here.I changed this codes accordance with freescale-imx, create new option
FREESCALE_QORIQ_EXTRACT_HELPER
why FREESCALE_QORIQ_EXTRACT_HELPER? are there two different ones now? Shouldn't it be just FREESCALE_EXTRACT_HELPER? and the definition of the macro should be moved out of the freescale-imx.mk?
or of course, there might be another subdirectory structure like:
packages/freescale/imx
packages/freescale/qoriqpacakges/freescale/helper.mk
Or..
packages/freescale/fsl-imx-<package>
packages/freescale/fsl-qoriq-<package>pacakges/freescale/helper.mk
And the macro might end up in the pacakges/freescale/helper.mk file.
TBH. I guess there have to be a cleanup before adding the qoriq stuff. Thomas? Matthew?
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Best Regards
Jerry Huang
Quoted 28 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Friday, November 22, 2019 7:00 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; geomatsi at gmail.com; matthew.weber at collins.com; thomas.petazzoni at bootlin.com
Subject: Re: [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Hi,
Quoted 5 lines
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +3
-0+define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
Quoted 9 lines
Quoted 6 lines
URCE)
Quoted 2 lines
--auto-accept;
+endefThere is already an
FREESCALE_IMX_EXTRACT_HELPERmacro. I guess that should be renamed and used here.I changed this codes accordance with freescale-imx, create new option
FREESCALE_QORIQ_EXTRACT_HELPER
Quoted 8 lines
why
FREESCALE_QORIQ_EXTRACT_HELPER? are there two different ones now? Shouldn't it be justFREESCALE_EXTRACT_HELPER? and the definition of the macro should be moved out of the freescale-imx.mk?or of course, there might be another subdirectory structure like:
packages/freescale/imx
packages/freescale/qoriqpacakges/freescale/helper.mk
I think it makes sense to create another subdirectory like this.
Quoted 12 lines
Or..
packages/freescale/fsl-imx-<package>
packages/freescale/fsl-qoriq-<package>pacakges/freescale/helper.mkAnd the macro might end up in the
pacakges/freescale/helper.mkfile.TBH. I guess there have to be a cleanup before adding the qoriq stuff. Thomas? Matthew?
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Jerry HuangHello,
Quoted 5 lines · On Fri, 22 Nov 2019 10:40:42 +0000 Jerry Huang <[email protected]> wrote:
Quoted 2 lines
There is already an
FREESCALE_IMX_EXTRACT_HELPERmacro. I guess that should be renamed and used here.I changed this codes accordance with freescale-imx, create new option
FREESCALE_QORIQ_EXTRACT_HELPERWill post it to maillist marked "v3"
Could you wait a bit before sending v3, so that some time is given for people to review the patch series? Maybe wait until Monday.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Hi, Thomas and all guys,
I got some feedback from internal company, because Freescale is merged into NXP, we need to use the company NXP, instead of Freescale. So, need some modification for all patches of the board ls1028ardb:
board/nxp
configs/nxp_ls1028ardb*
package/nxp-qoriq/
any comment about that?
Best Regards
Jerry Huang
Quoted 36 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Friday, November 22, 2019 7:06 PM
To: Jerry Huang <[email protected]>
Cc: Michael Walle <[email protected]>; buildroot at busybox.net; geomatsi at gmail.com; matthew.weber at collins.com
Subject: Re: [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Hello,
Quoted 5 lines · On Fri, 22 Nov 2019 10:40:42 +0000 Jerry Huang <[email protected]> wrote:
Quoted 2 lines
There is already an
FREESCALE_IMX_EXTRACT_HELPERmacro. I guess that should be renamed and used here.I changed this codes accordance with freescale-imx, create new option
FREESCALE_QORIQ_EXTRACT_HELPERWill post it to maillist marked "v3"Could you wait a bit before sending v3, so that some time is given for people to review the patch series? Maybe wait until Monday.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7Ce3bcae6699d7446e1 20d08d76f3bf133%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 100175553574097&sdata=nymmd1QloyWLS8NkxwcTksguJfxjL7%2FafehtP tc%2B%2FFE%3D&reserved=0
PATCH v2 7/10 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Changming HuangHello,
Quoted 5 lines · On Thu, 21 Nov 2019 18:23:21 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>
Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to use the nxp branding.
DEVELOPERS F: package/qjson/ · line 2549
Quoted 10 lines
DEVELOPERS +2
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]>
Please sort your name at the right place in the DEVELOPERS file (alphabetic ordering).
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 2
Quoted 8 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware"
Just:
bool "fsl-qorirq-cadence-dp-fw
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 5
Quoted 3 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +3
-0+ help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link: http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
One empty line between the description and the upstream URL, and no "link: " before the link. Also, pointing to the binary file itself is not useful, we need an actual web page. If none exist, just don't provide an upstream URL.
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash line 2
Quoted 8 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58 firmware-cadence-lsdk1909.bin
Hash of the license file is missing.
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +3
-0@@ -0,0 +1,24 @@ +################################################################################ +# +# fsl-qoriq-cadence-dp-fw
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk line 13
Quoted 10 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +10
-0+# +################################################################################ + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SOURCE = firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
Should be "NO" (upper_case)
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk line 17
Quoted 4 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +4
-0+ +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept;
Final semi-colon not needed.
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk line 24
Quoted 7 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk new file +7
-0+endef + +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644 $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin +endef + +$(eval $(generic-package))
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Best Regards
Jerry Huang
Quoted 16 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:12 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Hello,
On Thu, 21 Nov 2019 18:23:21 +0800
Changming Huang <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to use the nxp branding.
Sure, I will rename it.
Quoted 5 lines
Quoted 5 lines
DEVELOPERS +0
-0@@ -2545,3 +2545,6 @@ F: package/qjson/
Quoted 8 lines
DEVELOPERS F: package/qjson/ · line 2549
Quoted 5 lines
DEVELOPERS +2
-0F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]>Please sort your name at the right place in the DEVELOPERS file (alphabetic ordering).
sure
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 2
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware"Just:
Quoted 1 line
bool "fsl-qorirq-cadence-dp-fw
Sure,
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+ help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link: + https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww+ .nxp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
Quoted 1 line
+
amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ce1898ecb342d4abee75c0 8d77
Quoted 1 line
+
1f48c4c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63710316744 6779
Quoted 8 lines
Quoted 1 line
+
441&sdata=%2FM0R2H%2BoS5qxxyzQLATgP7ndtCyNkzyxkFxTHgNuk2o%3 D&
Quoted 1 line
+ ;reserved=0
One empty line between the description and the upstream URL, and no "link: " before the link. Also, pointing to the binary file itself is not useful, we need an actual web page. If none exist, just don't provide an upstream URL.
Remove this link
Quoted 15 lines
Quoted 12 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash
new file mode 100644
index 0000000000..bee912bee1package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +1
-0+++ e-dp-fw.hashpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc line 2
Quoted 2 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256+5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
Quoted 3 lines
Quoted 1 line
+firmware-cadence-lsdk1909.bin
Hash of the license file is missing.
Will add the hash in v3
Quoted 35 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 12 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk
new file mode 100644
index 0000000000..d0d112e25fpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +1
-0+++ e-dp-fw.mk@@ -0,0 +1,24 @@+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc line 4
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +4
-0+########### +# +# fsl-qoriq-cadence-dp-fw +#+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc line 9
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +5
-0+########### + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&data=02%7C01%7Cjerry.huang% 40n
Quoted 1 line
+xp.com%7Ce1898ecb342d4abee75c08d771f48c4c%7C686ea1d3bc2b4c6fa92c d99c5
Quoted 1 line
+c301635%7C0%7C0%7C637103167446779441&sdata=pVGrODu3jQDZKQ cKs1zXSq
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 7 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +7
-0+ihEBQUw7Rq6C%2FRm%2Bn8FKU%3D&reserved=0 +FSL_QORIQ_CADENCE_DP_FW_SOURCE = +firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = noShould be "NO" (
upper_case)
Will correct it
Quoted 10 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +4
-0+ +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh+$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_S OURCE)
Quoted 1 line
+--auto-accept;
Final semi-colon not needed.
Will use below command in v3:
define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
$(call NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE))
endef
Quoted 20 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 8 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +8
-0+endef + +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644 +$(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin +$(BINARIES_DIR)/ls1028a-dp-fw.bin endef + +$(eval $(generic-package))Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7Ce1898ecb342d4abee 75c08d771f48c4c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103167446779441&sdata=VhPk%2Bg9xWrIX%2B9RTaiC3r7KJdiChr2mQ1d h56QLbRyA%3D&reserved=0
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Am 2019-11-26 09:09, schrieb Jerry Huang:
Quoted 59 lines
Best Regards
Jerry HuangQuoted 19 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:12 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com;
geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Hello,
Quoted 2 lines · On Thu, 21 Nov 2019 18:23:21 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Quoted 7 lines
Quoted 3 lines
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to use the nxp
branding.Sure, I will rename it.
Quoted 6 lines
Quoted 6 lines
DEVELOPERS +0
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/Quoted 8 lines
DEVELOPERS F: package/qjson/ · line 2549
Quoted 4 lines
DEVELOPERS +2
-0F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]>Please sort your name at the right place in the DEVELOPERS file (alphabetic
ordering).sure
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 2
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware"Just:
Quoted 2 lines
Quoted 1 line
bool "fsl-qorirq-cadence-dp-fw
Sure,
Sorry about being so pedantic about this.. but like I said before, almost all (there is one exception, "murata-cyw-fw") firmware packages have a -firmware suffix.
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Best Regards
Jerry Huang
Quoted 69 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Tuesday, November 26, 2019 5:22 PM
To: Jerry Huang <[email protected]>
Cc: Thomas Petazzoni <[email protected]>;
buildroot at busybox.net; matthew.weber at collins.com; geomatsi at gmail.com
Subject: Re: [EXT] Re: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Am 2019-11-26 09:09, schrieb Jerry Huang:
Quoted 57 lines
Best Regards
Jerry HuangQuoted 16 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:12 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Hello,
On Thu, 21 Nov 2019 18:23:21 +0800
Changming Huang <[email protected]> wrote:Quoted 8 lines
Quoted 5 lines
From: Jerry Huang <[email protected]>
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to use the nxp branding.
Sure, I will rename it.
Quoted 6 lines
Quoted 6 lines
DEVELOPERS +0
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/Quoted 8 lines
DEVELOPERS F: package/qjson/ · line 2549
Quoted 4 lines
DEVELOPERS +2
-0F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]>Please sort your name at the right place in the DEVELOPERS file (alphabetic
ordering).sure
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 2
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware"Just:
Quoted 6 lines
Quoted 2 lines
Quoted 1 line
bool "fsl-qorirq-cadence-dp-fw
Sure,
Sorry about being so pedantic about this.. but like I said before, almost all (there is one exception, "murata-cyw-fw") firmware packages have a -firmware suffix.
Yes, it has been changed to " qoriq-cadence-dp-firmware " in v3
Quoted 1 line
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
In reply to Jerry Huang[sorry for the second mail]
Am 2019-11-26 09:09, schrieb Jerry Huang:
Quoted 159 lines
Best Regards
Jerry HuangQuoted 19 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:12 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com;
geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Hello,
Quoted 2 lines · On Thu, 21 Nov 2019 18:23:21 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Quoted 7 lines
Quoted 3 lines
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Jerry Huang <[email protected]>Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to use the nxp
branding.Sure, I will rename it.
Quoted 6 lines
Quoted 6 lines
DEVELOPERS +0
-0@@ -2545,3 +2545,6 @@ F: package/qjson/ F: package/quazip/Quoted 8 lines
DEVELOPERS F: package/qjson/ · line 2549
Quoted 4 lines
DEVELOPERS +2
-0F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]>Please sort your name at the right place in the DEVELOPERS file (alphabetic
ordering).sure
Quoted 12 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in line 2
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +2
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW + bool "FSL QorIQ cadence DP firmware"Just:
Quoted 1 line
bool "fsl-qorirq-cadence-dp-fw
Sure,
Quoted 15 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in new file +4
-0+ help + FSL QorIQ cadence DP firmware, a resident EL3 firmware. + link: + https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww+ .nxp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
Quoted 1 line
+
amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ce1898ecb342d4abee75c0 8d77
Quoted 1 line
+
1f48c4c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63710316744 6779
Quoted 1 line
+
441&sdata=%2FM0R2H%2BoS5qxxyzQLATgP7ndtCyNkzyxkFxTHgNuk2o%3 D&
Quoted 7 lines
Quoted 1 line
+ ;reserved=0
One empty line between the description and the upstream URL, and no "link: " before the link. Also, pointing to the binary file itself is not useful, we
need an actual web page. If none exist, just don't provide an upstream URL.Remove this link
Quoted 15 lines
Quoted 12 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.hash
new file mode 100644
index 0000000000..bee912bee1package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +1
-0+++ e-dp-fw.hashpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc line 2
Quoted 2 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256+5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
Quoted 3 lines
Quoted 1 line
+firmware-cadence-lsdk1909.bin
Hash of the license file is missing.
Will add the hash in v3
Quoted 35 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 12 lines
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp -fw.mk
new file mode 100644
index 0000000000..d0d112e25fpackage/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +1
-0+++ e-dp-fw.mk@@ -0,0 +1,24 @@+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc line 4
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +4
-0+########### +# +# fsl-qoriq-cadence-dp-fw +#+###############################################################
######package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc line 9
Quoted 6 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +5
-0+########### + +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909 +FSL_QORIQ_CADENCE_DP_FW_SITE = +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&data=02%7C01%7Cjerry.huang% 40n
Quoted 1 line
+xp.com%7Ce1898ecb342d4abee75c08d771f48c4c%7C686ea1d3bc2b4c6fa92c d99c5
Quoted 1 line
+c301635%7C0%7C0%7C637103167446779441&sdata=pVGrODu3jQDZKQ cKs1zXSq
Quoted 9 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 7 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +7
-0+ihEBQUw7Rq6C%2FRm%2Bn8FKU%3D&reserved=0 +FSL_QORIQ_CADENCE_DP_FW_SOURCE = +firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = noShould be "NO" (
upper_case)Will correct it
Quoted 7 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
Quoted 5 lines
package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc new file +4
-0+ +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS + cd $(@D); \ + sh+$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_S OURCE)
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
+--auto-accept;
Final semi-colon not needed.
Will use below command in v3:
defineQORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS$(callNXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE)) endef
please don't duplicate that piece of code.. it should really be NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx and nxp-qoriq directories. IMHO both should be named consistently. Thomas? Matthew?
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Quoted 11 lines · On Tue, 26 Nov 2019 10:29:18 +0100 Michael Walle <[email protected]> wrote:
Quoted 6 lines
Quoted 1 line
Final semi-colon not needed.
Will use below command in v3:
defineQORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS$(callNXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE)) endef
please don't duplicate that piece of code.. it should really be
NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx and nxp-qoriq directories. IMHO both should be named consistently. Thomas? Matthew?
What are you suggesting? A single package/nxp/ folder, with everything in there?
If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still the question of where to put this common NXP_EXTRACT_HELPER macro
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Am 2019-11-26 11:12, schrieb Thomas Petazzoni:
Quoted 10 lines
Quoted 7 lines · On Tue, 26 Nov 2019 10:29:18 +0100 Michael Walle <[email protected]> wrote:
Quoted 6 lines
Quoted 1 line
Final semi-colon not needed.
Will use below command in v3:
defineQORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS$(callNXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE)) endef
Quoted 7 lines
Quoted 4 lines
please don't duplicate that piece of code.. it should really be
NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx and nxp-qoriq directories. IMHO both should be named consistently. Thomas? Matthew?What are you suggesting? A single package/nxp/ folder, with everything in there?
correct. that would also solve the NXP_EXTRACT_HELPER thing. which would end up inpackage/nxp/helper.mk or something like that.
Quoted 2 lines
If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still the question of where to put this common
NXP_EXTRACT_HELPERmacro
yes. see above.
-michael
[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Best Regards
Jerry Huang
Quoted 30 lines
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Tuesday, November 26, 2019 6:31 PM
To: Thomas Petazzoni <[email protected]>
Cc: Jerry Huang <[email protected]>; buildroot at busybox.net; matthew.weber at collins.com; geomatsi at gmail.com
Subject: Re: [EXT] Re: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new packageCaution: EXT Email
Am 2019-11-26 11:12, schrieb Thomas Petazzoni:
Quoted 8 lines
Quoted 5 lines · On Tue, 26 Nov 2019 10:29:18 +0100 Michael Walle <[email protected]> wrote:
Quoted 5 lines
Quoted 1 line
Final semi-colon not needed.
Will use below command in v3:
defineQORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS$(callNXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/ $(QORI
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
Q_CADENCE_DP_FIRMWARE_SOURCE))
endefplease don't duplicate that piece of code.. it should really be
NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx and nxp-qoriq directories. IMHO both should be named consistently. Thomas? Matthew?
Quoted 5 lines
Quoted 2 lines
What are you suggesting? A single package/nxp/ folder, with everything in there?
correct. that would also solve the
NXP_EXTRACT_HELPERthing. which would end up inpackage/nxp/helper.mkor something like that.
So, first, create directory "package/nxp" and push all ls1028ardb codes (including qoriq-rcw, qoriq-cadence-dp-firmware). Then, move all packages under package/freescale-imx into package/nxp in One separate patch?
Quoted 6 lines
Quoted 2 lines
If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still the question of where to put this common
NXP_EXTRACT_HELPERmacroyes. see above.
-michael
PATCH v2 8/10 package/freescale-qoriq/fsl-qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
In reply to Changming HuangFrom: Jerry Huang <[email protected]>
Because GPIO is used as interrupt for eNETC PHY and Micro-bus, IIC5_PMUX and CLK_OUT_PMUX are enabled for GPIO.
---
changes sinve v1:
1. change to unconditional for these two patches
--- ...b-Enable-IIC5_PMUX-for-GPIO-function.patch | 42 +++++++++++++++++++ ...nable-CLK_OUT_PMUX-for-GPIO-function.patch | 40 ++++++++++++++++++ 2 files changed, 82 insertions(+) create mode 100644 package/freescale-qoriq/fsl-qoriq-rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch create mode 100644 package/freescale-qoriq/fsl-qoriq-rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch
package/freescale-qoriq/fsl-qoriq-rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch new file +42 -0
@@ -0,0 +1,42 @@ +From 33b403cee1fa215927bc65dc14baf35a2fdbe7b3 Mon Sep 17 00:00:00 2001 +From: Jerry Huang <[email protected]> +Date: Thu, 19 Sep 2019 12:12:20 +0800 +Subject: [PATCH 1/2] ls1028ardb: Enable IIC5_PMUX for GPIO function + +Set IIC5_PMUX = 1 to enable GPIO function. + +Signed-off-by: Jianchao Wang <[email protected]> +Signed-off-by: Jerry Huang <[email protected]> +--- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw | 2 +- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +index b46ea2e..5466a63 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +@@ -26,7 +26,7 @@ SYSCLK_FREQ=600 + IIC2_PMUX=6 + IIC3_PMUX=2 + IIC4_PMUX=2 +-IIC5_PMUX=2 ++IIC5_PMUX=1 + IIC6_PMUX=2 + CLK_OUT_PMUX=2 + EC1_SAI4_5_PMUX=5 +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +index 04e2208..1908d8c 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +@@ -26,7 +26,7 @@ SYSCLK_FREQ=600 + IIC2_PMUX=6 + IIC3_PMUX=2 + IIC4_PMUX=2 +-IIC5_PMUX=2 ++IIC5_PMUX=1 + IIC6_PMUX=3 + CLK_OUT_PMUX=2 + EC1_SAI4_5_PMUX=5 +-- +2.17.1
package/freescale-qoriq/fsl-qoriq-rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch new file +40 -0
@@ -0,0 +1,40 @@ +From 4a3c9ea5d0c7bf8eec8cb6276d6f4d940f3946db Mon Sep 17 00:00:00 2001 +From: Jerry Huang <[email protected]> +Date: Thu, 19 Sep 2019 12:13:48 +0800 +Subject: [PATCH 2/2] ls1028ardb/rcw: Enable CLK_OUT_PMUX for GPIO function + +Signed-off-by: Jianchao Wang <[email protected]> +Signed-off-by: Jerry Huang <[email protected]> +--- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw | 2 +- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +index 5466a63..a5ed4d4 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +@@ -28,7 +28,7 @@ IIC3_PMUX=2 + IIC4_PMUX=2 + IIC5_PMUX=1 + IIC6_PMUX=2 +-CLK_OUT_PMUX=2 ++CLK_OUT_PMUX=1 + EC1_SAI4_5_PMUX=5 + EC1_SAI3_6_PMUX=5 + USB3_CLK_FSEL=39 +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +index 1908d8c..c930b83 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +@@ -28,7 +28,7 @@ IIC3_PMUX=2 + IIC4_PMUX=2 + IIC5_PMUX=1 + IIC6_PMUX=3 +-CLK_OUT_PMUX=2 ++CLK_OUT_PMUX=1 + EC1_SAI4_5_PMUX=5 + EC1_SAI3_6_PMUX=5 + USB3_CLK_FSEL=39 +-- +2.17.1
Signature · 1 line
2.17.1
PATCH v2 8/10 package/freescale-qoriq/fsl-qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Quoted 6 lines · On Thu, 21 Nov 2019 18:23:22 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Because GPIO is used as interrupt for eNETC PHY and Micro-bus,
IIC5_PMUXandCLK_OUT_PMUXare enabled for GPIO.Signed-off-by Jerry Huang <[email protected]>
What is the upstream status of those patches? Will NXP merge them in the rcw project, and will make them available as part of a future RCW release ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 08/10] package/freescale-qoriq/fsl-qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Best Regards
Jerry Huang
Quoted 17 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:14 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 08/10] package/freescale-qoriq/fsl-qoriq-rcw:EnableIIC5_PMUXandCLK_OUT_PMUXfor GPIOCaution: EXT Email
Quoted 2 lines · On Thu, 21 Nov 2019 18:23:22 +0800 Changming Huang <[email protected]> wrote:
From: Jerry Huang <[email protected]>
Quoted 7 lines
Quoted 4 lines
Because GPIO is used as interrupt for eNETC PHY and Micro-bus,
IIC5_PMUXandCLK_OUT_PMUXare enabled for GPIO.Signed-off-by Jerry Huang <[email protected]>What is the upstream status of those patches? Will NXP merge them in the rcw project, and will make them available as part of a future RCW release ?
These two patches are for SD and eMMC boot, which are not pushed to upsteam. If I use xSPI boot, the RCW setting is correct without these two patches.
As you mentioned in the reply of patch 10/10, if just one defconfig is pushed to buildroot, I can remove these two patches.
Quoted 11 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C10089319800b42973 24908d771f4bd40%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 103168375059339&sdata=j0xbOhtQRtJfFqW%2BefA1mhEvCczUGIdbk0M COPIzg0k%3D&reserved=0
PATCH v2 9/10 board/freescale/common/ls: Add standard post image script for Layerscape processors
In reply to Changming HuangAdd the standard post image script for Layerscape processors (LS1028A and other processors).
---
changes since v1:
1. update DEVELOPERS
2. modify the condition for display firmware according
--- DEVELOPERS | 1 + board/freescale/common/ls/busybox.config | 9 ++ board/freescale/common/ls/post-image-spi.sh | 64 ++++++++++++++ board/freescale/common/ls/post-image.sh | 92 +++++++++++++++++++++ 4 files changed, 166 insertions(+) create mode 100644 board/freescale/common/ls/busybox.config create mode 100755 board/freescale/common/ls/post-image-spi.sh create mode 100755 board/freescale/common/ls/post-image.sh
DEVELOPERS +1 -0
@@ -2548,3 +2548,4 @@ F: package/tinc/ N: Changming Huang <[email protected]> F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/ +F: board/freescale/common/ls/
board/freescale/common/ls/busybox.config new file +9 -0
@@ -0,0 +1,9 @@ +# +# Additional Busybox Settings +# +CONFIG_TASKSET=y +CONFIG_FEATURE_TASKSET_FANCY=y +CONFIG_FEATURE_DF_FANCY=y +CONFIG_FEATURE_SEAMLESS_GZ=y +CONFIG_FEATURE_SEAMLESS_BZ2=y +CONFIG_FEATURE_SEAMLESS_XZ=y
board/freescale/common/ls/post-image-spi.sh new file +64 -0
64 lines not on this page · raw message
board/freescale/common/ls/post-image.sh new file +92 -0
92 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v2 10/10 configs/freescale_ls1028ardb*: new board
In reply to Changming HuangThis is to support Freescale/NXP LS1028ARDB in Buildroot. The board is setup to track the Linux at 4.19 via NXP LSDK-19.09.
The target will build uboot and RCW binary with arm-trusted-firmware support.
board/freescale/ls1028ardb/: scripts related with ls1028ardb freescale_ls1028ardb-emmc_defconfig: defconfig boot from emmc chip on board freescale_ls1028ardb-sd_defconfig: defconfig boot from SD card freescale_ls1028ardb-xspi_defconfig: defconfig boot from FlexSPI chip on board
---
changes since v1:
1. add new option in configs/freescale_ls1028ardb-xxxx_defconfig
--- .gitlab-ci.yml | 3 + DEVELOPERS | 2 + .../ls1028ardb/genimage.emmc.cfg.template | 52 +++++++ .../ls1028ardb/genimage.sd.cfg.template | 52 +++++++ .../ls1028ardb/genimage.xspi.cfg.template | 53 +++++++ board/freescale/ls1028ardb/kernel.its | 59 ++++++++ .../ls1028ardb/ls1028-10-network.rules | 16 +++ board/freescale/ls1028ardb/post-cfg-udev.sh | 10 ++ board/freescale/ls1028ardb/readme.txt | 61 ++++++++ .../ls1028ardb/u-boot-environment-emmc.txt | 22 +++ .../ls1028ardb/u-boot-environment-sd.txt | 21 +++ .../ls1028ardb/u-boot-environment-xspi.txt | 22 +++ configs/freescale_ls1028ardb-emmc_defconfig | 136 ++++++++++++++++++ configs/freescale_ls1028ardb-sd_defconfig | 135 +++++++++++++++++ configs/freescale_ls1028ardb-xspi_defconfig | 129 +++++++++++++++++ 15 files changed, 773 insertions(+) create mode 100644 board/freescale/ls1028ardb/genimage.emmc.cfg.template create mode 100644 board/freescale/ls1028ardb/genimage.sd.cfg.template create mode 100644 board/freescale/ls1028ardb/genimage.xspi.cfg.template create mode 100644 board/freescale/ls1028ardb/kernel.its create mode 100644 board/freescale/ls1028ardb/ls1028-10-network.rules create mode 100755 board/freescale/ls1028ardb/post-cfg-udev.sh create mode 100644 board/freescale/ls1028ardb/readme.txt create mode 100644 board/freescale/ls1028ardb/u-boot-environment-emmc.txt create mode 100644 board/freescale/ls1028ardb/u-boot-environment-sd.txt create mode 100644 board/freescale/ls1028ardb/u-boot-environment-xspi.txt create mode 100644 configs/freescale_ls1028ardb-emmc_defconfig create mode 100644 configs/freescale_ls1028ardb-sd_defconfig create mode 100644 configs/freescale_ls1028ardb-xspi_defconfig
.gitlab-ci.yml +3 -0
@@ -183,6 +183,9 @@ freescale_imx8qxpmek_defconfig: { extends: .defconfig } freescale_p1025twr_defconfig: { extends: .defconfig } freescale_t1040d4rdb_defconfig: { extends: .defconfig } freescale_t2080_qds_rdb_defconfig: { extends: .defconfig } +freescale_ls1028ardb-emmc_defconfig: { extends: .defconfig } +freescale_ls1028ardb-sd_defconfig: { extends: .defconfig } +freescale_ls1028ardb-xspi_defconfig: { extends: .defconfig } friendlyarm_nanopi_a64_defconfig: { extends: .defconfig } friendlyarm_nanopi_neo2_defconfig: { extends: .defconfig } friendlyarm_nanopi_neo_plus2_defconfig: { extends: .defconfig }
DEVELOPERS +2 -0
@@ -2549,3 +2549,5 @@ F: package/tinc/ N: Changming Huang <[email protected]> F: package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/ F: board/freescale/common/ls/ +F: board/freescale/ls1028ardb/ +F: configs/freescale_ls1028ardb*
board/freescale/ls1028ardb/genimage.emmc.cfg.template new file +52 -0
52 lines not on this page · raw message
board/freescale/ls1028ardb/genimage.sd.cfg.template new file +52 -0
52 lines not on this page · raw message
board/freescale/ls1028ardb/genimage.xspi.cfg.template new file +53 -0
53 lines not on this page · raw message
board/freescale/ls1028ardb/kernel.its new file +59 -0
59 lines not on this page · raw message
board/freescale/ls1028ardb/ls1028-10-network.rules new file +16 -0
@@ -0,0 +1,16 @@ +# ENETC rules +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.0", DRIVERS=="fsl_enetc", NAME:="eno0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.1", DRIVERS=="fsl_enetc", NAME:="eno1" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.2", DRIVERS=="fsl_enetc", NAME:="eno2" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.6", DRIVERS=="fsl_enetc", NAME:="eno3" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.0", DRIVERS=="fsl_enetc_vf", NAME:="eno0vf0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.1", DRIVERS=="fsl_enetc_vf", NAME:="eno0vf1" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.2", DRIVERS=="fsl_enetc_vf", NAME:="eno1vf0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.3", DRIVERS=="fsl_enetc_vf", NAME:="eno1vf1" +# LS1028 switch rules +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p0", NAME="swp0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p1", NAME="swp1" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p2", NAME="swp2" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p3", NAME="swp3" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p4", NAME="swp4" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p5", NAME="swp5"
board/freescale/ls1028ardb/post-cfg-udev.sh new file +10 -0
@@ -0,0 +1,10 @@ +#!/usr/bin/env bash + +main() +{ + cp board/freescale/ls1028ardb/ls1028-10-network.rules ${TARGET_DIR}/etc/udev/rules.d/10-network.rules + + exit $? +} + +main $@
board/freescale/ls1028ardb/readme.txt new file +61 -0
61 lines not on this page · raw message
board/freescale/ls1028ardb/u-boot-environment-emmc.txt new file +22 -0
@@ -0,0 +1,22 @@ +baudrate=115200 +bootcmd=setenv bootargs root=/dev/mmcblk1p2 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200 cma=256M video=1920x1080-32 at 60;mmc dev 1;mmcinfo;fatload mmc 1:1 ${dp_load} ${dp_file};hdp load ${dp_load} ${dp_offset};fatload mmc 1:1 ${loadaddr} ${bootfile};fatload mmc 1:1 ${fdtaddr} ${fdtfile};booti ${loadaddr} - ${fdtaddr} +bootdelay=3 +bootfile=Image +fdtfile=fsl-ls1028a-rdb.dtb +eth2addr=00:1F:7B:63:35:E9 +ethact=FM1 at DTSEC3 +ethprime=FM1 at DTSEC3 +fdt_high=0xffffffffffffffff +fdtcontroladdr=ffc01550 +fman_ucode=ffc12090 +hwconfig=fsl_ddr:bank_intlv=auto +initrd_high=0xffffffffffffffff +loadaddr=0xa0000000 +fdtaddr=0xb0000000 +dp_file=ls1028a-dp-fw.bin +dp_load=0x90000000 +dp_offset=0x2000 +stderr=serial +stdin=serial +stdout=serial +rollbackboot=setenv bootargs root=/dev/ram0 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200;mmcinfo;fatload mmc 0:1 ${loadaddr} ${bootfile};bootm ${loadaddr}
board/freescale/ls1028ardb/u-boot-environment-sd.txt new file +21 -0
@@ -0,0 +1,21 @@ +baudrate=115200 +bootcmd=setenv bootargs root=/dev/mmcblk0p2 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200 cma=256M video=1920x1080-32 at 60;mmcinfo;fatload mmc 0:1 ${dp_load} ${dp_file}; hdp load ${dp_load} ${dp_offset};fatload mmc 0:1 ${loadaddr} ${bootfile};fatload mmc 0:1 ${fdtaddr} ${fdtfile};booti ${loadaddr} - ${fdtaddr} +bootdelay=3 +bootfile=Image +fdtfile=fsl-ls1028a-rdb.dtb +eth2addr=00:1F:7B:63:35:E9 +ethact=FM1 at DTSEC3 +ethprime=FM1 at DTSEC3 +fdt_high=0xffffffffffffffff +fdtcontroladdr=ffc01550 +fman_ucode=ffc12090 +hwconfig=fsl_ddr:bank_intlv=auto +initrd_high=0xffffffffffffffff +loadaddr=0xa0000000 +fdtaddr=0xb0000000 +dp_file=ls1028a-dp-fw.bin +dp_load=0x90000000 +dp_offset=0x2000 +stderr=serial +stdin=serial +stdout=serial
board/freescale/ls1028ardb/u-boot-environment-xspi.txt new file +22 -0
@@ -0,0 +1,22 @@ +baudrate=115200 +bootcmd=setenv bootargs root=/dev/ram0 rw earlycon=uart8250,0x21c0500 console=ttyS0,115200 cma=256M video=1920x1080-32 at 60; sf probe 0:0; sf read $dp_load $dp_start $dp_size; hdp load $dp_load $dp_offset; sf read $kernel_load $kernel_start $kernel_size && bootm $kernel_load +bootdelay=3 +eth2addr=00:1F:7B:63:35:E9 +ethact=FM1 at DTSEC3 +ethprime=FM1 at DTSEC3 +fdt_high=0xffffffffffffffff +fdtcontroladdr=ffc01550 +fman_ucode=ffc12090 +hwconfig=fsl_ddr:bank_intlv=auto +initrd_high=0xffffffffffffffff +kernel_load=0xa0000000 +kernel_size=0x3000000 +kernel_start=0x1000000 +dp_load=0x90000000 +dp_start=0x940000 +dp_size=0x40000 +dp_offset=0x2000 +stderr=serial +stdin=serial +stdout=serial +rollbackboot=setenv bootargs root=/dev/ram0 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200;mmcinfo;fatload mmc 0:1 ${loadaddr} ${bootfile};bootm $loadaddr
configs/freescale_ls1028ardb-emmc_defconfig new file +136 -0
136 lines not on this page · raw message
configs/freescale_ls1028ardb-sd_defconfig new file +135 -0
135 lines not on this page · raw message
configs/freescale_ls1028ardb-xspi_defconfig new file +129 -0
129 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v2 10/10 configs/freescale_ls1028ardb*: new board
Hello,
board/freescale/ls1028ardb/genimage.xspi.cfg.template line 4
Quoted 10 lines · On Thu, 21 Nov 2019 18:23:24 +0800 Changming Huang <[email protected]> wrote:
board/freescale/ls1028ardb/genimage.xspi.cfg.template new file +4
-0@@ -0,0 +1,53 @@ +# Minimal QSPI image for the NXP boards Template +# +# We mimic the .sdcard NXP's image format: +# * the SD card must have 4 kB free space at the beginning,
SD card ? But this file is about creating an image for a QSPI flash.
board/freescale/ls1028ardb/genimage.xspi.cfg.template line 6
Quoted 2 lines
board/freescale/ls1028ardb/genimage.xspi.cfg.template new file +2
-0+# * U-Boot is dumped as is, +# * a single root filesystem partition is required (ext2, ext3 or ext4)
I don't see the root filesystem in this genimage configuration file
configs/freescale_ls1028ardb-emmc_defconfig
Quoted 1 line
configs/freescale_ls1028ardb-emmc_defconfig +0
-0
To be honest, I'm not sure we want 3 different configurations for this board. Can we pick just one ?
Quoted 5 lines
new file mode 100644
index 0000000000..c34db6cb0b
configs/freescale_ls1028ardb-emmc_defconfig line 9
Quoted 9 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +9
-0@@ -0,0 +1,136 @@ +# Architecture +BR2_aarch64=y +BR2_cortex_a72=y + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_EXT2_GZIP=y +BR2_TARGET_ROOTFS_EXT2_SIZE="500M"
Keep the default size and compression.
configs/freescale_ls1028ardb-emmc_defconfig line 18
Quoted 9 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +9
-0+ +# Hostname and issue +BR2_TARGET_GENERIC_HOSTNAME="LS1028ARDB" + +# Linux headers same as kernel +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y + +# toolchain +BR2_TOOLCHAIN_EXTERNAL=y
Please stick to using the internal toolchain for defconfigs.
Quoted 63 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +63
-0+# bootloader +BR2_TARGET_UBOOT=y +BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y +BR2_TARGET_UBOOT_BOARDNAME="ls1028ardb_tfa" +BR2_TARGET_UBOOT_CUSTOM_GIT=y +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://source.codeaurora.org/external/qoriq/qoriq-components/u-boot" +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="LSDK-19.09" +BR2_TARGET_UBOOT_NEEDS_DTC=y +BR2_TARGET_UBOOT_FORMAT_BIN=n +BR2_TARGET_UBOOT_FORMAT_CUSTOM=y +BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-dtb.bin" +BR2_PACKAGE_UBOOT_TOOLS_MKIMAGE=y +BR2_TARGET_UBOOT_ENVIMAGE=y +BR2_TARGET_UBOOT_ENVIMAGE_SOURCE="board/freescale/ls1028ardb/u-boot-environment-emmc.txt" +BR2_TARGET_UBOOT_ENVIMAGE_SIZE="0x2000" + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_GIT=y +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://source.codeaurora.org/external/qoriq/qoriq-components/linux" +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="LSDK-19.09-V4.19" +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="$(LINUX_DIR)/arch/arm64/configs/lsdk.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-ls1028a-rdb" +BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y +BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="Image" + +# Serial port config +BR2_TARGET_GENERIC_GETTY=y +BR2_TARGET_GENERIC_GETTY_PORT="ttyS0" + +# required tools to create the microSD image +BR2_PACKAGE_HOST_DOSFSTOOLS=y +BR2_PACKAGE_HOST_GENIMAGE=y +BR2_PACKAGE_HOST_MTOOLS=y +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/ls/post-image.sh" +BR2_ROOTFS_POST_SCRIPT_ARGS="$(LINUX_DIR) $(TOPDIR) $(UBOOT_DIR)" + +# busybox setting +#BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/freescale/common/ls/busybox.config" +BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y + +# packages for rcw +BR2_PACKAGE_HOST_RCW=y +BR2_PACKAGE_HOST_RCW_ATF=y +BR2_PACKAGE_HOST_RCW_BOOT_MODE="emmc" +BR2_PACKAGE_HOST_RCW_BIN="ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.bin" + +#Display port firmware +BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW=y + +# basic packages and tools +BR2_PACKAGE_MTD=y +BR2_PACKAGE_MTD_MTD_DEBUG=y +BR2_PACKAGE_SYSSTAT=y +BR2_PACKAGE_E2FSPROGS=y +BR2_PACKAGE_RT_TESTS=y +BR2_PACKAGE_OPENSSH=y +BR2_PACKAGE_OPENSSL=y +BR2_PACKAGE_WGET=y + +# docker packages
configs/freescale_ls1028ardb-emmc_defconfig line 92
Quoted 10 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +10
-0+BR2_PACKAGE_DOCKER_CONTAINERD=y +BR2_PACKAGE_DOCKER_ENGINE=y +BR2_PACKAGE_DOCKER_ENGINE_DAEMON=y +BR2_PACKAGE_DOCKER_ENGINE_EXPERIMENTAL=y +BR2_PACKAGE_DOCKER_ENGINE_DRIVER_BTRFS=y +BR2_PACKAGE_DOCKER_ENGINE_DRIVER_DEVICEMAPPER=y +BR2_PACKAGE_DOCKER_ENGINE_DRIVER_VFS=y +BR2_PACKAGE_UTIL_LINUX_LIBMOUNT=y +BR2_PACKAGE_CGROUPFS_MOUNT=y +BR2_PACKAGE_LIBCGROUP=y
Please remove all extra packages: keep only Busybox in the target filesystem. We want minimal defconfigs, that only build the bootloader, kernel and a minimal root filesystem.
Thanks!
Thmas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH v2 10/10] configs/freescale_ls1028ardb*: new board
Best Regards
Jerry Huang
Quoted 17 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Tuesday, November 26, 2019 6:18 AM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net; michael at walle.cc; matthew.weber at collins.com; geomatsi at gmail.com
Subject: [EXT] Re: [Buildroot] [PATCH v2 10/10] configs/freescale_ls1028ardb*:
new boardCaution: EXT Email
Hello,
On Thu, 21 Nov 2019 18:23:24 +0800
Changming Huang <[email protected]> wrote:
Quoted 12 lines
board/freescale/ls1028ardb/genimage.xspi.cfg.template line 3
Quoted 10 lines
board/freescale/ls1028ardb/genimage.xspi.cfg.template new file +3
-0@@ -0,0 +1,53 @@ +# Minimal QSPI image for the NXP boards Template # # We mimic the +.sdcard NXP's image format: +# * the SD card must have 4 kB free space at the beginning,SD card ? But this file is about creating an image for a QSPI flash.
Will fix that in v3
Quoted 5 lines
board/freescale/ls1028ardb/genimage.xspi.cfg.template line 6
Quoted 3 lines
board/freescale/ls1028ardb/genimage.xspi.cfg.template new file +3
-0+# * U-Boot is dumped as is, +# * a single root filesystem partition is required (ext2, ext3 or +ext4)I don't see the root filesystem in this genimage configuration file
Will fix that in v3
Quoted 5 lines
configs/freescale_ls1028ardb-emmc_defconfig
Quoted 2 lines
configs/freescale_ls1028ardb-emmc_defconfig +0
-0To be honest, I'm not sure we want 3 different configurations for this board. Can we pick just one ?
There are three basic boot mode for ls1028ardb, so three configurations is for this board. I think we need these three configurations.
Quoted 8 lines
Quoted 8 lines
new file mode 100644
index 0000000000..c34db6cb0bconfigs/freescale_ls1028ardb-emmc_defconfig new file +3
-0@@ -0,0 +1,136 @@ +# Architecture +BR2_aarch64=y +BR2_cortex_a72=y
Quoted 8 lines
configs/freescale_ls1028ardb-emmc_defconfig line 9
Quoted 6 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +6
-0+ +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_EXT2_GZIP=y +BR2_TARGET_ROOTFS_EXT2_SIZE="500M"Keep the default size and compression.
Sure,
Quoted 11 lines
configs/freescale_ls1028ardb-emmc_defconfig line 18
Quoted 9 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +9
-0+ +# Hostname and issue +BR2_TARGET_GENERIC_HOSTNAME="LS1028ARDB" + +# Linux headers same as kernel +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y + +# toolchain +BR2_TOOLCHAIN_EXTERNAL=yPlease stick to using the internal toolchain for defconfigs.
Sure,
Quoted 91 lines
configs/freescale_ls1028ardb-emmc_defconfig line 24
Quoted 6 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +5
-0+# bootloader +BR2_TARGET_UBOOT=y +BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y +BR2_TARGET_UBOOT_BOARDNAME="ls1028ardb_tfa" +BR2_TARGET_UBOOT_CUSTOM_GIT=y+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://eur01.safelinks.protectio n.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fqo riq%2Fqoriq-components%2Fu-boot&data=02%7C01%7Cjerry.huang%40nx p.com%7C8bf20e9e0b6144a467fa08d771f5485b%7C686ea1d3bc2b4c6fa92cd9 9c5c301635%7C0%7C0%7C637103170604588864&sdata=y79I0o0l%2F%2 BpHp9bkvMis693dAAbhvXUcIkCS%2BTBSetQ%3D&reserved=0"
configs/freescale_ls1028ardb-emmc_defconfig line 32
Quoted 8 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +7
-0+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="LSDK-19.09" +BR2_TARGET_UBOOT_NEEDS_DTC=y +BR2_TARGET_UBOOT_FORMAT_BIN=n +BR2_TARGET_UBOOT_FORMAT_CUSTOM=y +BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-dtb.bin" +BR2_PACKAGE_UBOOT_TOOLS_MKIMAGE=y +BR2_TARGET_UBOOT_ENVIMAGE=y+BR2_TARGET_UBOOT_ENVIMAGE_SOURCE="board/freescale/ls1028ardb/u-b oot-environment-emmc.txt"
configs/freescale_ls1028ardb-emmc_defconfig line 38
Quoted 6 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +5
-0+BR2_TARGET_UBOOT_ENVIMAGE_SIZE="0x2000" + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_GIT=y+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://eur01.safelinks.protection .outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fqor iq%2Fqoriq-components%2Flinux&data=02%7C01%7Cjerry.huang%40nxp. com%7C8bf20e9e0b6144a467fa08d771f5485b%7C686ea1d3bc2b4c6fa92cd99c 5c301635%7C0%7C0%7C637103170604588864&sdata=mSyrWd0ZWOMh gsvIXTUx4y3sAITe50SLIhZ%2Bo14qIXc%3D&reserved=0"
configs/freescale_ls1028ardb-emmc_defconfig line 37
Quoted 3 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +2
-0+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="LSDK-19.09-V4.19" +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="$(LINUX_DIR)/arch/arm64 /configs/lsdk.config"
configs/freescale_ls1028ardb-emmc_defconfig line 55
Quoted 13 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +12
-0+BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-ls1028a-rdb" +BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y +BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="Image" + +# Serial port config +BR2_TARGET_GENERIC_GETTY=y +BR2_TARGET_GENERIC_GETTY_PORT="ttyS0" + +# required tools to create the microSD image +BR2_PACKAGE_HOST_DOSFSTOOLS=y BR2_PACKAGE_HOST_GENIMAGE=y +BR2_PACKAGE_HOST_MTOOLS=y+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/ls/post-image .sh"
configs/freescale_ls1028ardb-emmc_defconfig line 50
Quoted 1 line
configs/freescale_ls1028ardb-emmc_defconfig new file +1
-0+BR2_ROOTFS_POST_SCRIPT_ARGS="$(LINUX_DIR) $(TOPDIR)$(UBOOT_DIR)"
configs/freescale_ls1028ardb-emmc_defconfig line 52
Quoted 3 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +2
-0+ +# busybox setting+#BR2_PACKAGE_BUSYBOX_CONFIG_FRAGMENT_FILES="board/freescale/com
mon/ls/busybox.config"configs/freescale_ls1028ardb-emmc_defconfig line 66
Quoted 7 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +6
-0+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y + +# packages for rcw +BR2_PACKAGE_HOST_RCW=y +BR2_PACKAGE_HOST_RCW_ATF=y +BR2_PACKAGE_HOST_RCW_BOOT_MODE="emmc"+BR2_PACKAGE_HOST_RCW_BIN="ls1028ardb/R_SQPP_0x85bb/rcw_1300_em mcboot.bin"
Quoted 21 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +21
-0+ +#Display port firmware +BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW=y + +# basic packages and tools +BR2_PACKAGE_MTD=y +BR2_PACKAGE_MTD_MTD_DEBUG=y +BR2_PACKAGE_SYSSTAT=y +BR2_PACKAGE_E2FSPROGS=y +BR2_PACKAGE_RT_TESTS=y +BR2_PACKAGE_OPENSSH=y +BR2_PACKAGE_OPENSSL=y +BR2_PACKAGE_WGET=y + +# docker packages +BR2_PACKAGE_DOCKER_CONTAINERD=y +BR2_PACKAGE_DOCKER_ENGINE=y +BR2_PACKAGE_DOCKER_ENGINE_DAEMON=y +BR2_PACKAGE_DOCKER_ENGINE_EXPERIMENTAL=y +BR2_PACKAGE_DOCKER_ENGINE_DRIVER_BTRFS=y +BR2_PACKAGE_DOCKER_ENGINE_DRIVER_DEVICEMAPPER=y
Quoted 8 lines
configs/freescale_ls1028ardb-emmc_defconfig line 92
Quoted 4 lines
configs/freescale_ls1028ardb-emmc_defconfig new file +4
-0+BR2_PACKAGE_DOCKER_ENGINE_DRIVER_VFS=y +BR2_PACKAGE_UTIL_LINUX_LIBMOUNT=y +BR2_PACKAGE_CGROUPFS_MOUNT=y +BR2_PACKAGE_LIBCGROUP=yPlease remove all extra packages: keep only Busybox in the target filesystem. We want minimal defconfigs, that only build the bootloader, kernel and a minimal root filesystem.
sure
Quoted 11 lines
Thanks!
Thmas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C8bf20e9e0b6144a467 fa08d771f5485b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371 03170604588864&sdata=yvLKBVKXw7uBYHIPRRwjz6BzvH%2BO778aOz5i oYSBN1I%3D&reserved=0