Skip to contentSkip to conversation

nfc: port100: handle command failure cleanly

PATCH Applied Oliver Neukum 2 participants 2 messages Nov 21, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfc: port100: handle command failure cleanly

If starting the transfer of a command suceeds but the transfer for the reply fails, it is not enough to initiate killing the transfer for the command may still be running. You need to wait for the killing to finish before you can reuse URB and buffer.

Reported-and-tested-by [email protected]
---
 drivers/nfc/port100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nfc/port100.c +1 -1
index 145ddf3f0a45..604dba4f18af 100644
@@ -783,7 +783,7 @@ static int port100_send_frame_async(struct port100 *dev, struct sk_buff *out,
 
 	rc = port100_submit_urb_for_ack(dev, GFP_KERNEL);
 	if (rc)
-		usb_unlink_urb(dev->out_urb);
+		usb_kill_urb(dev->out_urb);
 
 exit:
 	mutex_unlock(&dev->out_urb_lock);
Signature · 1 line
2.16.4
maintainer Applied
#1 lore raw

From: Oliver Neukum <[email protected]>
Date: Thu, 21 Nov 2019 11:37:10 +0100

Quoted 7 lines

If starting the transfer of a command suceeds but the transfer for the reply fails, it is not enough to initiate killing the transfer for the command may still be running. You need to wait for the killing to finish before you can reuse URB and buffer.

Reported-and-tested-by [email protected]

Applied.