Skip to contentSkip to conversation

ath6kl: reduce WARN to dev_dbg() in callback

PATCH New Oliver Neukum 1 participant 1 message Nov 21, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath6kl: reduce WARN to dev_dbg() in callback

The warn is triggered on a known race condition that is correctly handled. Using WARN() hinders automated testing. Reducing severity.

Reported-and-tested-by [email protected]
---
 drivers/net/wireless/ath/ath6kl/htc_pipe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath6kl/htc_pipe.c +2 -2
index c68848819a52..9b88d96bfe96 100644
@@ -960,8 +960,8 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
 	 * Thus the possibility of ar->htc_target being NULL
 	 * via ath6kl_recv_complete -> ath6kl_usb_io_comp_work.
 	 */
-	if (WARN_ON_ONCE(!target)) {
-		ath6kl_err("Target not yet initialized\n");
+	if (!target) {
+		ath6kl_dbg(ATH6KL_DBG_HTC, "Target not yet initialized\n");
 		status = -EINVAL;
 		goto free_skb;
 	}
Signature · 1 line
2.16.4